Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle indirect changes comparison in net new files #2811

Closed
suejung-sentry opened this issue Oct 31, 2024 · 2 comments
Closed

Handle indirect changes comparison in net new files #2811

suejung-sentry opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
bug Something isn't working High High Priority Issues (to be fixed within 2 sprints)

Comments

@suejung-sentry
Copy link

suejung-sentry commented Oct 31, 2024

Describe the bug
I believe when we try to fetch segments data in the Indirect changes comparison against a file that exists in main but not yet in the branch for the PR, there is an "unknown path" error.

To Reproduce
Here are a couple examples - go to the links and try to expand the toggle and see the page resolve to an error page.
https://app.codecov.io/github/codecov/codecov-api/pull/945/indirect-changes
https://app.codecov.io/github/codecov/gazebo/pull/3457/indirect-changes

The ImpactedFileComparison query to fetch segments shows UnknownPath error. From what I can tell, this appears to happen in the case when the PR needs to get rebased to pick up information about a new file.

Example

To fix, confirm that is what's going on here and have a better comparison for this case (or a better error message)

Additional context

Image
Image
hangs around with loading spinner for a bit, then resolves to the error page due to the UnknownPath
Image
Image

@suejung-sentry suejung-sentry added the bug Something isn't working label Oct 31, 2024
@drazisil-codecov drazisil-codecov added the High High Priority Issues (to be fixed within 2 sprints) label Nov 7, 2024
@eliatcodecov
Copy link

@katia-sentry , based on the discussion above, it feels like @suejung-sentry has the most context. But I'll leave assignment to you since I don't have a sense of difficulty on this ticket nor the upcoming sprint schedule of the team.

@suejung-sentry
Copy link
Author

Closing this ticket as the issue described here should be resolved when the work in #2803 is done

@suejung-sentry suejung-sentry closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High High Priority Issues (to be fixed within 2 sprints)
Projects
None yet
Development

No branches or pull requests

4 participants