From fdcee88bbdd2ef6b4dbd5e201928a3981679b81f Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Mon, 3 Jun 2024 12:00:43 -0300 Subject: [PATCH 1/4] remove dryRun from nuxt --- examples/nuxt/nuxt.config.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/nuxt/nuxt.config.ts b/examples/nuxt/nuxt.config.ts index 8a9b5f36..8ca6dee4 100644 --- a/examples/nuxt/nuxt.config.ts +++ b/examples/nuxt/nuxt.config.ts @@ -5,7 +5,6 @@ export default defineNuxtConfig({ [ "@codecov/nuxt-plugin", { - dryRun: true, enableBundleAnalysis: true, bundleName: "@codecov/example-nuxt-app", uploadToken: process.env.VITE_UPLOAD_TOKEN, From e2abb0e10e07c5e225e9306e42e5062102513332 Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Mon, 3 Jun 2024 12:00:59 -0300 Subject: [PATCH 2/4] remove dryRun from svelteKit --- examples/sveltekit/vite.config.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/sveltekit/vite.config.ts b/examples/sveltekit/vite.config.ts index e1a6624a..255fe76e 100644 --- a/examples/sveltekit/vite.config.ts +++ b/examples/sveltekit/vite.config.ts @@ -6,7 +6,6 @@ export default defineConfig({ plugins: [ sveltekit(), codecovSvelteKitPlugin({ - dryRun: true, enableBundleAnalysis: true, uploadToken: "test-token", bundleName: "@codecov/example-sveltekit-app", From f880a8157c46bc27c539c1c08795482f93228663 Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Mon, 3 Jun 2024 13:31:53 -0300 Subject: [PATCH 3/4] add in env vars for nuxt and sveltekit --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9b342ead..63cf8e90 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -327,8 +327,12 @@ jobs: env: NEXT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} NEXT_API_URL: ${{ secrets.CODECOV_API_URL }} + NUXT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} + NUXT_API_URL: ${{ secrets.CODECOV_API_URL }} ROLLUP_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} ROLLUP_API_URL: ${{ secrets.CODECOV_API_URL }} + SVELTEKIT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} + SVELTEKIT_API_URL: ${{ secrets.CODECOV_API_URL }} VITE_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} VITE_API_URL: ${{ secrets.CODECOV_API_URL }} WEBPACK_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} @@ -390,8 +394,12 @@ jobs: env: NEXT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN_STAGING }} NEXT_API_URL: ${{ secrets.CODECOV_STAGING_API_URL }} + NUXT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} + NUXT_API_URL: ${{ secrets.CODECOV_API_URL }} ROLLUP_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN_STAGING }} ROLLUP_API_URL: ${{ secrets.CODECOV_STAGING_API_URL }} + SVELTEKIT_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} + SVELTEKIT_API_URL: ${{ secrets.CODECOV_API_URL }} VITE_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN_STAGING }} VITE_API_URL: ${{ secrets.CODECOV_STAGING_API_URL }} WEBPACK_UPLOAD_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN_STAGING }} From 2970916e1130680deaf235368a8f2b8ff75f571c Mon Sep 17 00:00:00 2001 From: nicholas-codecov Date: Mon, 3 Jun 2024 13:32:20 -0300 Subject: [PATCH 4/4] update env vars for nuxt and sveltekit --- examples/nuxt/nuxt.config.ts | 4 ++-- examples/sveltekit/vite.config.ts | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/nuxt/nuxt.config.ts b/examples/nuxt/nuxt.config.ts index 8ca6dee4..560966a2 100644 --- a/examples/nuxt/nuxt.config.ts +++ b/examples/nuxt/nuxt.config.ts @@ -7,8 +7,8 @@ export default defineNuxtConfig({ { enableBundleAnalysis: true, bundleName: "@codecov/example-nuxt-app", - uploadToken: process.env.VITE_UPLOAD_TOKEN, - apiUrl: process.env.VITE_API_URL, + uploadToken: process.env.NUXT_UPLOAD_TOKEN, + apiUrl: process.env.NUXT_API_URL, }, ], ], diff --git a/examples/sveltekit/vite.config.ts b/examples/sveltekit/vite.config.ts index 255fe76e..d2bbd283 100644 --- a/examples/sveltekit/vite.config.ts +++ b/examples/sveltekit/vite.config.ts @@ -7,8 +7,9 @@ export default defineConfig({ sveltekit(), codecovSvelteKitPlugin({ enableBundleAnalysis: true, - uploadToken: "test-token", bundleName: "@codecov/example-sveltekit-app", + uploadToken: process.env.SVELTEKIT_UPLOAD_TOKEN, + apiUrl: process.env.SVELTEKIT_API_URL, }), ], });