Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to version 25.0.0 of Keycloak #770

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

hansehe
Copy link
Contributor

@hansehe hansehe commented Jun 14, 2024

Upgraded to version 25.0.0 of Keycloak. Tested in separate systems, and only change needed was to use the new internal 9000 port for health checks and metrics.

@hansehe hansehe requested a review from a team as a code owner June 14, 2024 08:33
@amarkevich
Copy link

Can be internal port parametrized to be compatible with previous Keycloak versions? (just an idea)

@hansehe
Copy link
Contributor Author

hansehe commented Jun 17, 2024

Yep, sounds good, and think my latest commit should fix it. I kept the http-internal port there for all cases, since it shouldn't matter if an extra port is exposed, although not used.

@hansehe
Copy link
Contributor Author

hansehe commented Jun 18, 2024

Seems like the lint tests failed during the test setup.

@pascal-sochacki
Copy link
Collaborator

pascal-sochacki commented Jun 20, 2024

Hey there, I just received access to this Repo and will look at the failing Pipeline later today or tomorrow

@pascal-sochacki
Copy link
Collaborator

Hey, I updated the failing job to the newest version in #772, could you rebase your branch, and we will see if it works now?

@hansehe
Copy link
Contributor Author

hansehe commented Jun 21, 2024

Yes, rebased now and it seems to work, and thanks.

Copy link
Collaborator

@pascal-sochacki pascal-sochacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the Pipeline? It look like further adjustments are required for the new Version.

charts/keycloakx/templates/statefulset.yaml Outdated Show resolved Hide resolved
@pascal-sochacki pascal-sochacki merged commit e1f5237 into codecentric:master Jun 24, 2024
3 checks passed
@karazy
Copy link

karazy commented Jun 27, 2024

Great to see support for v25. Thanks a lot. Please create a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants