Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"New Version Available" check #189

Open
aniri opened this issue Jan 12, 2020 · 9 comments · May be fixed by #228
Open

"New Version Available" check #189

aniri opened this issue Jan 12, 2020 · 9 comments · May be fixed by #228
Labels
autumn-2020 enhancement New feature or request help wanted Extra attention is needed medium-priority

Comments

@aniri
Copy link
Member

aniri commented Jan 12, 2020 •
edited
Loading

Every time a user opens the app we should check if they're on the latest version on the Play Store. If they're not, we should show a dialog that tells them to update.

Ideally we'd have 2 flags on RemoteConfig:

  • android_check_update_available
  • android_force_update - if this is true, we should not let the user get past that screen until she's on the latest version.

Both flags will default to true.

Should look similar to the iOS implementation:
Simulator Screen Shot - iPhone 11 Pro - 2020-01-13 at 11 06 02

Texts:
EN

  • title: App Update Available
  • text: A new app version is available. Please update the app to use the latest features

RO

  • title: Actualizare disponibilă
  • text: O nouă versiune a aplicației este disponibilă. Te rugăm să faci update pentru a folosi cele mai recente funcționalități.
@aniri aniri added enhancement New feature or request help wanted Extra attention is needed medium-priority autumn-2020 labels Jan 12, 2020
@aniri aniri changed the title "New Version Available" screen "New Version Available" check Jan 13, 2020
@lukstbit
Copy link
Contributor

lukstbit commented Jan 13, 2020 •
edited
Loading

Is the dialog UI an absolute requirement?
If not we could use the default in-app updates. This would require a dependency on the com.google.android.play:core library from Google.

@aniri
Copy link
Member Author

aniri commented Jan 13, 2020

Is the dialog UI an absolute requirement?
If not we could use the default in-app updates. This would require a dependency on the com.google.android.play:core library from Google.

@lukstbit no, the dialog is not a requirement, it is just a suggestion. You are right, using the default in-app updates would be better :)

@aniri
Copy link
Member Author

aniri commented Aug 23, 2020

hey @lukstbit 😃 ! would you be interested in handling this task with the default in-app updates?

@VladCuciureanu
Copy link

@aniri I'll take this issue if it's still free

@aniri
Copy link
Member Author

aniri commented Oct 7, 2020

@aniri I'll take this issue if it's still free

@VladCuciureanu yep, it's free! thanks!

@pedrofsn
Copy link
Contributor

@aniri this task is opened yet? If yes, I could help!

@aniri
Copy link
Member Author

aniri commented Oct 27, 2020

@aniri this task is opened yet? If yes, I could help!

@pedrofsn thanks for your interest, but this task is already assigned to someone.

@VladCuciureanu
Copy link

@pedrofsn I would be willing to pass the issue over to you. I couldn't figure out how to implement and/or test this. Maybe you'll have more luck :)

@VladCuciureanu VladCuciureanu removed their assignment Oct 31, 2020
@pedrofsn
Copy link
Contributor

Hi, i did this task but it's getting some firebase erros.
I've tried to initialize with and without koin but not worked. If it can be fixed, the update flow will works!

The error:
Unable to start activity ComponentInfo{ro.code4.monitorizarevot/ro.code4.monitorizarevot.ui.login.LoginActivity}: java.lang.IllegalStateException: Default FirebaseApp is not initialized in this process ro.code4.monitorizarevot. Make sure to call FirebaseApp.initializeApp(Context) first.
[...]
Make sure to call FirebaseApp.initializeApp(Context) first.

@pedrofsn pedrofsn linked a pull request Oct 31, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autumn-2020 enhancement New feature or request help wanted Extra attention is needed medium-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature update version dialog pedrofsn/mon-vot-android-kotlin
4 participants
@aniri @pedrofsn @lukstbit @VladCuciureanu