Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ProgressDialogFragment crash the app when fast switching to fragments #177

Open
catalin-florescu opened this issue Dec 2, 2019 · 2 comments · May be fixed by #226
Open

[Bug] ProgressDialogFragment crash the app when fast switching to fragments #177

catalin-florescu opened this issue Dec 2, 2019 · 2 comments · May be fixed by #226
Labels
autumn-2020 bug Something isn't working

Comments

@catalin-florescu
Copy link

catalin-florescu commented Dec 2, 2019 •
edited
Loading

image
Using DialogFragment or ProgressDialog could lead to crash if is trying to show when fragment is not attached or shown.
As a fast solve you could check if the fragment is added

override fun onPageFinished() { if (isAdded) progressDialog.dismiss() }

override fun onLoading() { if (isAdded && !progressDialog.isResumed) {...} }
@aniri aniri added the bug Something isn't working label Jul 25, 2020
@aniri aniri mentioned this issue Oct 25, 2020
Closed
@pedrofsn pedrofsn linked a pull request Oct 25, 2020 that will close this issue
Open
@pedrofsn
Copy link
Contributor

I've tried to fix this #226

@pedrofsn
Copy link
Contributor

I've updated code, now it's running. Please, take a look in #226 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autumn-2020 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dialog initialization time pedrofsn/mon-vot-android-kotlin
3 participants
@aniri @pedrofsn @catalin-florescu