New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't place order in magento 2.4.3-p1, getting error "add_gift_foreach is unknown type" . #36

Open

anasshl opened this issue Jun 24, 2022 · 1 comment

anasshl commented Jun 24, 2022

Preconditions

Magento version: 2.4.3p1
Module version: 1.0.0

Settings / Sale Rules

Create new sales rule
Add gift product SKU
Set Discount amount to 1
Set Maximum Qty Discount is Applied To 1
Set condition -Row total in cart greater then 50 -

Steps to reproduce

Install extension
Add product to cart
Check if gift Item is added to cart and go to checkout page
Click button Place Order

Expected result

Order Success

Actual result

Error 500
"message":"add_gift_foreach is unknown type",
"trace":"#0 /srv/web/staging/vendor/magento/module-sales-rule/Model/RulesApplier.php(224): Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory->create()\n

Contributor

domeglic commented Aug 10, 2022

Sorry for the delay, is the module version really 1.0.0? Because I wasn't able to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment