Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup entire login and course purchase setup #175

Closed
wants to merge 11 commits into from
Closed

feat: setup entire login and course purchase setup #175

wants to merge 11 commits into from

Conversation

devsargam
Copy link
Collaborator

@devsargam devsargam commented Mar 10, 2024

Resolves #169

This pr currently adds:

  • Ability to signup in house
  • Hash Password
  • In house sign in
  • Ability to purchase a course in house
  • Change the schema for storing purchases
  • Integrate Razorpay

In future:

  • Verify the user with some method Not required for v0

@devsargam
Copy link
Collaborator Author

hey @hkirat, how should I proceed with mail verification? I can implement it my way but what would suit you the most???

@hkirat
Copy link
Contributor

hkirat commented Mar 10, 2024

No need to verify emails for v0

@devsargam
Copy link
Collaborator Author

hey @hkirat, Do we need to support login with appx as a fallback method?

@devsargam
Copy link
Collaborator Author

Also, just to be sure, content is still comming from appx right?

@hkirat
Copy link
Contributor

hkirat commented Mar 10, 2024

No all content is in house currently as well
appx gives us

  1. authentication (they store user information)
  2. Let us know which user has purchased which course - ref - https://github.com/code100x/cms/blob/main/src/utiles/appx.ts#L15

@devsargam
Copy link
Collaborator Author

oh, makes a lot sense. Thanks

@devsargam
Copy link
Collaborator Author

Kapture.2024-03-11.at.23.28.06.mp4

@devsargam devsargam marked this pull request as ready for review March 11, 2024 18:00
@devsargam
Copy link
Collaborator Author

devsargam commented Mar 11, 2024

@hkirat ready for review. Could you check this out?

cc: @siinghd

return courses;
}

const baseUrl = `${APPX_BASE_API}/get/checkemailforpurchase`;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the entire appx dependency from the project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this might be tricky we need some backward compatability for the current courses

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that was what I was basically worried about but seems doable.
I am here to put every ounce of effort for this pr just let me know!!!!

@devsargam
Copy link
Collaborator Author

As this is v0 a lot of things to be improved. LMK your thoughts on this and I shall continue.

PR already getting a lot large and messy.

@devsargam
Copy link
Collaborator Author

@hkirat hoping it comes to your notifs

@hkirat
Copy link
Contributor

hkirat commented Mar 11, 2024

Will review it asap

@hkirat hkirat self-requested a review March 11, 2024 19:17
@devsargam
Copy link
Collaborator Author

Just clarifying a few things
I have left a bunch of TODOs which can be their own issue.
Simple enough to fix not totally necessary but can make the app a lot better and performant
not totally sure thooo

@devsargam devsargam closed this Mar 31, 2024
@devsargam devsargam deleted the setup-login branch March 31, 2024 15:57
@devsargam devsargam restored the setup-login branch April 2, 2024 21:21
@devsargam devsargam reopened this Apr 2, 2024
@hkirat
Copy link
Contributor

hkirat commented Apr 21, 2024

too many merge confs, gonna close for now

@hkirat hkirat closed this Apr 21, 2024
@devsargam devsargam deleted the setup-login branch June 6, 2024 08:14
@hkirat
Copy link
Contributor

hkirat commented Jun 6, 2024

checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add purchases, payment information
2 participants