-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup entire login and course purchase setup #175
Conversation
hey @hkirat, how should I proceed with mail verification? I can implement it my way but what would suit you the most??? |
No need to verify emails for v0 |
hey @hkirat, Do we need to support login with appx as a fallback method? |
Also, just to be sure, content is still comming from appx right? |
No all content is in house currently as well
|
oh, makes a lot sense. Thanks |
Kapture.2024-03-11.at.23.28.06.mp4 |
return courses; | ||
} | ||
|
||
const baseUrl = `${APPX_BASE_API}/get/checkemailforpurchase`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the entire appx dependency from the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this might be tricky we need some backward compatability for the current courses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that was what I was basically worried about but seems doable.
I am here to put every ounce of effort for this pr just let me know!!!!
As this is v0 a lot of things to be improved. LMK your thoughts on this and I shall continue. PR already getting a lot large and messy. |
@hkirat hoping it comes to your notifs |
Will review it asap |
Just clarifying a few things |
too many merge confs, gonna close for now |
checking |
Resolves #169
This pr currently adds:
In future:
Verify the user with some methodNot required for v0