Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$reviewUrl throws 500 on live workspace #4

Open
paavo opened this issue Aug 6, 2021 · 1 comment
Open

$reviewUrl throws 500 on live workspace #4

paavo opened this issue Aug 6, 2021 · 1 comment

Comments

@paavo
Copy link
Contributor

paavo commented Aug 6, 2021

With activated $this->settings['notify']['publicWorkspace'] you get notified about changes to the live workspace.
The generated $reviewUrl throws an error 500, cause you can't show changes on the live workspace.

Generated $reviewUrl for a "not-live" Workspace (ex. Preview)
/neos/management/workspaces/show?moduleArguments%5Bworkspace%5D%5B__identity%5D=preview-xbpqb

Generated $reviewUrl for the "live" Workspace throws an Error 500
/neos/management/workspaces/show?moduleArguments[workspace][__identity]=live
paavo added a commit to paavo/neos-publishnotifier that referenced this issue Aug 6, 2021
@paavo
Fix: $reviewUrl throws 500 on live workspace
c6d4440 
Fixes code-q-web-factory#4
@paavo paavo mentioned this issue Aug 6, 2021
Closed
@rolandschuetz
Copy link
Contributor

Good point, thanks for the issue and pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: $reviewUrl throws 500 on live workspace paavo/neos-publishnotifier
2 participants
@rolandschuetz @paavo