-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestHistoryMetrics.testEvents pixel flake #21422
Comments
martinpitt
changed the title
Tests failed on 2d6af150d3a8a900a643e71b7bb03b2e495463d1
TestHistoryMetrics.testEvents pixel flake
Dec 11, 2024
This isn't related to updates-testing FTR, it happens on current image as well. |
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this issue
Dec 11, 2024
In the medium layout, the bottom panel sometimes has an extra white background line (padding). This is random and unpredictable (probably rounding noise?). That panel only contains a single standard button, so is not very interesting. Just ignore that part. Fixes cockpit-project#21422
Compare the screenshot with the reference, it's really just the extra background line. Hint for running locally:
(otherwise time differs, and tracer crashes get in the way). I've run this umpteen times locally and cannot reproduce it, though 😢 |
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this issue
Dec 11, 2024
In the medium layout, the bottom panel sometimes has an extra white background line (padding). This is random and unpredictable (probably rounding noise?). That panel only contains a single standard button, so is not very interesting. We can't use `ignore=` for that, as the difference is the snapshot height, not the pixel contents. So instead, temporarily hide the whole bottom panel for the snapshot. Fixes cockpit-project#21422
martinpitt
added a commit
that referenced
this issue
Dec 12, 2024
In the medium layout, the bottom panel sometimes has an extra white background line (padding). This is random and unpredictable (probably rounding noise?). That panel only contains a single standard button, so is not very interesting. We can't use `ignore=` for that, as the difference is the snapshot height, not the pixel contents. So instead, temporarily hide the whole bottom panel for the snapshot. Fixes #21422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The job
fedora-41/updates-testing
failed on commit 2d6af15.Log: https://cockpit-logs.us-east-1.linodeobjects.com/pull-0-2d6af150-20241211-013210-fedora-41-updates-testing/log.html
The text was updated successfully, but these errors were encountered: