From c71e15215f91df9e544ebdf8f907a9b656fd7b36 Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Fri, 20 Oct 2023 11:54:08 +0200 Subject: [PATCH] test: Fail on React DOM nesting errors Most errors were fixed recently. The remaining ones on the Storage page conflict with the ongoing page redesign, and may well already be fixed by it. Ignore them specifically for now. This will prevent introducing new DOM nesting errors in the future. --- test/common/testlib.py | 2 -- test/verify/check-storage-luks | 3 +++ test/verify/check-storage-lvm2 | 6 ++++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/test/common/testlib.py b/test/common/testlib.py index 8fb8dea58345..a98d6b5091af 100644 --- a/test/common/testlib.py +++ b/test/common/testlib.py @@ -1701,8 +1701,6 @@ def login_and_go(self, path: Optional[str] = None, user: Optional[str] = None, h # List of allowed console.error() messages during tests; these match substrings default_allowed_console_errors = [ - # HACK: Fix these ASAP, these are major bugs - "Warning: validateDOMNesting.*cannot appear as a", # HACK: These should be fixed, but debugging these is not trivial, and the impact is very low "Warning: .* setState.*on an unmounted component", "Warning: Can't perform a React state update on an unmounted component", diff --git a/test/verify/check-storage-luks b/test/verify/check-storage-luks index 594b09f6cd36..cceda5d43902 100755 --- a/test/verify/check-storage-luks +++ b/test/verify/check-storage-luks @@ -193,6 +193,9 @@ class TestStorageLuks(storagelib.StorageCase): b.logout() testlib.wait(lambda: m.execute("(loginctl list-users | grep admin) || true") == "") + # FIXME: race condition after unmounting; hard to investigate, re-check after storage redesign + self.allow_browser_errors("validateDOMNesting.*cannot appear as a child.* ul") + def testNoFsys(self): m = self.machine b = self.browser diff --git a/test/verify/check-storage-lvm2 b/test/verify/check-storage-lvm2 index f0d5cafa5cda..75da748797ac 100755 --- a/test/verify/check-storage-lvm2 +++ b/test/verify/check-storage-lvm2 @@ -251,6 +251,9 @@ class TestStorageLvm2(storagelib.StorageCase): b.wait_not_in_text("#devices", "vgroup1") self.assertEqual(m.execute(f"grep {mount_point_thin} /etc/fstab || true"), "") + # FIXME: Grow/Shrink buttons are in a dd > div > dd without dl wrapper + self.allow_browser_errors("validateDOMNesting.*cannot appear as a descendant.*
dd") + def testUnpartitionedSpace(self): m = self.machine b = self.browser @@ -334,6 +337,9 @@ class TestStorageLvm2(storagelib.StorageCase): self.content_row_wait_in_col(1, 1, "lvol0") b.wait_not_in_text("#storage-detail", "snap0") + # FIXME: Grow/Shrink buttons are in a dd > div > dd without dl wrapper + self.allow_browser_errors("validateDOMNesting.*cannot appear as a descendant.*
dd") + if __name__ == '__main__': testlib.test_main()