Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent downloadable behaviour #339

Open
fsuter opened this issue Aug 13, 2024 · 0 comments
Open

Inconsistent downloadable behaviour #339

fsuter opened this issue Aug 13, 2024 · 0 comments

Comments

@fsuter
Copy link
Contributor

fsuter commented Aug 13, 2024

The preview features allows for downloading the previewed data. But there's a confusion in the underlying code:

  • first of all, there are 2 ways to indicate that the data is downloadable. The consistency of this mechanism has to be reviewed. Ideally there should be a single operation needed to indicated downloadability.
  • the downloadable data is that stored in the records variable of the Data object, which may not be the same as the preview data. Again, consistency must be ensured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant