Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Replace hardcoded timeouts with variables #335

Closed
14 tasks
lixuna opened this issue Aug 5, 2020 · 5 comments
Closed
14 tasks

[Feature] Replace hardcoded timeouts with variables #335

lixuna opened this issue Aug 5, 2020 · 5 comments
Assignees
@kosstennbl
Labels
enhancement New feature or request

Comments

@lixuna
Copy link
Collaborator

lixuna commented Aug 5, 2020 •
edited
Loading

Problem:

  • some of the tests contain hardcoded timeouts, it would be nice to have constants that timeout vs putting the number in the code
  • ie. wait_count = 60

Possible solution:

  • Replace hardcoded timeouts with variables

List of tests to replace hardcoded timeouts

How will this be tested

  • Create a modified CNF that will exceed the time limits specified for the specific tests,
  • Run workload tests
  • I would expect the tests in question to fail if the wait_count is exceeded
  • I would expect the tests in question to pass if the test finishes before the wait_count limit
@lixuna lixuna added enhancement New feature or request good first issue Good for newcomers labels Aug 5, 2020
@taylor
Copy link
Collaborator

taylor commented Aug 5, 2020

@williscool please link to an example of a hardcoded timeout

@williscool
Copy link
Collaborator

boom

https://github.com/cncf/cnf-conformance/blob/17f4bd9abed012fced408fe512ece5e0364b064f/src/tasks/resilience.cr#L186

@williscool williscool pinned this issue Aug 6, 2020
@taylor
Copy link
Collaborator

taylor commented Aug 6, 2020

and https://github.com/cncf/cnf-conformance/blob/17f4bd9abed012fced408fe512ece5e0364b064f/src/tasks/resilience.cr#L224

@lixuna lixuna removed the good first issue Good for newcomers label May 5, 2021
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Jan 31, 2024
@kosstennbl
WIP: cnti-testcatalog#335: Change timeouts to constant variables
54bbb52 
Use constants with meaningfull names for defining timeouts
for different tasks and waiters. Where possible - unify
multiple values under one variable.

Signed-off-by: Konstantin Yarovoy <[email protected]>
@lixuna
Copy link
Collaborator Author

lixuna commented May 7, 2024

Hello, @kosstennbl is this issue in progress?

kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue on Jan 31
@kosstennbl
WIP: https://github.com/cnti-testcatalog/testsuite/issues/335[: Change timeouts to constant variables](kosstennbl@54bbb52) …
54bbb52
Use constants with meaningfull names for defining timeouts
for different tasks and waiters. Where possible - unify
multiple values under one variable.

Signed-off-by: Konstantin Yarovoy [email protected]

@kosstennbl
Copy link
Collaborator

@lixuna
Hi, yes, I've left it behind for several months, but this week I've started again and It will probably be ready for review by Friday-Monday

kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue May 13, 2024
@kosstennbl
timeouts: Redesign and unify timeouts
9fae2be 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: cnti-testcatalog#335
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue May 13, 2024
Merged
1 task
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue May 16, 2024
@kosstennbl
timeouts: Redesign and unify timeouts
75c4060 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: cnti-testcatalog#335
Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue May 21, 2024
@kosstennbl
timeouts: Redesign and unify timeouts
7ca7293 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: cnti-testcatalog#335
Signed-off-by: Konstantin Yarovoy <[email protected]>
martin-mat pushed a commit that referenced this issue Jun 7, 2024
@kosstennbl @martin-mat
timeouts: Redesign and unify timeouts
8859111 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: #335
Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Jun 17, 2024
@kosstennbl
timeouts: Redesign and unify timeouts
4f422bd 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: cnti-testcatalog#335
Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Jun 17, 2024
@kosstennbl
timeouts: Redesign and unify timeouts
c1c8c7b 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: cnti-testcatalog#335
Signed-off-by: Konstantin Yarovoy <[email protected]>
martin-mat pushed a commit that referenced this issue Jun 19, 2024
@kosstennbl @martin-mat
timeouts: Redesign and unify timeouts
f3cbb5b 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: #335
Signed-off-by: Konstantin Yarovoy <[email protected]>
martin-mat pushed a commit that referenced this issue Jun 19, 2024
@kosstennbl
timeouts: Redesign and unify timeouts (#2023)
ba9fcda 
Add common function to run a code block with a timeout.
Add several global timeouts for different tasks, which can be
configured via environment variables.
Several small fixes and refactoring.

ref: #335

Signed-off-by: Konstantin Yarovoy <[email protected]>
@github-project-automation github-project-automation bot moved this to In progress in CNF Test Suite Aug 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in CNF Test Suite Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kosstennbl kosstennbl

Labels
enhancement New feature or request
Projects
CNF Test Suite
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@taylor @williscool @lixuna @kosstennbl