Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage fails when no static qrc is selected. Is that still a useful option? #194

Closed
emmenlau opened this issue Jan 31, 2023 · 3 comments
Closed

Comments

@emmenlau
Copy link
Contributor

emmenlau commented Jan 31, 2023

With current QuickQanava 2.2.0 we get the same error as #92, when we set cmake option -DQUICK_QANAVA_BUILD_STATIC_QRC=FALSE.

I tried to follow this up, and find a valid way to get QuickQanava working with this option turned off, but I failed. From what I could see, Qt does not initialize the QuickQanava resources correctly when the static qrc is set to false. I think this may be because the actual C++ library libQuickQanava.a is always set to STATIC, and in turn the qrc should maybe also be static, is that possible?

Basically my question is this: Is it even sensible to have option -DQUICK_QANAVA_BUILD_STATIC_QRC=FALSE when the library is built as static, which is currently enforced in cmake? Because for me this does not work. With -DQUICK_QANAVA_BUILD_STATIC_QRC=TRUE on the other hand, everything works just fine!

Does that mean that option QUICK_QANAVA_BUILD_STATIC_QRC is just deprecated and should be removed? Or am I just unable to use it wisely?

@emmenlau
Copy link
Contributor Author

Hey, anyone?

cneben added a commit that referenced this issue Nov 16, 2023
Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Nov 17, 2023
Signed-off-by: cneben <[email protected]>
@cneben
Copy link
Owner

cneben commented Jan 8, 2024

Sorry for the "long" delay ! Option removed, there is still a qrc until I go with full CMake resources management (next pure Qt6 version 2.5.0 imminent, full CMake configuration not until 2.6.0). Closing.

@cneben cneben closed this as completed Jan 8, 2024
@emmenlau
Copy link
Contributor Author

emmenlau commented Jan 8, 2024

Thanks @cneben , sounds very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants