Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoupling locate_binary_node and get_executable_type from ROSLaunchReader #445

Open
afsafzal opened this issue Jan 19, 2021 · 0 comments
Open

Decoupling locate_binary_node and get_executable_type from ROSLaunchReader #445

afsafzal opened this issue Jan 19, 2021 · 0 comments
Labels
enhancement New feature or request refactoring

Comments

@afsafzal
Copy link
Collaborator

We should be able to call locate_binary_node and get_executable_type without going through ROSLaunchReader as their operation is only dependent on accessing shell and files and is not particularly relevant to the launch reader.
@afsafzal afsafzal added enhancement New feature or request refactoring labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afsafzal