Correlator Layer 1 pattern file producer updates for multi-board tests #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR changes the pattern file produces used to prepare inputs for single and multiboard tests for the correlator layer 1, updating the cabling map to what is used at B904 and supporting production of TM18 pattern files also in the barrel.
It doesn't change anything in the physics performance and so it's not needed for menu studies or similar, but it's useful to have it integrated so that other subsystems can have the latest configuration when synchronizing pattern files for multi-board tests.
PR validation:
When still based on
phase2-l1t-1400pre3_v5this branch was validated and used for single and multi-board tests with layer2 and X2O.No changes are expected from the rebase to
phase2-l1t-1400pre3_v9but I'm testing it to be sure.CMSSW master PR will be also opened today