Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntuplemaker fixes #1253

Open
wants to merge 5 commits into
base: phase2-l1t-integration-14_0_0_pre3
Choose a base branch
from

Conversation

cgsavard
Copy link

@cgsavard cgsavard commented May 2, 2024

PR description:

This PR will fix a couple of bugs to the ntuplemaker:

  1. The vertex variables are not being cleared when SaveTrackJets is false because the clearing is in the wrong place. This is fixed by moving it outside of the boolean.
  2. The vertexing algorithm name when not running the NN does not reference anything so it's default to the fasthisto algo. Theoretically it should be fasthisto so the hard coded name in the config was removed as fasthisto is already default.
  3. The current default file is not available. It has been replaced with a TT file that is accessible.
  4. The HYBRID method needs a process.pL1TrackTripletEmulator to run so it has now been set.

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 3 files that did not meet formatting requirements:

  • L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
  • L1Trigger/Phase2L1GMT/interface/TPSLUTs.h
  • L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b runtests

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!

Info Value
return code 1
command eval scramv1 runtime -sh && runTheMatrix.py --what upgrade -l 26834.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants