Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submissions_status RPC when UNION ALL doesn't keep the order #1201

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix submissions_status RPC when UNION ALL doesn't keep the order #1201

merged 2 commits into from
Nov 6, 2024

Commits on Nov 6, 2024

  1. Fix submissions_status RPC when UNION ALL doesn't keep the order 

    UNION ALL is not guaranteed to keep the order of the results. In fact
with (at least) Postgres 13 the order is not well defined and can change
between executions.

This patch adds an extra column to the query, tagging each statistics
with its key, so that we can reconstruct the correct order of the
results.
    @edomora97 @wil93
    edomora97 authored and wil93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    32573c0 View commit details
    Browse the repository at this point in the history

  2. Fixup

    @wil93
    wil93 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    07623ea View commit details
    Browse the repository at this point in the history