Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding displaced vertexing GBDT #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ryanm124
Copy link

Displaced vertexing GBDT model currently under review: cms-l1t-offline/cmssw#1257. Last presented at L1T weekly meeting on May 21st here: https://indico.cern.ch/event/1419033/contributions/5965267/attachments/2860272/5004897/Displaced%20Vertexing%20DP%20Note%20v4.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ryanm124 for branch main.

@smuzaffar, @subirsarkar, @epalencia, @iarspider, @srimanob, @cmsbuild, @aloeliger, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

cms-bot internal usage

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41ba61/39473/summary.html
COMMIT: ca86caf
CMSSW: CMSSW_14_1_X_2024-05-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1TTrackMatch/2/39473/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_TkHistoMap had ERRORS

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 9033 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 34525
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3304314
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.046 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

Pull request #2 was updated.

@smuzaffar
Copy link

@ryanm124 , is there any cmssw PR to test this new data file?

@ryanm124
Copy link
Author

@ryanm124 , is there any cmssw PR to test this new data file?

The only PR currently that uses this file is the #1257 to cms-l1t-offline (cms-l1t-offline/cmssw#1257) which I linked in the PR description above

@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants