-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #9
Comments
Better to depend on Can also just create TH1s on the fly with |
Thanks for the pointer, but I'm not sure, it adds a dependency that might make it more difficult for people to contribute. Would surely need "contributing" docs. |
I'm happy to help with image comparison tests in CI also. I've set them up for |
Hello, I was thinking on working on this for the GitHub version of cmsstyle, but mostly focusing on checking the validity of the code (and mostlyfor me to be sure I did not miss anything while checking before requiring a PR). e.g. to check it actually compiles on the python versions we support. |
Great! I think the first step would be to have a small file as listed at #9 (comment) to just run the plot scripts and store them as artifacts. |
I think you overestimate my capabilities... I am going to start checking the code I push compile in python and in C++... but yes, next step is about the plot scripts :) Thanks! |
The text was updated successfully, but these errors were encountered: