Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #9

Open
3 tasks
clelange opened this issue Sep 26, 2023 · 6 comments
Open
3 tasks

Add CI #9

clelange opened this issue Sep 26, 2023 · 6 comments

Comments

@clelange
Copy link
Member

  • Add small ROOT file with histograms that can be used for plotting
  • Create script to use this ROOT file to create plots from
  • Use this script in CI (GitLab CI or GitHub Actions or both)
@andrzejnovak
Copy link
Contributor

andrzejnovak commented Sep 26, 2023

Better to depend on skhep_data for test instead of a committed ROOT file eghttps://github.com/scikit-hep/mplhep/blob/master/tests/test_inputs.py#L41

Can also just create TH1s on the fly with uproot ROOT :).

@clelange
Copy link
Member Author

Thanks for the pointer, but I'm not sure, it adds a dependency that might make it more difficult for people to contribute. Would surely need "contributing" docs.

@andrzejnovak
Copy link
Contributor

I'm happy to help with image comparison tests in CI also. I've set them up for mplhep, but perhaps we set these up after we settle all the style tweaks.

@oglez
Copy link
Contributor

oglez commented Nov 29, 2024

Hello, I was thinking on working on this for the GitHub version of cmsstyle, but mostly focusing on checking the validity of the code (and mostlyfor me to be sure I did not miss anything while checking before requiring a PR). e.g. to check it actually compiles on the python versions we support.
My plan is to start running these basic checks and the expand. I'll run the thing for sure on "push" as it is what I need :) but glad to start looking into what can be done and when to run the workflows (also when opening a PR? Any other?). Glad to get your input on this!

@clelange
Copy link
Member Author

Great! I think the first step would be to have a small file as listed at #9 (comment) to just run the plot scripts and store them as artifacts.

@oglez
Copy link
Contributor

oglez commented Nov 29, 2024

I think you overestimate my capabilities... I am going to start checking the code I push compile in python and in C++... but yes, next step is about the plot scripts :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants