From e6554577288d7d6f4f6c7be69ea523e5ac000653 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Mon, 4 Nov 2024 22:23:33 -0500 Subject: [PATCH 01/14] Unify the VMStubMEMemoryCM and VMStubTEOuterMemoryCM in common VMStubMemory class --- TestBenches/MatchProcessor_test.cpp | 4 +- TestBenches/TrackletProcessor_test.cpp | 4 +- TestBenches/VMRouterCM_test.cpp | 6 +- TestBenches/VMStubMERouter_test.cpp | 4 +- TrackletAlgorithm/MatchEngineUnit.h | 18 +- TrackletAlgorithm/MatchProcessor.h | 24 +-- .../TrackletCalculator_calculate_LXD1.h | 155 ---------------- TrackletAlgorithm/TrackletEngineUnit.h | 8 +- TrackletAlgorithm/TrackletProcessor.h | 12 +- TrackletAlgorithm/VMRouterCM.h | 19 +- TrackletAlgorithm/VMSMERouter.h | 12 +- TrackletAlgorithm/VMStubMEMemoryCM.h | 165 ------------------ TrackletAlgorithm/VMStubMemory.h | 165 ++++++++++++++++++ TrackletAlgorithm/VMStubTEOuterMemoryCM.h | 157 ----------------- emData/generate_MP.py | 4 +- emData/generate_TP.py | 4 +- emData/generate_VMRCM.py | 8 +- emData/generate_VMSMER.py | 4 +- 18 files changed, 230 insertions(+), 543 deletions(-) delete mode 100644 TrackletAlgorithm/TrackletCalculator_calculate_LXD1.h delete mode 100644 TrackletAlgorithm/VMStubMEMemoryCM.h create mode 100644 TrackletAlgorithm/VMStubMemory.h delete mode 100644 TrackletAlgorithm/VMStubTEOuterMemoryCM.h diff --git a/TestBenches/MatchProcessor_test.cpp b/TestBenches/MatchProcessor_test.cpp index 36cf962ee8f..68c4be476fd 100644 --- a/TestBenches/MatchProcessor_test.cpp +++ b/TestBenches/MatchProcessor_test.cpp @@ -48,7 +48,7 @@ int main() const auto nAllStub = tb.nFiles(allStubPatternarray); vector> allstub(nAllStub); const auto nVMStubs = tb.nFiles(vmStubPatternarray); - VMStubMEMemoryCM vmstub; // barrel + VMStubMemory vmstub; // barrel // output memories const auto nFullMatches = tb.nFiles(fullMatchPattern); @@ -79,7 +79,7 @@ int main() for (unsigned int i = 0; i < nAllStub; i++) writeMemFromFile>(allstub[i], fin_AllStub.at(i), ievt); auto &fin_VMStubs = tb.files(vmStubPatternarray); - writeMemFromFile>(vmstub, fin_VMStubs.at(0), ievt); // barrel + writeMemFromFile>(vmstub, fin_VMStubs.at(0), ievt); // barrel // clear allarray, output memories before starting for (unsigned int i = 0; i < nFullMatches; i++) diff --git a/TestBenches/TrackletProcessor_test.cpp b/TestBenches/TrackletProcessor_test.cpp index 9908846b33b..4eedc7fd43f 100644 --- a/TestBenches/TrackletProcessor_test.cpp +++ b/TestBenches/TrackletProcessor_test.cpp @@ -109,7 +109,7 @@ std::cout< > innerStubs(nInnerStubMems); vector > outerStubs(nOuterStubMems); - vector > outervmStubs(nOuterVMStubMems); + vector > outervmStubs(nOuterVMStubMems); // output memories TrackletParameterMemory tpar; @@ -145,7 +145,7 @@ std::cout< >(outerStubs[i], fin_outerStubs.at(i), ievt); for (unsigned i = 0; i < nOuterVMStubMems; i++) - writeMemFromFile>(outervmStubs[i], fin_outervmStubs.at(i), ievt); + writeMemFromFile>(outervmStubs[i], fin_outervmStubs.at(i), ievt); // clear all output memories before starting tpar.clear(); diff --git a/TestBenches/VMRouterCM_test.cpp b/TestBenches/VMRouterCM_test.cpp index 11d27f0a676..2e8f75670fc 100644 --- a/TestBenches/VMRouterCM_test.cpp +++ b/TestBenches/VMRouterCM_test.cpp @@ -73,8 +73,8 @@ int main() { // Output memories static AllStubMemory memoriesAS[numASCopies]; static AllStubInnerMemory memoriesASInner[numASInnerCopies]; - static VMStubMEMemoryCM memoryME; - static VMStubTEOuterMemoryCM memoriesTEO[numTEOCopies]; + static VMStubMemory memoryME; + static VMStubMemory memoriesTEO[numTEOCopies]; /////////////////////////// @@ -147,7 +147,7 @@ int main() { //TE Outer memories if (nVMSTE) { for (unsigned int i = 0; i < nVMSTE; i++) { - err += compareBinnedMemCMWithFile>(memoriesTEO[i], fout_vmstubte[i], ievt, "VMStubTEOuter", truncation); + err += compareBinnedMemCMWithFile>(memoriesTEO[i], fout_vmstubte[i], ievt, "VMStubTEOuter", truncation); } } } // End of event loop diff --git a/TestBenches/VMStubMERouter_test.cpp b/TestBenches/VMStubMERouter_test.cpp index ef3f502e09b..4a3b3699ebc 100644 --- a/TestBenches/VMStubMERouter_test.cpp +++ b/TestBenches/VMStubMERouter_test.cpp @@ -52,7 +52,7 @@ int main() { static AllStubMemory memoriesAS; // Output memories - static VMStubMEMemoryCM memoryME; + static VMStubMemory memoryME; static AllStubMemory memoriesASCopy; /////////////////////////// @@ -94,7 +94,7 @@ int main() { // ME memories std::cout << "comparing memories for layer/disk: " << dec << kLAYER << "/" << kDISK << " and region: " << phiRegion << std::endl; - err += compareBinnedMemCMWithFile>(memoryME, fout_vmstubme[0], ievt, "VMStubME", truncation); + err += compareBinnedMemCMWithFile>(memoryME, fout_vmstubme[0], ievt, "VMStubME", truncation); } // End of event loop diff --git a/TrackletAlgorithm/MatchEngineUnit.h b/TrackletAlgorithm/MatchEngineUnit.h index 136e9dd570b..c50b9118a45 100644 --- a/TrackletAlgorithm/MatchEngineUnit.h +++ b/TrackletAlgorithm/MatchEngineUnit.h @@ -3,7 +3,7 @@ #include "Constants.h" #include "TrackletProjectionMemory.h" -#include "VMStubMEMemoryCM.h" +#include "VMStubMemory.h" #include "VMProjectionMemory.h" #include "ProjectionRouterBuffer.h" #include "AllStubMemory.h" @@ -33,11 +33,11 @@ class MatchEngineUnitBase { }; }; -template +template class MatchEngineUnit : public MatchEngineUnitBase { public: - typedef ap_uint::kVMSMEIDSize> MATCH; + typedef ap_uint::kVMSIDSize> MATCH; typedef ap_uint NSTUB; typedef ap_uint NSTUBS; typedef ap_uint::kNBitsBuffer> INDEX; @@ -104,7 +104,7 @@ class MatchEngineUnit : public MatchEngineUnitBase { -inline void step(const VMStubMECM stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin+4)]) { +inline void step(const VMStub stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin+4)]) { #pragma HLS inline #pragma HLS array_partition variable=nstubsall_ complete dim=1 @@ -119,7 +119,7 @@ inline void step(const VMStubMECM stubmem[4][1<<(kNbitsrzbinMP+kNbits NSTUB istubtmp=istub_; ap_uint<2> iusetmp=iuse_; - ap_uint::kVMSMEFinePhiSize> iphiSave = iphi_ + use_[iusetmp].range(0,0); + ap_uint::kVMSFinePhiSize> iphiSave = iphi_ + use_[iusetmp].range(0,0); auto secondSave = second_; VMProjection data(projbuffer_.getProjection()); @@ -381,10 +381,10 @@ inline void advance() { ap_uint<1> phiPlus_; typename ProjectionRouterBuffer::PHIPROJBIN phiProjBin_; bool idle_; - ap_uint::kVMSMEFinePhiSize> iphi_; + ap_uint::kVMSFinePhiSize> iphi_; BXType bx_; bool empty_; - VMStubMECM stubdata__, stubdata___; + VMStub stubdata__, stubdata___; typename ProjectionRouterBuffer::TCID tcid_; ProjectionRouterBuffer projbuffer_; ap_uint projseq_; @@ -419,8 +419,8 @@ inline void advance() { static constexpr int projfinephibits = VMProjectionBase::kVMProjFinePhiWideSize; static constexpr int projfinezbits = VMProjectionBase::kVMProjFineZSize; - static constexpr int stubfinephibits = VMStubMECMBase::kVMSMEFinePhiSize; - static constexpr int stubfinezbits = VMStubMECMBase::kVMSMEFineZSize; + static constexpr int stubfinephibits = VMStubBase::kVMSFinePhiSize; + static constexpr int stubfinezbits = VMStubBase::kVMSFineZSize; #ifndef __SYNTHESIS__ diff --git a/TrackletAlgorithm/MatchProcessor.h b/TrackletAlgorithm/MatchProcessor.h index cf4780b4d20..7f27ebf90d1 100644 --- a/TrackletAlgorithm/MatchProcessor.h +++ b/TrackletAlgorithm/MatchProcessor.h @@ -3,7 +3,7 @@ #include "Constants.h" #include "TrackletProjectionMemory.h" -#include "VMStubMEMemoryCM.h" +#include "VMStubMemory.h" #include "VMProjectionMemory.h" #include "ProjectionRouterBuffer.h" #include "ProjectionRouterBufferArray.h" @@ -901,7 +901,7 @@ template constexpr uint32_t NPageSum(); #include "MatchProcessor_parameters.h" -template +template void MatchCalculator(BXType bx, ap_uint<1> newtracklet, ap_uint<1>& isMatch, @@ -912,7 +912,7 @@ void MatchCalculator(BXType bx, ap_uint& best_delta_r, const AllStubMemory* allstub, const AllProjection& proj, - ap_uint::kVMSMEIDSize> stubid, + ap_uint::kVMSIDSize> stubid, FullMatchMemory fullmatch[maxFullMatchVariants] ){ @@ -1180,14 +1180,14 @@ constexpr unsigned kNbitsrzbinMPDisk = kNbitsrzbin + 1; ////////////////////////////// // MatchProcessor -template void MatchProcessor(BXType bx, // because Vivado HLS cannot synthesize an array of // pointers that point to stuff other than scalar or // array of scalar ... const TrackletProjectionMemory projin[nINMEM], - const VMStubMEMemoryCM& instubdata, + const VMStubMemory& instubdata, const AllStubMemory* allstub, BXType& bx_o, FullMatchMemory fullmatch[maxFullMatchVariants] @@ -1271,7 +1271,7 @@ void MatchProcessor(BXType bx, constexpr int nPRBAbits = 3; ProjectionRouterBufferArray projbufferarray; - MatchEngineUnit matchengine[kNMatchEngines]; + MatchEngineUnit matchengine[kNMatchEngines]; #pragma HLS ARRAY_PARTITION variable=matchengine complete #pragma HLS ARRAY_PARTITION variable=projin dim=1 @@ -1294,7 +1294,7 @@ void MatchProcessor(BXType bx, ap_uint<1> newtracklet_save; ap_uint<1> isMatch_save; AllProjection allproj_save; - ap_uint::kVMSMEIDSize> stubindex_save; + ap_uint::kVMSIDSize> stubindex_save; TrackletProjection projdata, projdata_; bool validin = false; @@ -1333,7 +1333,7 @@ void MatchProcessor(BXType bx, ap_uint::kAllProjectionSize> projBuffer[1< istep = 0; istep < kMaxProc - kMaxProcOffset(module::MP); istep++) { @@ -1358,7 +1358,7 @@ void MatchProcessor(BXType bx, ap_uint idles; ap_uint emptys; - typename MatchEngineUnit::MATCH matches[kNMatchEngines]; + typename MatchEngineUnit::MATCH matches[kNMatchEngines]; #pragma HLS ARRAY_PARTITION variable=matches complete ap_uint projseqs[kNMatchEngines]; #pragma HLS ARRAY_PARTITION variable=projseqs complete @@ -1458,7 +1458,7 @@ void MatchProcessor(BXType bx, if (hasMatch_save) { isMatch = newtracklet_save ? ap_uint<1>(0) : isMatch; - MatchCalculator + MatchCalculator (bx, newtracklet_save, isMatch, savedMatch, best_delta_z, best_delta_phi, best_delta_rphi, best_delta_r, allstub, allproj_save, stubindex_save, fullmatch); } @@ -1468,7 +1468,7 @@ void MatchProcessor(BXType bx, if(hasMatch) { - ap_uint::kVMSMEIDSize> stubindex; + ap_uint::kVMSIDSize> stubindex; stubindex = matches[bestiMEU]; @@ -1507,7 +1507,7 @@ void MatchProcessor(BXType bx, // vmproj z // Separate the vm projections into zbins - // To determine which zbin in VMStubsME the ME should look in to match this VMProjection, + // To determine which zbin in VMStubs the ME should look in to match this VMProjection, // the purpose of these lines is to take the top MEBinsBits (3) bits of zproj and shift it // to make it positive, which gives the bin index. But there is a range of possible z values // over which we want to look for matched stubs, and there is therefore possibly 2 bins that diff --git a/TrackletAlgorithm/TrackletCalculator_calculate_LXD1.h b/TrackletAlgorithm/TrackletCalculator_calculate_LXD1.h deleted file mode 100644 index 9986d79fe82..00000000000 --- a/TrackletAlgorithm/TrackletCalculator_calculate_LXD1.h +++ /dev/null @@ -1,155 +0,0 @@ -// -#include "ap_int.h" -#include "Constants.h" -#include "TrackletProjectionCalculator.h" -#include "TrackletLUTs.h" - -template -void TC::calculate_LXD1 ( - const typename AllStub::ASR r1_input, - const typename AllStub::ASPHI phi1_input, - const typename AllStub::ASZ z1_input, - const typename AllStub::ASR r2_input, - const typename AllStub::ASPHI phi2_input, - const typename AllStub::ASZ z2_input, - - bool * const valid_radii, - TC::Types::rinv * const rinv_output, - TrackletParameters::PHI0PAR * const phi0_output, - TrackletParameters::TPAR * const t_output, - TC::Types::z0 * const z0_output, - TC::Types::phiL * const phiL_0_output, - TC::Types::phiL * const phiL_1_output, - TC::Types::phiL * const phiL_2_output, - TC::Types::zL * const zL_0_output, - TC::Types::zL * const zL_1_output, - TC::Types::zL * const zL_2_output, - TC::Types::der_phiL * const der_phiL_output, - TC::Types::der_zL * const der_zL_output, - TC::Types::phiD * const phiD_0_output, - TC::Types::phiD * const phiD_1_output, - TC::Types::phiD * const phiD_2_output, - TC::Types::phiD * const phiD_3_output, - TC::Types::rD * const rD_0_output, - TC::Types::rD * const rD_1_output, - TC::Types::rD * const rD_2_output, - TC::Types::rD * const rD_3_output, - TC::Types::der_phiD * const der_phiD_output, - TC::Types::der_rD * const der_rD_output) -{ -#pragma HLS pipeline II=1 -#pragma HLS latency max=25 - - //First convert input to right bits - ap_uint<12> ir1c = (ap_int<10>(r1_input) << 1) + rmean[seedLayers[Seed][0]]; - ap_uint<12> ir2c = r2_input; - - const ap_int<18> phi1c = ap_int<18>(phi1_input)<<3; - const ap_int<18> phi2c = ap_int<18>(phi2_input)<<3; - - const TC::Types::zmean z2mean = zmean[seedLayers[Seed][1]]; - - const ap_int<14> z1c = z1_input; - const ap_int<14> z2c = ap_int<7>(z2_input) + (z1c > 0 ? ap_int<14>(z2mean) : ap_int<14>(-z2mean)); - - ap_int<12> idz = z2c - z1c; - - ap_uint<12> idr = (ap_int<12>(ir2c - ir1c)); - - static const InvdrLUT lut_idrinv; - ap_uint<18> invdr = lut_idrinv.lookup(idr); - - *valid_radii = idr > floatToInt(((Seed == TF::L1D1)?1.5:2.0),kr); - //FIXME this 1.5 and 2.0 is a magic number - - ap_int<18> idelta0 = ((phi2c - phi1c)*invdr) >> n_delta0_Overlap_; - ap_int<18> ideltaz = (idz*invdr) >> n_deltaz_Overlap_; - - ap_int<20> idelta1 = (ir1c*idelta0) >> n_delta1_; - ap_int<20> idelta2 = (ir2c*idelta0) >> n_delta2_; - - ap_int<20> idelta12 = (idelta1*idelta2) >> n_delta12_; - - constexpr int iHG = phiHG_*phiHG_*(1 << n_HG_); - - ap_uint ia = ((1 << n_a_Overlap_) - ((idelta12*iHG) >> (2*n_Deltar_Overlap_ + 2*n_phi_ + n_HG_ - 2*n_delta0_Overlap_ - n_delta1_ - n_delta2_ - n_delta12_ + 1 - n_a_Overlap_))); - - constexpr int ir6fact = (1< ir6 = (ir1c+ir2c)*ir6fact; - - ap_int<18> idelta02 = (idelta0*idelta2) >> n_delta02_; - - ap_int ix6 = (-(1 << n_x6_)+((ir6*idelta02) >> (n_r6_Overlap_ + 2*n_Deltar_Overlap_ + 2*n_phi_ - n_x6_ - n_delta2_- n_delta02_ - 2*n_delta0_Overlap_))); - - ap_int<18> it1 = (ir1c*ideltaz) >> (n_Deltar_Overlap_ - n_deltaz_Overlap_); - - - ap_int<15> irinv_new = ((-idelta0*ia) >> (n_phi_ + n_a_Overlap_ - n_rinv_ + n_Deltar_Overlap_ - n_delta0_Overlap_ - n_r_ - 1)); - - ap_int<18> iphi0_new = (phi1c >> (n_phi_ - n_phi0_))+((idelta1*ix6) >> (n_Deltar_Overlap_ + n_x6_ + n_phi_ - n_delta0_Overlap_ - n_delta1_ - n_phi0_)); - - ap_int<14> it_new = ((ideltaz*ia) >> (n_Deltar_Overlap_ + n_a_Overlap_ + n_z_ - n_t_ - n_deltaz_Overlap_ - n_r_)); - - ap_int<11> iz0_new = z1c + ((it1*ix6) >> n_x6_); - - constexpr int irproj0 = rmean[projectionLayers[Seed][0]]; - constexpr int irproj1 = rmean[projectionLayers[Seed][1]]; - constexpr int irproj2 = rmean[projectionLayers[Seed][2]]; - - constexpr int irprojtilde0 = irproj0*phiHG_/sqrtsix + 0.5; - constexpr int irprojtilde1 = irproj1*phiHG_/sqrtsix + 0.5; - constexpr int irprojtilde2 = irproj2*phiHG_/sqrtsix + 0.5; - - const ap_int<13> rproj0 = irproj0; - const ap_int<13> rproj1 = irproj1; - const ap_int<13> rproj2 = irproj2; - - const ap_int<13> rprojtilde0 = irprojtilde0; - const ap_int<13> rprojtilde1 = irprojtilde1; - const ap_int<13> rprojtilde2 = irprojtilde2; - - projToLayer(rproj0, rprojtilde0, irinv_new, iphi0_new, it_new, iz0_new, *zL_0_output, *phiL_0_output); - projToLayer(rproj1, rprojtilde1, irinv_new, iphi0_new, it_new, iz0_new, *zL_1_output, *phiL_1_output); - projToLayer(rproj2, rprojtilde2, irinv_new, iphi0_new, it_new, iz0_new, *zL_2_output, *phiL_2_output); - - *der_phiL_output = -(irinv_new >> (1+3)); - *der_zL_output = it_new >> 3; - - static const InvtLUT lut_itinv; - - ap_uint<20> itinv = lut_itinv.lookup(abs(it_new)&4095); - - constexpr int izproj0 = zmean[projectionDisks[Seed][0]]; - constexpr int izproj1 = zmean[projectionDisks[Seed][1]]; - constexpr int izproj2 = zmean[projectionDisks[Seed][2]]; - constexpr int izproj3 = zmean[projectionDisks[Seed][3]]; - - const ap_int<14> zproj0 = izproj0; - const ap_int<14> zproj1 = izproj1; - const ap_int<14> zproj2 = izproj2; - const ap_int<14> zproj3 = izproj3; - - projToDisk(zproj0, itinv, irinv_new, iphi0_new, it_new, iz0_new, *rD_0_output, *phiD_0_output); - projToDisk(zproj1, itinv, irinv_new, iphi0_new, it_new, iz0_new, *rD_1_output, *phiD_1_output); - projToDisk(zproj2, itinv, irinv_new, iphi0_new, it_new, iz0_new, *rD_2_output, *phiD_2_output); - projToDisk(zproj3, itinv, irinv_new, iphi0_new, it_new, iz0_new, *rD_3_output, *phiD_3_output); - - *der_phiD_output = (-irinv_new*itinv) >> 17; - *der_rD_output = itinv >> 5; - - if (it_new < 0 ) { - *der_phiD_output = - *der_phiD_output; - *der_rD_output = - *der_rD_output; - } - - // - // wiring the outputs - // - *rinv_output = irinv_new; - *phi0_output = iphi0_new; - *t_output = it_new; - *z0_output = iz0_new; - - - -} diff --git a/TrackletAlgorithm/TrackletEngineUnit.h b/TrackletAlgorithm/TrackletEngineUnit.h index be8693309b7..b3f8aa38f5e 100644 --- a/TrackletAlgorithm/TrackletEngineUnit.h +++ b/TrackletAlgorithm/TrackletEngineUnit.h @@ -2,11 +2,11 @@ #define TRACKLETENGINEUNIT_H #include "Constants.h" -#include "VMStubTEOuterMemoryCM.h" +#include "VMStubMemory.h" #include "TrackletProcessor_parameters.h" #include "TrackletParameterMemory.h" -template +template class TrackletEngineUnit { public: @@ -20,7 +20,7 @@ class TrackletEngineUnit { kNBitsPTLutOuter=(Seed==TF::L5L6||Seed==TF::L1D1||Seed==TF::L2D1||Seed==TF::D1D2||Seed==TF::D3D4)?1024:(Seed==TF::L1L2||Seed==TF::L2L3)?256:512 }; - typedef ap_uint::kVMSTEOIDSize+AllStub::kAllStubSize+TrackletParameters::kTParPhiRegionSize+kNBits_MemAddr> STUBID; + typedef ap_uint::kVMSIDSize+AllStub::kAllStubSize+TrackletParameters::kTParPhiRegionSize+kNBits_MemAddr> STUBID; typedef ap_uint NEGDISK; typedef ap_uint NSTUBS; typedef ap_uint INDEX; @@ -178,7 +178,7 @@ void write(STUBID stubs) { ap_uint<1> next__, next___; PHIBIN ireg__, ireg___; - VMStubTEOuter outervmstub__, outervmstub___; + VMStub outervmstub__, outervmstub___; NSTUBS ns[16]; diff --git a/TrackletAlgorithm/TrackletProcessor.h b/TrackletAlgorithm/TrackletProcessor.h index 120a99f2174..9d3e244ac19 100644 --- a/TrackletAlgorithm/TrackletProcessor.h +++ b/TrackletAlgorithm/TrackletProcessor.h @@ -8,7 +8,7 @@ #include "AllStubInnerMemory.h" #include "TrackletParameterMemory.h" #include "TrackletProjectionMemory.h" -#include "VMStubTEOuterMemoryCM.h" +#include "VMStubMemory.h" #include "TEBuffer.h" #include "TrackletEngineUnit.h" #include "TrackletProcessor_parameters.h" @@ -688,7 +688,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) uint16_t N // maximum number of steps > void TrackletProcessor( - const BXType bx, BXType& bx_o, const LUTTYPE lut[lutsize], const AllStubInnerMemory()> innerStubs[NASMemInner], const AllStubMemory()>* outerStubs, const VMStubTEOuterMemoryCM(),kNbitsrzbin,kNbitsphibin,NVMSTECopy>* outerVMStubs, TrackletParameterMemory * const trackletParameters, TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS], TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S], TrackletProjectionMemory projout_disk[TP::N_PROJOUT_DISK] + const BXType bx, BXType& bx_o, const LUTTYPE lut[lutsize], const AllStubInnerMemory()> innerStubs[NASMemInner], const AllStubMemory()>* outerStubs, const VMStubMemory(),kNbitsrzbin,kNbitsphibin,NVMSTECopy>* outerVMStubs, TrackletParameterMemory * const trackletParameters, TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS], TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S], TrackletProjectionMemory projout_disk[TP::N_PROJOUT_DISK] ) { constexpr bool diskSeed = (Seed == TF::D1D2 || Seed == TF::D3D4); @@ -728,7 +728,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) const ap_uint<1>* stubptinnertmp = TP::getPTInnerLUT(); static const TPRegionLUT regionLUT(stubptinnertmp, iAllstub); - constexpr unsigned int NfinephiBits=NBitsPhiRegion+TrackletEngineUnit()>::kNBitsPhiBins+VMStubTEOuterBase()>::kVMSTEOFinePhiSize; + constexpr unsigned int NfinephiBits=NBitsPhiRegion+TrackletEngineUnit()>::kNBitsPhiBins+VMStubBase()>::kVMSFinePhiSize; static TEBuffer()> tebuffer; static_assert(TP::nASMemInner() <= 3, "Only handling up to three inner AS memories"); @@ -801,7 +801,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) teureadindex[k] = 0; } //quantities looked up in LUT - typename VMStubTEOuter()>::VMSTEOFINEZ rzfinebinfirst,rzdiffmax; + typename VMStub()>::VMSFINEZ rzfinebinfirst,rzdiffmax; typename TrackletEngineUnit()>::RZBIN start; ap_uint<1> usenext; istep_loop: for(unsigned istep=0;istep()>::INDEX writeindexnext=teuwriteindex[k]+1; - const typename VMStubTEOuter()>::VMSTEOFINEPHI& finephi = teunits[k].outervmstub___.getFinePhi(); - const ap_uint<1+VMStubTEOuterBase()>::kVMSTEOFineZSize>& rzbin = (teunits[k].next___, teunits[k].outervmstub___.getFineZ()); + const typename VMStub()>::VMSFINEPHI& finephi = teunits[k].outervmstub___.getFinePhi(); + const ap_uint<1+VMStubBase()>::kVMSFineZSize>& rzbin = (teunits[k].next___, teunits[k].outervmstub___.getFineZ()); ap_uint outerfinephi = (iAllstub, teunits[k].ireg___, finephi); diff --git a/TrackletAlgorithm/VMRouterCM.h b/TrackletAlgorithm/VMRouterCM.h index edd8c6216e2..5aa5110f87b 100644 --- a/TrackletAlgorithm/VMRouterCM.h +++ b/TrackletAlgorithm/VMRouterCM.h @@ -17,8 +17,7 @@ #include "InputStubMemory.h" #include "AllStubMemory.h" #include "AllStubInnerMemory.h" -#include "VMStubMEMemoryCM.h" -#include "VMStubTEOuterMemoryCM.h" +#include "VMStubMemory.h" #ifndef __SYNTHESIS__ #ifdef CMSSW_GIT_HASH #include "FWCore/MessageLogger/interface/MessageLogger.h" @@ -186,9 +185,9 @@ void VMRouterCM(const BXType bx, BXType& bx_o, const ap_uint& maskASI, AllStubInnerMemory memoriesASInner[], // ME memories - VMStubMEMemoryCM *memoryME, + VMStubMemory *memoryME, // TE Outer memories - VMStubTEOuterMemoryCM memoriesTEO[]) { + VMStubMemory memoriesTEO[]) { #pragma HLS inline #pragma HLS array_partition variable=inputStubs complete dim=1 @@ -391,9 +390,9 @@ void VMRouterCM(const BXType bx, BXType& bx_o, int slotME; // The bin the stub is going to be put in, in the memory // Create the ME stub to save - VMStubMECM stubME = (disk2S) ? - createVMStub, DISK2S, OutType, Layer, Disk, true>(stubDisk2S, i, negDisk,METable, phiCorrTable, slotME) : - createVMStub, InType, OutType, Layer, Disk, true>(stub, i, negDisk, METable, phiCorrTable, slotME); + VMStub stubME = (disk2S) ? + createVMStub, DISK2S, OutType, Layer, Disk, true>(stubDisk2S, i, negDisk,METable, phiCorrTable, slotME) : + createVMStub, InType, OutType, Layer, Disk, true>(stub, i, negDisk, METable, phiCorrTable, slotME); // Write the ME stub memoryME->write_mem(bx, slotME, stubME, addrCountME[slotME]); @@ -412,9 +411,9 @@ void VMRouterCM(const BXType bx, BXType& bx_o, int slotTE; // The bin the stub is going to be put in, in the memory // Create the TE Outer stub to save - VMStubTEOuter stubTEO = (Layer) ? - createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, METable, phiCorrTable, slotTE) : - createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, TEDiskTable, phiCorrTable, slotTE); + VMStub stubTEO = (Layer) ? + createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, METable, phiCorrTable, slotTE) : + createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, TEDiskTable, phiCorrTable, slotTE); // Write stub to all TE memory copies for (int n = 0; n < nTEOCopies; n++) { diff --git a/TrackletAlgorithm/VMSMERouter.h b/TrackletAlgorithm/VMSMERouter.h index 46759c935c0..8623077aa73 100644 --- a/TrackletAlgorithm/VMSMERouter.h +++ b/TrackletAlgorithm/VMSMERouter.h @@ -12,7 +12,7 @@ #include "Constants.h" #include "AllStubMemory.h" -#include "VMStubMEMemoryCM.h" +#include "VMStubMemory.h" #ifndef __SYNTHESIS__ #ifdef CMSSW_GIT_HASH #include "FWCore/MessageLogger/interface/MessageLogger.h" @@ -156,7 +156,7 @@ void VMSMERouter(const BXType bx, BXType& bx_o, const int phiCorrTable[], // Input memories AllStub& allStub, - VMStubMEMemoryCM *memoryME, + VMStubMemory *memoryME, AllStubMemory& memoriesAS, // Array to count how many VMStubs written in each slot unsigned int index, @@ -203,10 +203,10 @@ void VMSMERouter(const BXType bx, BXType& bx_o, // Create the ME stub to save if (valid) { - VMStubMECM stubME = (disk2S) ? - createVMStubME, DISK2S, Layer, Disk>(stub_2s, index, negDisk, METable, phiCorrTable, slotME) : (isDisk) ? - createVMStubME, DISKPS, Layer, Disk>(stub_ps, index, negDisk, METable, phiCorrTable, slotME) : - createVMStubME, InType, Layer, Disk>(allStub, index, negDisk, METable, phiCorrTable, slotME); + VMStub stubME = (disk2S) ? + createVMStubME, DISK2S, Layer, Disk>(stub_2s, index, negDisk, METable, phiCorrTable, slotME) : (isDisk) ? + createVMStubME, DISKPS, Layer, Disk>(stub_ps, index, negDisk, METable, phiCorrTable, slotME) : + createVMStubME, InType, Layer, Disk>(allStub, index, negDisk, METable, phiCorrTable, slotME); // Write the ME stub memoryME->write_mem(bx, slotME, stubME, 0); diff --git a/TrackletAlgorithm/VMStubMEMemoryCM.h b/TrackletAlgorithm/VMStubMEMemoryCM.h deleted file mode 100644 index d65b4d11009..00000000000 --- a/TrackletAlgorithm/VMStubMEMemoryCM.h +++ /dev/null @@ -1,165 +0,0 @@ -#ifndef TrackletAlgorithm_VMStubMEMemoryCM_h -#define TrackletAlgorithm_VMStubMEMemoryCM_h - -#include "Constants.h" -#include "MemoryTemplateBinnedCM.h" -#include "globalFunctions.h" - -// Memory containing stub data written by the VMRouter, consisting of coarse -// stub data + a pointer to the full precision stub data in the AllStubMemory. - -// VMStubMECMBase is where we define the bit widths, which depend on the class template parameter. -template class VMStubMECMBase {}; - -template<> -class VMStubMECMBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubMEMemoryCM fields - kVMSMEFineZSize = 3, - kVMSMEFinePhiSize = 3, - kVMSMEBendSize = 3, - kVMSMEIDSize = 7, - // Bit size for full VMStubMEMemoryCM - kVMStubMECMSize = kVMSMEFineZSize + kVMSMEFinePhiSize + kVMSMEBendSize + kVMSMEIDSize - }; -}; - -template<> -class VMStubMECMBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubMEMemoryCM fields - kVMSMEFineZSize = 3, - kVMSMEFinePhiSize = 3, - kVMSMEBendSize = 4, - kVMSMEIDSize = 7, - // Bit size for full VMStubMEMemoryCM - kVMStubMECMSize = kVMSMEFineZSize + kVMSMEFinePhiSize + kVMSMEBendSize + kVMSMEIDSize - }; -}; - -template<> -class VMStubMECMBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubMEMemoryCM fields - kVMSMEFineZSize = 3, - kVMSMEFinePhiSize = 3, - kVMSMEBendSize = 4, - kVMSMEIDSize = 7, - // Bit size for full VMStubMEMemoryCM - kVMStubMECMSize = kVMSMEFineZSize + kVMSMEFinePhiSize + kVMSMEBendSize + kVMSMEIDSize - }; -}; - -// Data object definition -template -class VMStubMECM : public VMStubMECMBase -{ -public: - enum BitLocations { - // The location of the least significant bit (LSB) and most significant bit (MSB) in the VMStubMEMemoryCM word for different fields - kVMSMEFineZLSB = 0, - kVMSMEFineZMSB = kVMSMEFineZLSB + VMStubMECMBase::kVMSMEFineZSize - 1, - kVMSMEFinePhiLSB = kVMSMEFineZMSB + 1, - kVMSMEFinePhiMSB = kVMSMEFinePhiLSB + VMStubMECMBase::kVMSMEFinePhiSize - 1, - kVMSMEBendLSB = kVMSMEFinePhiMSB + 1, - kVMSMEBendMSB = kVMSMEBendLSB + VMStubMECMBase::kVMSMEBendSize - 1, - kVMSMEIDLSB = kVMSMEBendMSB + 1, - kVMSMEIDMSB = kVMSMEIDLSB + VMStubMECMBase::kVMSMEIDSize - 1 - }; - - typedef ap_uint::kVMSMEIDSize> VMSMEID; - typedef ap_uint::kVMSMEBendSize> VMSMEBEND; - typedef ap_uint::kVMSMEBendSize - 1> VMSMEBENDPSDISK; - typedef ap_uint::kVMSMEFineZSize> VMSMEFINEZ; - typedef ap_uint::kVMSMEFinePhiSize> VMSMEFINEPHI; - - typedef ap_uint::kVMStubMECMSize> VMStubMECMData; - - // Constructors - VMStubMECM(const VMStubMECMData& newdata): - data_(newdata) - {} - - VMStubMECM(const VMSMEID id, const VMSMEBEND bend, const VMSMEFINEPHI finephi, const VMSMEFINEZ finez): - data_( (id, bend,finephi, finez) ) - {} - - VMStubMECM() - {} - - #ifndef __SYNTHESIS__ - VMStubMECM(const char* datastr, int base=16) - { - VMStubMECMData newdata(datastr, base); - data_ = newdata; - } - #endif - - // Getter - static constexpr int getWidth() {return VMStubMECMBase::kVMStubMECMSize;} - - VMStubMECMData raw() const {return data_;} - - VMSMEID getIndex() const { - return data_.range(kVMSMEIDMSB,kVMSMEIDLSB); - } - - VMSMEBEND getBend() const { - return data_.range(kVMSMEBendMSB,kVMSMEBendLSB); - } - - VMSMEBENDPSDISK getBendPSDisk() const { - return data_.range(kVMSMEBendMSB - 1,kVMSMEBendLSB); - } - - VMSMEFINEPHI getFinePhi() const { - return data_.range(kVMSMEFinePhiMSB, kVMSMEFinePhiLSB); - } - - VMSMEFINEZ getFineZ() const { - return data_.range(kVMSMEFineZMSB,kVMSMEFineZLSB); - } - - // Setter - void setIndex(const VMSMEID id) { - data_.range(kVMSMEIDMSB,kVMSMEIDLSB) = id; - } - - void setBend(const VMSMEBEND bend) { - data_.range(kVMSMEBendMSB,kVMSMEBendLSB) = bend; - } - - void setFinePhi(const VMSMEFINEPHI finephi) { - data_.range(kVMSMEFinePhiMSB,kVMSMEFinePhiLSB) = finephi; - } - - void setFineZ(const VMSMEFINEZ finez) { - data_.range(kVMSMEFineZMSB,kVMSMEFineZLSB) = finez; - } - -#ifdef CMSSW_GIT_HASH - std::string getBitStr() const { - std::string str = decodeToBits(getIndex()); - str += "|"+decodeToBits(getBend()); - str += "|"+decodeToBits(getFinePhi()); - str += "|"+decodeToBits(getFineZ()); - return str; - } -#endif - -private: - - VMStubMECMData data_; - -}; - -// Memory definition -template using VMStubMEMemoryCM = MemoryTemplateBinnedCM, 1, 4+RZSize+PhiRegSize, RZSize+PhiRegSize, PhiRegSize, NCOPY>; - -#endif diff --git a/TrackletAlgorithm/VMStubMemory.h b/TrackletAlgorithm/VMStubMemory.h new file mode 100644 index 00000000000..b89a63957c1 --- /dev/null +++ b/TrackletAlgorithm/VMStubMemory.h @@ -0,0 +1,165 @@ +#ifndef TrackletAlgorithm_VMStubMemory_h +#define TrackletAlgorithm_VMStubMemory_h + +#include "Constants.h" +#include "MemoryTemplateBinnedCM.h" +#include "globalFunctions.h" + +// Memory containing stub data written by the VMRouter, consisting of coarse +// stub data + a pointer to the full precision stub data in the AllStubMemory. + +// VMStubBase is where we define the bit widths, which depend on the class template parameter. +template class VMStubBase {}; + +template<> +class VMStubBase +{ +public: + enum BitWidths { + // Bit sizes for VMStubMemory fields + kVMSFineZSize = 3, + kVMSFinePhiSize = 3, + kVMSBendSize = 3, + kVMSIDSize = 7, + // Bit size for full VMStubMemory + kVMStubSize = kVMSFineZSize + kVMSFinePhiSize + kVMSBendSize + kVMSIDSize + }; +}; + +template<> +class VMStubBase +{ +public: + enum BitWidths { + // Bit sizes for VMStubMemory fields + kVMSFineZSize = 3, + kVMSFinePhiSize = 3, + kVMSBendSize = 4, + kVMSIDSize = 7, + // Bit size for full VMStubMemory + kVMStubSize = kVMSFineZSize + kVMSFinePhiSize + kVMSBendSize + kVMSIDSize + }; +}; + +template<> +class VMStubBase +{ +public: + enum BitWidths { + // Bit sizes for VMStubMemory fields + kVMSFineZSize = 3, + kVMSFinePhiSize = 3, + kVMSBendSize = 4, + kVMSIDSize = 7, + // Bit size for full VMStubMemory + kVMStubSize = kVMSFineZSize + kVMSFinePhiSize + kVMSBendSize + kVMSIDSize + }; +}; + +// Data object definition +template +class VMStub : public VMStubBase +{ +public: + enum BitLocations { + // The location of the least significant bit (LSB) and most significant bit (MSB) in the VMStubMemory word for different fields + kVMSFineZLSB = 0, + kVMSFineZMSB = kVMSFineZLSB + VMStubBase::kVMSFineZSize - 1, + kVMSFinePhiLSB = kVMSFineZMSB + 1, + kVMSFinePhiMSB = kVMSFinePhiLSB + VMStubBase::kVMSFinePhiSize - 1, + kVMSBendLSB = kVMSFinePhiMSB + 1, + kVMSBendMSB = kVMSBendLSB + VMStubBase::kVMSBendSize - 1, + kVMSIDLSB = kVMSBendMSB + 1, + kVMSIDMSB = kVMSIDLSB + VMStubBase::kVMSIDSize - 1 + }; + + typedef ap_uint::kVMSIDSize> VMSID; + typedef ap_uint::kVMSBendSize> VMSBEND; + typedef ap_uint::kVMSBendSize - 1> VMSBENDPSDISK; + typedef ap_uint::kVMSFineZSize> VMSFINEZ; + typedef ap_uint::kVMSFinePhiSize> VMSFINEPHI; + + typedef ap_uint::kVMStubSize> VMStubData; + + // Constructors + VMStub(const VMStubData& newdata): + data_(newdata) + {} + + VMStub(const VMSID id, const VMSBEND bend, const VMSFINEPHI finephi, const VMSFINEZ finez): + data_( (id, bend,finephi, finez) ) + {} + + VMStub() + {} + + #ifndef __SYNTHESIS__ + VMStub(const char* datastr, int base=16) + { + VMStubData newdata(datastr, base); + data_ = newdata; + } + #endif + + // Getter + static constexpr int getWidth() {return VMStubBase::kVMStubSize;} + + VMStubData raw() const {return data_;} + + VMSID getIndex() const { + return data_.range(kVMSIDMSB,kVMSIDLSB); + } + + VMSBEND getBend() const { + return data_.range(kVMSBendMSB,kVMSBendLSB); + } + + VMSBENDPSDISK getBendPSDisk() const { + return data_.range(kVMSBendMSB - 1,kVMSBendLSB); + } + + VMSFINEPHI getFinePhi() const { + return data_.range(kVMSFinePhiMSB, kVMSFinePhiLSB); + } + + VMSFINEZ getFineZ() const { + return data_.range(kVMSFineZMSB,kVMSFineZLSB); + } + + // Setter + void setIndex(const VMSID id) { + data_.range(kVMSIDMSB,kVMSIDLSB) = id; + } + + void setBend(const VMSBEND bend) { + data_.range(kVMSBendMSB,kVMSBendLSB) = bend; + } + + void setFinePhi(const VMSFINEPHI finephi) { + data_.range(kVMSFinePhiMSB,kVMSFinePhiLSB) = finephi; + } + + void setFineZ(const VMSFINEZ finez) { + data_.range(kVMSFineZMSB,kVMSFineZLSB) = finez; + } + +#ifdef CMSSW_GIT_HASH + std::string getBitStr() const { + std::string str = decodeToBits(getIndex()); + str += "|"+decodeToBits(getBend()); + str += "|"+decodeToBits(getFinePhi()); + str += "|"+decodeToBits(getFineZ()); + return str; + } +#endif + +private: + + VMStubData data_; + +}; + +// Memory definition +template using VMStubMemory = MemoryTemplateBinnedCM, 1, 4+RZSize+PhiRegSize, RZSize+PhiRegSize, PhiRegSize, NCOPY>; + +#endif diff --git a/TrackletAlgorithm/VMStubTEOuterMemoryCM.h b/TrackletAlgorithm/VMStubTEOuterMemoryCM.h deleted file mode 100644 index df2c4cfd659..00000000000 --- a/TrackletAlgorithm/VMStubTEOuterMemoryCM.h +++ /dev/null @@ -1,157 +0,0 @@ -#ifndef TrackletAlgorithm_VMStubTEOuterMemory_h -#define TrackletAlgorithm_VMStubTEOuterMemory_h - -#include "Constants.h" -#include "MemoryTemplateBinnedCM.h" -#include "globalFunctions.h" - -// VMStubTEOuterBase is where we define the bit widths, which depend on the class template parameter. -template class VMStubTEOuterBase {}; - -template<> -class VMStubTEOuterBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubTEOuterMemory fields - kVMSTEOFineZSize = 3, - kVMSTEOFinePhiSize = 3, - kVMSTEOBendSize = 3, - kVMSTEOIDSize = 7, - // Bit size for full VMStubTEOuterMemory - kVMStubTEOuterSize = kVMSTEOFineZSize + kVMSTEOFinePhiSize + kVMSTEOBendSize + kVMSTEOIDSize - }; -}; - -template<> -class VMStubTEOuterBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubTEOuterMemory fields - kVMSTEOFineZSize = 3, - kVMSTEOFinePhiSize = 3, - kVMSTEOBendSize = 4, - kVMSTEOIDSize = 7, - // Bit size for full VMStubTEOuterMemory - kVMStubTEOuterSize = kVMSTEOFineZSize + kVMSTEOFinePhiSize + kVMSTEOBendSize + kVMSTEOIDSize - }; -}; - -template<> -class VMStubTEOuterBase -{ -public: - enum BitWidths { - // Bit sizes for VMStubTEOuterMemory fields - kVMSTEOFineZSize = 3, - kVMSTEOFinePhiSize = 3, - kVMSTEOBendSize = 3, - kVMSTEOIDSize = 7, - // Bit size for full VMStubTEOuterMemory - kVMStubTEOuterSize = kVMSTEOFineZSize + kVMSTEOFinePhiSize + kVMSTEOBendSize + kVMSTEOIDSize - }; -}; - -// Data object definition -template -class VMStubTEOuter : public VMStubTEOuterBase -{ -public: - enum BitLocations { - // The location of the least significant bit (LSB) and most significant bit (MSB) in the VMStubTEOuterMemory word for different fields - kVMSTEOFineZLSB = 0, - kVMSTEOFineZMSB = kVMSTEOFineZLSB + VMStubTEOuterBase::kVMSTEOFineZSize - 1, - kVMSTEOFinePhiLSB = kVMSTEOFineZMSB + 1, - kVMSTEOFinePhiMSB = kVMSTEOFinePhiLSB + VMStubTEOuterBase::kVMSTEOFinePhiSize - 1, - kVMSTEOBendLSB = kVMSTEOFinePhiMSB + 1, - kVMSTEOBendMSB = kVMSTEOBendLSB + VMStubTEOuterBase::kVMSTEOBendSize - 1, - kVMSTEOIDLSB = kVMSTEOBendMSB + 1, - kVMSTEOIDMSB = kVMSTEOIDLSB + VMStubTEOuterBase::kVMSTEOIDSize - 1 - }; - - typedef ap_uint::kVMSTEOIDSize> VMSTEOID; - typedef ap_uint::kVMSTEOBendSize> VMSTEOBEND; - typedef ap_uint::kVMSTEOFinePhiSize> VMSTEOFINEPHI; - typedef ap_uint::kVMSTEOFineZSize> VMSTEOFINEZ; - - typedef ap_uint::kVMStubTEOuterSize> VMStubTEOuterData; - - // Constructors - VMStubTEOuter(const VMStubTEOuterData& newdata): - data_(newdata) - {} - - VMStubTEOuter(const VMSTEOID id, const VMSTEOBEND bend, const VMSTEOFINEPHI finephi, const VMSTEOFINEZ finez): - data_( (((id,bend),finephi),finez) ) - {} - - VMStubTEOuter() - {} - - #ifndef __SYNTHESIS__ - VMStubTEOuter(const char* datastr, int base=16) - { - VMStubTEOuterData newdata(datastr, base); - data_ = newdata; - } - #endif - - // Getter - static constexpr int getWidth() {return VMStubTEOuterBase::kVMStubTEOuterSize;} - - VMStubTEOuterData raw() const {return data_;} - - VMSTEOID getIndex() const { - return data_.range(kVMSTEOIDMSB,kVMSTEOIDLSB); - } - - VMSTEOBEND getBend() const { - return data_.range(kVMSTEOBendMSB,kVMSTEOBendLSB); - } - - VMSTEOFINEPHI getFinePhi() const { - return data_.range(kVMSTEOFinePhiMSB,kVMSTEOFinePhiLSB); - } - - VMSTEOFINEZ getFineZ() const { - return data_.range(kVMSTEOFineZMSB,kVMSTEOFineZLSB); - } - - // Setter - void setIndex(const VMSTEOID id) { - data_.range(kVMSTEOIDMSB,kVMSTEOIDLSB) = id; - } - - void setBend(const VMSTEOBEND bend) { - data_.range(kVMSTEOBendMSB,kVMSTEOBendLSB) = bend; - } - - void setFinePhi(const VMSTEOFINEPHI finephi) { - data_.range(kVMSTEOFinePhiMSB,kVMSTEOFinePhiLSB) = finephi; - } - - void setFineZ(const VMSTEOFINEZ finez) { - data_.range(kVMSTEOFineZMSB,kVMSTEOFineZLSB) = finez; - } - -#ifdef CMSSW_GIT_HASH - std::string getBitStr() const { - std::string str = decodeToBits(getIndex()); - str += "|"+decodeToBits(getBend()); - str += "|"+decodeToBits(getFinePhi()); - str += "|"+decodeToBits(getFineZ()); - return str; - } -#endif - -private: - - VMStubTEOuterData data_; - -}; - -// Memory definition -template using VMStubTEOuterMemoryCM = MemoryTemplateBinnedCM, 1, 4+RZSize+PhiRegSize, RZSize+PhiRegSize, PhiRegSize, NCOPY>; - -#endif diff --git a/emData/generate_MP.py b/emData/generate_MP.py index 1648ff3a82b..6f940f8ba4d 100755 --- a/emData/generate_MP.py +++ b/emData/generate_MP.py @@ -199,7 +199,7 @@ def FMRegion(region): "void MatchProcessor_" + seed + "PHI" + iMP + "(\n" " const BXType bx,\n" " const TrackletProjectionMemory<" + TProjRegion + "> projin[" + seed + "PHI" + iMP + "maxTrackletProjections],\n" - " const VMStubMEMemoryCM<" + VMStubMERegion(seed) + ", " + nrz + ", kNbitsphibin, kNMatchEngines>& instubdata,\n" + " const VMStubMemory<" + VMStubMERegion(seed) + ", " + nrz + ", kNbitsphibin, kNMatchEngines>& instubdata,\n" " const AllStubMemory<" + ASRegion(seed) + ">* allstub,\n" " BXType& bx_o,\n" " FullMatchMemory<" + FMRegion(seed) + "> fullmatch[" + seed + "PHI" + iMP + "maxFullMatchCopies]\n" @@ -212,7 +212,7 @@ def FMRegion(region): "void MatchProcessor_" + seed + "PHI" + iMP + "(\n" " const BXType bx,\n" " const TrackletProjectionMemory<" + TProjRegion + "> projin[" + seed + "PHI" + iMP + "maxTrackletProjections],\n" - " const VMStubMEMemoryCM<" + VMStubMERegion(seed) + ", " + nrz + ", kNbitsphibin, kNMatchEngines>& instubdata,\n" + " const VMStubMemory<" + VMStubMERegion(seed) + ", " + nrz + ", kNbitsphibin, kNMatchEngines>& instubdata,\n" " const AllStubMemory<" + ASRegion(seed) + ">* allstub,\n" " BXType& bx_o,\n" " FullMatchMemory<" + FMRegion(seed) + "> fullmatch[" + seed + "PHI" + iMP + "maxFullMatchCopies]\n" diff --git a/emData/generate_TP.py b/emData/generate_TP.py index 8539fa60efb..41c8f281ccc 100755 --- a/emData/generate_TP.py +++ b/emData/generate_TP.py @@ -300,7 +300,7 @@ class ProjoutIndexDisk(Enum): " BXType& bx_o,\n" " const AllStubInnerMemory()> innerStubs[TP::nASMemInner()],\n" " const AllStubMemory()>* outerStubs,\n" - " const VMStubTEOuterMemoryCM(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+seed[2:]+"]>* outerVMStubs,\n" + " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+seed[2:]+"]>* outerVMStubs,\n" " TrackletParameterMemory * trackletParameters,\n" " TrackletProjectionMemory projout_barrel_ps[],\n" " TrackletProjectionMemory projout_barrel_2s[],\n" @@ -316,7 +316,7 @@ class ProjoutIndexDisk(Enum): " BXType& bx_o,\n" " const AllStubInnerMemory()> innerStubs[TP::nASMemInner()],\n" " const AllStubMemory()>* outerStubs ,\n" - " const VMStubTEOuterMemoryCM(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+ seed[2:] +"]>* outerVMStubs,\n" + " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+ seed[2:] +"]>* outerVMStubs,\n" " TrackletParameterMemory * trackletParameters,\n" " TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS],\n" " TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S],\n" diff --git a/emData/generate_VMRCM.py b/emData/generate_VMRCM.py index 326bf09e237..c9c805e3e15 100755 --- a/emData/generate_VMRCM.py +++ b/emData/generate_VMRCM.py @@ -380,8 +380,8 @@ def writeTopHeader(vmr, output_dir): " // Output memories\n" " AllStubMemory memoriesAS[numASCopies],\n" + (" AllStubInnerMemory memoriesASInner[numASInnerCopies],\n" if has_allstub_inner[layerdisk] else "") +\ - " VMStubMEMemoryCM *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") - + (" VMStubTEOuterMemoryCM memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ + " VMStubMemory *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") + + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ " );\n" "\n" "#endif // TopFunctions_%s_h\n" % file_name @@ -417,8 +417,8 @@ def writeTopFile(vmr, num_inputs, num_inputs_disk2s, output_dir): " // Output memories\n" " AllStubMemory memoriesAS[numASCopies],\n" + (" AllStubInnerMemory memoriesASInner[numASInnerCopies],\n" if has_allstub_inner[layerdisk] else "") +\ - " VMStubMEMemoryCM *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") - + (" VMStubTEOuterMemoryCM memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ + " VMStubMemory *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") + + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ " ) {\n" "\n" "// Takes 2 clock cycles before one gets data, used at high frequencies\n" diff --git a/emData/generate_VMSMER.py b/emData/generate_VMSMER.py index c061be151e5..d40b3af54fd 100755 --- a/emData/generate_VMSMER.py +++ b/emData/generate_VMSMER.py @@ -90,7 +90,7 @@ def writeTopHeader(vmr, output_dir): " // Input memories\n" " AllStub& allStub,\n" " // Output memories\n" - " VMStubMEMemoryCM *memoryME,\n" + " VMStubMemory *memoryME,\n" " AllStubMemory& memoriesAS,\n" " // Index of AllStub\n" " unsigned int index,\n" @@ -130,7 +130,7 @@ def writeTopFile(vmr, output_dir): " // Input memories\n" " AllStub& allStub,\n" " // Output memories\n" - " VMStubMEMemoryCM *memoryME,\n" + " VMStubMemory *memoryME,\n" " AllStubMemory& memoriesAS,\n" " // Index of AllStub\n" " unsigned int index,\n" From 7b6f4f0bc8dbd77cb9713bf5561e894410113c9c Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Tue, 5 Nov 2024 16:46:19 -0500 Subject: [PATCH 02/14] Correct bug so that we have correct stub bend size for TE VMStubs --- TestBenches/TrackletProcessor_test.cpp | 4 +-- TestBenches/VMRouterCM_test.cpp | 4 +-- TrackletAlgorithm/TrackletEngineUnit.h | 4 +-- TrackletAlgorithm/TrackletProcessor.h | 10 +++--- TrackletAlgorithm/VMRouterCM.h | 8 ++--- TrackletAlgorithm/VMStubMemory.h | 44 +++++++++++++------------- emData/generate_TP.py | 4 +-- emData/generate_VMRCM.py | 4 +-- 8 files changed, 41 insertions(+), 41 deletions(-) diff --git a/TestBenches/TrackletProcessor_test.cpp b/TestBenches/TrackletProcessor_test.cpp index 4eedc7fd43f..86a94400caf 100644 --- a/TestBenches/TrackletProcessor_test.cpp +++ b/TestBenches/TrackletProcessor_test.cpp @@ -109,7 +109,7 @@ std::cout< > innerStubs(nInnerStubMems); vector > outerStubs(nOuterStubMems); - vector > outervmStubs(nOuterVMStubMems); + vector > outervmStubs(nOuterVMStubMems); // output memories TrackletParameterMemory tpar; @@ -145,7 +145,7 @@ std::cout< >(outerStubs[i], fin_outerStubs.at(i), ievt); for (unsigned i = 0; i < nOuterVMStubMems; i++) - writeMemFromFile>(outervmStubs[i], fin_outervmStubs.at(i), ievt); + writeMemFromFile>(outervmStubs[i], fin_outervmStubs.at(i), ievt); // clear all output memories before starting tpar.clear(); diff --git a/TestBenches/VMRouterCM_test.cpp b/TestBenches/VMRouterCM_test.cpp index 2e8f75670fc..8399cd0a711 100644 --- a/TestBenches/VMRouterCM_test.cpp +++ b/TestBenches/VMRouterCM_test.cpp @@ -74,7 +74,7 @@ int main() { static AllStubMemory memoriesAS[numASCopies]; static AllStubInnerMemory memoriesASInner[numASInnerCopies]; static VMStubMemory memoryME; - static VMStubMemory memoriesTEO[numTEOCopies]; + static VMStubMemory memoriesTEO[numTEOCopies]; /////////////////////////// @@ -147,7 +147,7 @@ int main() { //TE Outer memories if (nVMSTE) { for (unsigned int i = 0; i < nVMSTE; i++) { - err += compareBinnedMemCMWithFile>(memoriesTEO[i], fout_vmstubte[i], ievt, "VMStubTEOuter", truncation); + err += compareBinnedMemCMWithFile>(memoriesTEO[i], fout_vmstubte[i], ievt, "VMStubTEOuter", truncation); } } } // End of event loop diff --git a/TrackletAlgorithm/TrackletEngineUnit.h b/TrackletAlgorithm/TrackletEngineUnit.h index b3f8aa38f5e..446393e18f8 100644 --- a/TrackletAlgorithm/TrackletEngineUnit.h +++ b/TrackletAlgorithm/TrackletEngineUnit.h @@ -20,7 +20,7 @@ class TrackletEngineUnit { kNBitsPTLutOuter=(Seed==TF::L5L6||Seed==TF::L1D1||Seed==TF::L2D1||Seed==TF::D1D2||Seed==TF::D3D4)?1024:(Seed==TF::L1L2||Seed==TF::L2L3)?256:512 }; - typedef ap_uint::kVMSIDSize+AllStub::kAllStubSize+TrackletParameters::kTParPhiRegionSize+kNBits_MemAddr> STUBID; + typedef ap_uint::kVMSIDSize+AllStub::kAllStubSize+TrackletParameters::kTParPhiRegionSize+kNBits_MemAddr> STUBID; typedef ap_uint NEGDISK; typedef ap_uint NSTUBS; typedef ap_uint INDEX; @@ -178,7 +178,7 @@ void write(STUBID stubs) { ap_uint<1> next__, next___; PHIBIN ireg__, ireg___; - VMStub outervmstub__, outervmstub___; + VMStub outervmstub__, outervmstub___; NSTUBS ns[16]; diff --git a/TrackletAlgorithm/TrackletProcessor.h b/TrackletAlgorithm/TrackletProcessor.h index 9d3e244ac19..9a9ce62fb01 100644 --- a/TrackletAlgorithm/TrackletProcessor.h +++ b/TrackletAlgorithm/TrackletProcessor.h @@ -688,7 +688,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) uint16_t N // maximum number of steps > void TrackletProcessor( - const BXType bx, BXType& bx_o, const LUTTYPE lut[lutsize], const AllStubInnerMemory()> innerStubs[NASMemInner], const AllStubMemory()>* outerStubs, const VMStubMemory(),kNbitsrzbin,kNbitsphibin,NVMSTECopy>* outerVMStubs, TrackletParameterMemory * const trackletParameters, TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS], TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S], TrackletProjectionMemory projout_disk[TP::N_PROJOUT_DISK] + const BXType bx, BXType& bx_o, const LUTTYPE lut[lutsize], const AllStubInnerMemory()> innerStubs[NASMemInner], const AllStubMemory()>* outerStubs, const VMStubMemory(),kNbitsrzbin,kNbitsphibin,NVMSTECopy, true>* outerVMStubs, TrackletParameterMemory * const trackletParameters, TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS], TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S], TrackletProjectionMemory projout_disk[TP::N_PROJOUT_DISK] ) { constexpr bool diskSeed = (Seed == TF::D1D2 || Seed == TF::D3D4); @@ -728,7 +728,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) const ap_uint<1>* stubptinnertmp = TP::getPTInnerLUT(); static const TPRegionLUT regionLUT(stubptinnertmp, iAllstub); - constexpr unsigned int NfinephiBits=NBitsPhiRegion+TrackletEngineUnit()>::kNBitsPhiBins+VMStubBase()>::kVMSFinePhiSize; + constexpr unsigned int NfinephiBits=NBitsPhiRegion+TrackletEngineUnit()>::kNBitsPhiBins+VMStubBase(), true>::kVMSFinePhiSize; static TEBuffer()> tebuffer; static_assert(TP::nASMemInner() <= 3, "Only handling up to three inner AS memories"); @@ -801,7 +801,7 @@ TF::seed Seed, // seed layer combination (TP::L1L2, TP::L3L4, etc.) teureadindex[k] = 0; } //quantities looked up in LUT - typename VMStub()>::VMSFINEZ rzfinebinfirst,rzdiffmax; + typename VMStub(), true>::VMSFINEZ rzfinebinfirst,rzdiffmax; typename TrackletEngineUnit()>::RZBIN start; ap_uint<1> usenext; istep_loop: for(unsigned istep=0;istep()>::INDEX writeindexnext=teuwriteindex[k]+1; - const typename VMStub()>::VMSFINEPHI& finephi = teunits[k].outervmstub___.getFinePhi(); - const ap_uint<1+VMStubBase()>::kVMSFineZSize>& rzbin = (teunits[k].next___, teunits[k].outervmstub___.getFineZ()); + const typename VMStub(), true>::VMSFINEPHI& finephi = teunits[k].outervmstub___.getFinePhi(); + const ap_uint<1+VMStubBase(), true>::kVMSFineZSize>& rzbin = (teunits[k].next___, teunits[k].outervmstub___.getFineZ()); ap_uint outerfinephi = (iAllstub, teunits[k].ireg___, finephi); diff --git a/TrackletAlgorithm/VMRouterCM.h b/TrackletAlgorithm/VMRouterCM.h index 5aa5110f87b..f01266351ab 100644 --- a/TrackletAlgorithm/VMRouterCM.h +++ b/TrackletAlgorithm/VMRouterCM.h @@ -187,7 +187,7 @@ void VMRouterCM(const BXType bx, BXType& bx_o, // ME memories VMStubMemory *memoryME, // TE Outer memories - VMStubMemory memoriesTEO[]) { + VMStubMemory memoriesTEO[]) { #pragma HLS inline #pragma HLS array_partition variable=inputStubs complete dim=1 @@ -411,9 +411,9 @@ void VMRouterCM(const BXType bx, BXType& bx_o, int slotTE; // The bin the stub is going to be put in, in the memory // Create the TE Outer stub to save - VMStub stubTEO = (Layer) ? - createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, METable, phiCorrTable, slotTE) : - createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, TEDiskTable, phiCorrTable, slotTE); + VMStub stubTEO = (Layer) ? + createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, METable, phiCorrTable, slotTE) : + createVMStub, InType, OutType, Layer, Disk, false>(stub, i, negDisk, TEDiskTable, phiCorrTable, slotTE); // Write stub to all TE memory copies for (int n = 0; n < nTEOCopies; n++) { diff --git a/TrackletAlgorithm/VMStubMemory.h b/TrackletAlgorithm/VMStubMemory.h index b89a63957c1..4d1a1c1e763 100644 --- a/TrackletAlgorithm/VMStubMemory.h +++ b/TrackletAlgorithm/VMStubMemory.h @@ -9,10 +9,10 @@ // stub data + a pointer to the full precision stub data in the AllStubMemory. // VMStubBase is where we define the bit widths, which depend on the class template parameter. -template class VMStubBase {}; +template class VMStubBase {}; -template<> -class VMStubBase +template +class VMStubBase { public: enum BitWidths { @@ -26,8 +26,8 @@ class VMStubBase }; }; -template<> -class VMStubBase +template +class VMStubBase { public: enum BitWidths { @@ -41,15 +41,15 @@ class VMStubBase }; }; -template<> -class VMStubBase +template +class VMStubBase { public: enum BitWidths { // Bit sizes for VMStubMemory fields kVMSFineZSize = 3, kVMSFinePhiSize = 3, - kVMSBendSize = 4, + kVMSBendSize = TE ? 3 : 4, kVMSIDSize = 7, // Bit size for full VMStubMemory kVMStubSize = kVMSFineZSize + kVMSFinePhiSize + kVMSBendSize + kVMSIDSize @@ -57,29 +57,29 @@ class VMStubBase }; // Data object definition -template -class VMStub : public VMStubBase +template +class VMStub : public VMStubBase { public: enum BitLocations { // The location of the least significant bit (LSB) and most significant bit (MSB) in the VMStubMemory word for different fields kVMSFineZLSB = 0, - kVMSFineZMSB = kVMSFineZLSB + VMStubBase::kVMSFineZSize - 1, + kVMSFineZMSB = kVMSFineZLSB + VMStubBase::kVMSFineZSize - 1, kVMSFinePhiLSB = kVMSFineZMSB + 1, - kVMSFinePhiMSB = kVMSFinePhiLSB + VMStubBase::kVMSFinePhiSize - 1, + kVMSFinePhiMSB = kVMSFinePhiLSB + VMStubBase::kVMSFinePhiSize - 1, kVMSBendLSB = kVMSFinePhiMSB + 1, - kVMSBendMSB = kVMSBendLSB + VMStubBase::kVMSBendSize - 1, + kVMSBendMSB = kVMSBendLSB + VMStubBase::kVMSBendSize - 1, kVMSIDLSB = kVMSBendMSB + 1, - kVMSIDMSB = kVMSIDLSB + VMStubBase::kVMSIDSize - 1 + kVMSIDMSB = kVMSIDLSB + VMStubBase::kVMSIDSize - 1 }; - typedef ap_uint::kVMSIDSize> VMSID; - typedef ap_uint::kVMSBendSize> VMSBEND; - typedef ap_uint::kVMSBendSize - 1> VMSBENDPSDISK; - typedef ap_uint::kVMSFineZSize> VMSFINEZ; - typedef ap_uint::kVMSFinePhiSize> VMSFINEPHI; + typedef ap_uint::kVMSIDSize> VMSID; + typedef ap_uint::kVMSBendSize> VMSBEND; + typedef ap_uint::kVMSBendSize - 1> VMSBENDPSDISK; + typedef ap_uint::kVMSFineZSize> VMSFINEZ; + typedef ap_uint::kVMSFinePhiSize> VMSFINEPHI; - typedef ap_uint::kVMStubSize> VMStubData; + typedef ap_uint::kVMStubSize> VMStubData; // Constructors VMStub(const VMStubData& newdata): @@ -102,7 +102,7 @@ class VMStub : public VMStubBase #endif // Getter - static constexpr int getWidth() {return VMStubBase::kVMStubSize;} + static constexpr int getWidth() {return VMStubBase::kVMStubSize;} VMStubData raw() const {return data_;} @@ -160,6 +160,6 @@ class VMStub : public VMStubBase }; // Memory definition -template using VMStubMemory = MemoryTemplateBinnedCM, 1, 4+RZSize+PhiRegSize, RZSize+PhiRegSize, PhiRegSize, NCOPY>; +template using VMStubMemory = MemoryTemplateBinnedCM, 1, 4+RZSize+PhiRegSize, RZSize+PhiRegSize, PhiRegSize, NCOPY>; #endif diff --git a/emData/generate_TP.py b/emData/generate_TP.py index 41c8f281ccc..9f1e730e03e 100755 --- a/emData/generate_TP.py +++ b/emData/generate_TP.py @@ -300,7 +300,7 @@ class ProjoutIndexDisk(Enum): " BXType& bx_o,\n" " const AllStubInnerMemory()> innerStubs[TP::nASMemInner()],\n" " const AllStubMemory()>* outerStubs,\n" - " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+seed[2:]+"]>* outerVMStubs,\n" + " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+seed[2:]+"], true>* outerVMStubs,\n" " TrackletParameterMemory * trackletParameters,\n" " TrackletProjectionMemory projout_barrel_ps[],\n" " TrackletProjectionMemory projout_barrel_2s[],\n" @@ -316,7 +316,7 @@ class ProjoutIndexDisk(Enum): " BXType& bx_o,\n" " const AllStubInnerMemory()> innerStubs[TP::nASMemInner()],\n" " const AllStubMemory()>* outerStubs ,\n" - " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+ seed[2:] +"]>* outerVMStubs,\n" + " const VMStubMemory(), kNbitsrzbin, kNbitsphibin, kNTEUnitsLayerDisk[TF::"+ seed[2:] +"], true>* outerVMStubs,\n" " TrackletParameterMemory * trackletParameters,\n" " TrackletProjectionMemory projout_barrel_ps[TP::N_PROJOUT_BARRELPS],\n" " TrackletProjectionMemory projout_barrel_2s[TP::N_PROJOUT_BARREL2S],\n" diff --git a/emData/generate_VMRCM.py b/emData/generate_VMRCM.py index c9c805e3e15..60068197071 100755 --- a/emData/generate_VMRCM.py +++ b/emData/generate_VMRCM.py @@ -381,7 +381,7 @@ def writeTopHeader(vmr, output_dir): " AllStubMemory memoriesAS[numASCopies],\n" + (" AllStubInnerMemory memoriesASInner[numASInnerCopies],\n" if has_allstub_inner[layerdisk] else "") +\ " VMStubMemory *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") - + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ + + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ " );\n" "\n" "#endif // TopFunctions_%s_h\n" % file_name @@ -418,7 +418,7 @@ def writeTopFile(vmr, num_inputs, num_inputs_disk2s, output_dir): " AllStubMemory memoriesAS[numASCopies],\n" + (" AllStubInnerMemory memoriesASInner[numASInnerCopies],\n" if has_allstub_inner[layerdisk] else "") +\ " VMStubMemory *memoryME" + (",\n" if has_vmste_outer[layerdisk] else "") - + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ + + (" VMStubMemory memoriesTEO[numTEOCopies]\n" if has_vmste_outer[layerdisk] else "") +\ " ) {\n" "\n" "// Takes 2 clock cycles before one gets data, used at high frequencies\n" From 51f082decc6490b19b12fa5264e1cb1dce38ee4a Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Wed, 13 Nov 2024 17:55:52 -0500 Subject: [PATCH 03/14] Change ordering of phi and rz in binned memories - rz is more significant bits --- IntegrationTests/common/hdl/tf_mem_bin.vhd | 6 +++--- IntegrationTests/common/script/impl.tcl | 2 +- IntegrationTests/common/script/synth.tcl | 2 +- TrackletAlgorithm/MatchEngineUnit.h | 10 +++++++--- TrackletAlgorithm/MemoryTemplateBinnedCM.h | 6 ++++-- TrackletAlgorithm/TrackletProcessor.h | 4 ++-- TrackletAlgorithm/VMRouterCM.h | 3 ++- TrackletAlgorithm/VMSMERouter.h | 3 ++- 8 files changed, 22 insertions(+), 14 deletions(-) diff --git a/IntegrationTests/common/hdl/tf_mem_bin.vhd b/IntegrationTests/common/hdl/tf_mem_bin.vhd index e7adf125f8e..3516edd57c4 100644 --- a/IntegrationTests/common/hdl/tf_mem_bin.vhd +++ b/IntegrationTests/common/hdl/tf_mem_bin.vhd @@ -227,10 +227,10 @@ process(clka) alias vi_nent_idx : std_logic_vector(NUM_PHI_BITS+NUM_RZ_BITS-1 downto 0) is addra(ADDR_WIDTH + NUM_PHI_BITS + NUM_RZ_BITS - 1 downto ADDR_WIDTH); --! Extract phi bin from bin address - alias phibits: std_logic_vector(NUM_PHI_BITS-1 downto 0) is vi_nent_idx(NUM_PHI_BITS + NUM_RZ_BITS - 1 downto NUM_RZ_BITS); + alias phibits: std_logic_vector(NUM_PHI_BITS-1 downto 0) is vi_nent_idx(NUM_PHI_BITS - 1 downto 0); --! Extract rz bin from binaddress - alias rzbits: std_logic_vector(NUM_RZ_BITS-1 downto 0) is vi_nent_idx(NUM_RZ_BITS-1 downto 0); --rz position + alias rzbits: std_logic_vector(NUM_RZ_BITS-1 downto 0) is vi_nent_idx(NUM_PHI_BITS + NUM_RZ_BITS-1 downto NUM_PHI_BITS); --rz position variable binaddr : unsigned(ADDR_WIDTH-1 downto 0) := (others => '0'); variable nentry : unsigned(ADDR_WIDTH-1 downto 0) := (others => '0'); @@ -266,7 +266,7 @@ begin -- Write data to all copies --report "tf_mem_bin vi_nent_idx vi_nent_idx_new: " & to_bstring(vi_nent_idx) & " " & to_bstring(vi_nent_idx_new) & " " & to_bstring(rzbits) & " " & to_bstring(phibits); - + binaddr := unsigned(nentry_tmp(to_integer(unsigned(vi_nent_idx)))); nentry := binaddr+1; diff --git a/IntegrationTests/common/script/impl.tcl b/IntegrationTests/common/script/impl.tcl index 6ebdf24ab5e..a985a27464d 100644 --- a/IntegrationTests/common/script/impl.tcl +++ b/IntegrationTests/common/script/impl.tcl @@ -20,7 +20,7 @@ reset_run impl_1 # Implementation update_compile_order -fileset sources_1 -launch_runs impl_1 -jobs 4 +launch_runs impl_1 -jobs 64 wait_on_run impl_1 # Make reports diff --git a/IntegrationTests/common/script/synth.tcl b/IntegrationTests/common/script/synth.tcl index 20d52a07d0f..6f4ac6ea3ba 100644 --- a/IntegrationTests/common/script/synth.tcl +++ b/IntegrationTests/common/script/synth.tcl @@ -23,7 +23,7 @@ set_property -name {STEPS.SYNTH_DESIGN.ARGS.MORE OPTIONS} -value {-mode out_of_c # Synthesis update_compile_order -fileset sources_1 -launch_runs synth_1 -jobs 4 +launch_runs synth_1 -jobs 64 wait_on_run synth_1 # Make reports diff --git a/TrackletAlgorithm/MatchEngineUnit.h b/TrackletAlgorithm/MatchEngineUnit.h index c50b9118a45..0726eccd490 100644 --- a/TrackletAlgorithm/MatchEngineUnit.h +++ b/TrackletAlgorithm/MatchEngineUnit.h @@ -123,8 +123,6 @@ inline void step(const VMStub stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin auto secondSave = second_; VMProjection data(projbuffer_.getProjection()); - constexpr bool isDisk = LAYER > TF::L6; - constexpr int nbins = isDisk ? (1 << kNbitsrzbin)*2 : (1 << kNbitsrzbin); //twice as many bins in disks (since there are two disks) if(istub_ == 0) { @@ -153,7 +151,13 @@ inline void step(const VMStub stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin projrinv__ = data.getRInv(); } - ap_uint::kPRBufferZBinSize -1 + kNBits_MemAddrBinned> slot = (iphi_ + use_[iusetmp].range(0,0)) * nbins + zbin_ + use_[iusetmp].range(1,1); + const int nphibins = 3; //number of bits for phi bins in VM memory not that L1 actually only uses 2 bits + ap_uint::kPRBufferZBinSize -1 + kNBits_MemAddrBinned> slot = iphi_ + use_[iusetmp].range(0,0) + (zbin_ + use_[iusetmp].range(1,1)) * (1 << nphibins); + + //The previous line should be like below after L1 is fixed to use four phi bins in the memories + //ap_uint::kPRBufferZBinSize -1 + kNBits_MemAddrBinned> slot = iphi_ + use_[iusetmp].range(0,0) + (zbin_ + use_[iusetmp].range(1,1)) * (1 << nbits_vmmeall[LAYER]); + + zbin__ = zbin_ + use_[iusetmp].range(1,1); zbin__ = zbin_ + use_[iusetmp].range(1,1); //Read stub memory and extract data fields auto stubadd=(slot,istubtmp); diff --git a/TrackletAlgorithm/MemoryTemplateBinnedCM.h b/TrackletAlgorithm/MemoryTemplateBinnedCM.h index 1a52bd4fa3c..7f3c294291a 100644 --- a/TrackletAlgorithm/MemoryTemplateBinnedCM.h +++ b/TrackletAlgorithm/MemoryTemplateBinnedCM.h @@ -147,7 +147,7 @@ class MemoryTemplateBinnedCM{ ap_uint ibin; ap_uint ireg; - (ireg,ibin)=slot; + (ibin,ireg)=slot; unsigned int nentry = nentries_[ibx*kNBinsRZ+ibin].range(ireg*4+3,ireg*4); @@ -234,8 +234,10 @@ class MemoryTemplateBinnedCM{ DataType data(datastr.c_str(), base); - bool success = write_mem(ibx, slot, data, nentry_ibx); + int slot2 = (ibin,ireg); //swap order, should be changed in the input files + bool success = write_mem(ibx, slot2, data, nentry_ibx); + return success; } diff --git a/TrackletAlgorithm/TrackletProcessor.h b/TrackletAlgorithm/TrackletProcessor.h index 9a9ce62fb01..1ee9317f3ff 100644 --- a/TrackletAlgorithm/TrackletProcessor.h +++ b/TrackletAlgorithm/TrackletProcessor.h @@ -1020,8 +1020,8 @@ teunits[k].idle_; //Fill the result teunits[k].outervmstub__ = outerVMStubs->read_mem(k, bx, init? - (ireg_init, ibin_init,typename TrackletEngineUnit()>::NSTUBS(0)): - (ireg_reg, ibin_reg, istub_tmp_reg)); + (ibin_init, ireg_init, typename TrackletEngineUnit()>::NSTUBS(0)): + (ibin_reg, ireg_reg, istub_tmp_reg)); teunits[k].next__ = init?next_init:next_reg; teunits[k].ireg__ = init?ireg_init:ireg_reg; teunits[k].good__ = init?good_init:good_reg; diff --git a/TrackletAlgorithm/VMRouterCM.h b/TrackletAlgorithm/VMRouterCM.h index f01266351ab..d89b8012d18 100644 --- a/TrackletAlgorithm/VMRouterCM.h +++ b/TrackletAlgorithm/VMRouterCM.h @@ -155,7 +155,8 @@ inline T createVMStub(const InputStub inputStub, if (negDisk) bin += 1 << (nbitsbin-1); // The upper half of the bins are for negative disks auto ivm = phicorr.range(phicorr.length() - nbitsall - 1, phicorr.length() - (nbitsall + vmbits)); //get the phi bits that corresponds to the old vms - slot = ivm * (1 << nbitsbin) + bin; + const int nbinsphi = 3; + slot = (bin << nbinsphi) + ivm; // Set rzfine, i.e. the r/z bits within a coarse r/z region auto rzfine = lutValue & ((1 << nbitsfinerz) - 1); // the 3 LSB as rzfine diff --git a/TrackletAlgorithm/VMSMERouter.h b/TrackletAlgorithm/VMSMERouter.h index 8623077aa73..55d3be2f379 100644 --- a/TrackletAlgorithm/VMSMERouter.h +++ b/TrackletAlgorithm/VMSMERouter.h @@ -133,7 +133,8 @@ inline T createVMStubME(const AllStub& allStub, if (negDisk) bin += 1 << (nbitsbin-1); // The upper half of the bins are for negative disks auto ivm = phicorr.range(phicorr.length() - nbitsall - 1, phicorr.length() - (nbitsall + vmbits)); //get the phi bits that corresponds to the old vms - slot = ivm * (1 << nbitsbin) + bin; + const int nbinsphi = 3; + slot = (bin << nbinsphi) + ivm; // Set rzfine, i.e. the r/z bits within a coarse r/z region auto rzfine = lutValue & ((1 << nbitsfinerz) - 1); // the 3 LSB as rzfine From a296d2f72937b7f67e6410e63b34007782972850 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Wed, 13 Nov 2024 17:56:59 -0500 Subject: [PATCH 04/14] Updates to ordering pf phi and rz for binmask in vm memories --- emData/project_generation_scripts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emData/project_generation_scripts b/emData/project_generation_scripts index 0706ea88797..f59293a412e 160000 --- a/emData/project_generation_scripts +++ b/emData/project_generation_scripts @@ -1 +1 @@ -Subproject commit 0706ea88797cc1f2c2493a2bf528c973a67408b5 +Subproject commit f59293a412eb98f752b0fac0f9f1c47a2d8beaef From f41653bff9ec8c37ce259d8d2cbc53d284ac7a55 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Fri, 22 Nov 2024 21:05:12 -0500 Subject: [PATCH 05/14] Some updates to get agreement between emulation and HLS in MP --- TestBenches/MatchProcessor_test.cpp | 16 +-- TestBenches/TrackletProcessor_test.cpp | 140 --------------------- TrackletAlgorithm/MatchProcessor.h | 25 ++-- TrackletAlgorithm/MemoryTemplateBinnedCM.h | 6 +- emData/download.sh | 13 +- project/script_MP.tcl | 14 +-- 6 files changed, 37 insertions(+), 177 deletions(-) diff --git a/TestBenches/MatchProcessor_test.cpp b/TestBenches/MatchProcessor_test.cpp index 68c4be476fd..6bd1d246a86 100644 --- a/TestBenches/MatchProcessor_test.cpp +++ b/TestBenches/MatchProcessor_test.cpp @@ -26,7 +26,7 @@ using namespace std; int main() { // Define memory patterns - const string trackletProjectionPattern = "TrackletProjections*"; + const string trackletProjectionPattern = "TrackletProjections_MPROJ*"; const string allStubPatternarray = "AllStub*"; const string vmStubPatternarray = "VMStubs_VMSME*"; const string fullMatchPattern = "FullMatches*"; @@ -71,6 +71,11 @@ int main() for (unsigned int ievt = 0; ievt < nevents; ++ievt) { cout << "Event: " << dec << ievt << endl; + // bx + BXType bx = ievt; + BXType bx_out; + + // read event and write to memories auto &fin_TrackletProjections = tb.files(trackletProjectionPattern); for (unsigned int i = 0; i < nTrackletProjections; i++) @@ -85,10 +90,6 @@ int main() for (unsigned int i = 0; i < nFullMatches; i++) fullmatcharray[i].clear(); - // bx - BXType bx = ievt; - BXType bx_out; - // Unit Under Test TOP_FUNC_(bx, tprojarray.data(), vmstub, allstub.data(), bx_out, fullmatcharray.data()); @@ -106,10 +107,9 @@ int main() } // end of event loop - // This is necessary because HLS seems to only return an 8-bit error count, so if err%256==0, the test bench can falsely pass + // This is necessary because HLS seems to only return an 8-bit error count, + // so if err%256==0, the test bench can falsely pass if (err > 255) err = 255; -// cout << "Module actually has " << err << " errors." << endl; -// return 0; return err; } diff --git a/TestBenches/TrackletProcessor_test.cpp b/TestBenches/TrackletProcessor_test.cpp index 86a94400caf..bed3968e8f8 100644 --- a/TestBenches/TrackletProcessor_test.cpp +++ b/TestBenches/TrackletProcessor_test.cpp @@ -122,8 +122,6 @@ std::cout<(tpar, fout_tpar.at(0), ievt, "\nTrackletParameter", truncation); - for (unsigned i = 0; i < tproj_names.size(); i++) { - const auto &tproj_name = tproj_names.at(i); - auto &fout = fout_tproj.at(i); - if (tproj_name.find("_D1PHIA") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D1PHIA], fout, ievt, - "\nTrackletProjection (D1PHIA)", truncation); - else if (tproj_name.find("_D1PHIB") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D1PHIB], fout, ievt, - "\nTrackletProjection (D1PHIB)", truncation); - else if (tproj_name.find("_D1PHIC") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D1PHIC], fout, ievt, - "\nTrackletProjection (D1PHIC)", truncation); - else if (tproj_name.find("_D1PHID") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D1PHID], fout, ievt, - "\nTrackletProjection (D1PHID)", truncation); - else if (tproj_name.find("_D2PHIA") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D2PHIA], fout, ievt, - "\nTrackletProjection (D2PHIA)", truncation); - else if (tproj_name.find("_D2PHIB") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D2PHIB], fout, ievt, - "\nTrackletProjection (D2PHIB)", truncation); - else if (tproj_name.find("_D2PHIC") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D2PHIC], fout, ievt, - "\nTrackletProjection (D2PHIC)", truncation); - else if (tproj_name.find("_D2PHID") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D2PHID], fout, ievt, - "\nTrackletProjection (D2PHID)", truncation); - else if (tproj_name.find("_D3PHIA") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D3PHIA], fout, ievt, - "\nTrackletProjection (D3PHIA)", truncation); - else if (tproj_name.find("_D3PHIB") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D3PHIB], fout, ievt, - "\nTrackletProjection (D3PHIB)", truncation); - else if (tproj_name.find("_D3PHIC") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D3PHIC], fout, ievt, - "\nTrackletProjection (D3PHIC)", truncation); - else if (tproj_name.find("_D3PHID") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D3PHID], fout, ievt, - "\nTrackletProjection (D3PHID)", truncation); - else if (tproj_name.find("_D4PHIA") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D4PHIA], fout, ievt, - "\nTrackletProjection (D4PHIA)", truncation); - else if (tproj_name.find("_D4PHIB") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D4PHIB], fout, ievt, - "\nTrackletProjection (D4PHIB)", truncation); - else if (tproj_name.find("_D4PHIC") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D4PHIC], fout, ievt, - "\nTrackletProjection (D4PHIC)", truncation); - else if (tproj_name.find("_D4PHID") != string::npos) - err += compareMemWithFile >(tproj_disk[TP::D4PHID], fout, ievt, - "\nTrackletProjection (D4PHID)", truncation); - else if (tproj_name.find("_L1PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIA], fout, ievt, - "\nTrackletProjection (L1PHIA)", truncation); - else if (tproj_name.find("_L1PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIB], fout, ievt, - "\nTrackletProjection (L1PHIB)", truncation); - else if (tproj_name.find("_L1PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIC], fout, ievt, - "\nTrackletProjection (L1PHIC)", truncation); - else if (tproj_name.find("_L1PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHID], fout, ievt, - "\nTrackletProjection (L1PHID)", truncation); - else if (tproj_name.find("_L1PHIE") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIE], fout, ievt, - "\nTrackletProjection (L1PHIE)", truncation); - else if (tproj_name.find("_L1PHIF") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIF], fout, ievt, - "\nTrackletProjection (L1PHIF)", truncation); - else if (tproj_name.find("_L1PHIG") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIG], fout, ievt, - "\nTrackletProjection (L1PHIG)", truncation); - else if (tproj_name.find("_L1PHIH") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L1PHIH], fout, ievt, - "\nTrackletProjection (L1PHIH)", truncation); - else if (tproj_name.find("_L2PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L2PHIA], fout, ievt, - "\nTrackletProjection (L2PHIA)", truncation); - else if (tproj_name.find("_L2PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L2PHIB], fout, ievt, - "\nTrackletProjection (L2PHIB)", truncation); - else if (tproj_name.find("_L2PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L2PHIC], fout, ievt, - "\nTrackletProjection (L2PHIC)", truncation); - else if (tproj_name.find("_L2PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L2PHID], fout, ievt, - "\nTrackletProjection (L2PHID)", truncation); - else if (tproj_name.find("_L3PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L3PHIA], fout, ievt, - "\nTrackletProjection (L3PHIA)", truncation); - else if (tproj_name.find("_L3PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L3PHIB], fout, ievt, - "\nTrackletProjection (L3PHIB)", truncation); - else if (tproj_name.find("_L3PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L3PHIC], fout, ievt, - "\nTrackletProjection (L3PHIC)", truncation); - else if (tproj_name.find("_L3PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_ps[TP::L3PHID], fout, ievt, - "\nTrackletProjection (L3PHID)", truncation); - - else if (tproj_name.find("_L4PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L4PHIA], fout, ievt, - "\nTrackletProjection (L4PHIA)", truncation); - else if (tproj_name.find("_L4PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L4PHIB], fout, ievt, - "\nTrackletProjection (L4PHIB)", truncation); - else if (tproj_name.find("_L4PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L4PHIC], fout, ievt, - "\nTrackletProjection (L4PHIC)", truncation); - else if (tproj_name.find("_L4PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L4PHID], fout, ievt, - "\nTrackletProjection (L4PHID)", truncation); - else if (tproj_name.find("_L5PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L5PHIA], fout, ievt, - "\nTrackletProjection (L5PHIA)", truncation); - else if (tproj_name.find("_L5PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L5PHIB], fout, ievt, - "\nTrackletProjection (L5PHIB)", truncation); - else if (tproj_name.find("_L5PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L5PHIC], fout, ievt, - "\nTrackletProjection (L5PHIC)", truncation); - else if (tproj_name.find("_L5PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L5PHID], fout, ievt, - "\nTrackletProjection (L5PHID)", truncation); - else if (tproj_name.find("_L6PHIA") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L6PHIA], fout, ievt, - "\nTrackletProjection (L6PHIA)", truncation); - else if (tproj_name.find("_L6PHIB") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L6PHIB], fout, ievt, - "\nTrackletProjection (L6PHIB)", truncation); - else if (tproj_name.find("_L6PHIC") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L6PHIC], fout, ievt, - "\nTrackletProjection (L6PHIC)", truncation); - else if (tproj_name.find("_L6PHID") != string::npos) - err += compareMemWithFile >(tproj_barrel_2s[TP::L6PHID], fout, ievt, - "\nTrackletProjection (L6PHID)", truncation); - - } cout << endl; } // end of event loop diff --git a/TrackletAlgorithm/MatchProcessor.h b/TrackletAlgorithm/MatchProcessor.h index 7f27ebf90d1..27f72ad6a19 100644 --- a/TrackletAlgorithm/MatchProcessor.h +++ b/TrackletAlgorithm/MatchProcessor.h @@ -913,7 +913,8 @@ void MatchCalculator(BXType bx, const AllStubMemory* allstub, const AllProjection& proj, ap_uint::kVMSIDSize> stubid, - FullMatchMemory fullmatch[maxFullMatchVariants] + FullMatchMemory fullmatch[maxFullMatchVariants], + int istep ){ #pragma HLS inline @@ -1127,7 +1128,7 @@ void MatchCalculator(BXType bx, goodmatch = true; } - if(goodmatch) { // Write out only the best match, based on the seeding + if(goodmatch) { // Write out only the best match, based on the seeding switch (proj_seed) { case 0: if(FMMask()) { @@ -1352,7 +1353,7 @@ void MatchProcessor(BXType bx, auto writeptr = projbufferarray.getWritePtr(); bool empty = emptyUnit()[(readptr,writeptr)]; bool projBuffNearFull = nearFull4Unit()[(readptr,writeptr)]; - + ap_uint<3> iphi = 0; ap_uint idles; @@ -1377,10 +1378,11 @@ void MatchProcessor(BXType bx, } //This printout exactly matches printout in emulation for tracking code differences - /* - for(int iMEU = 0; iMEU < kNMatchEngines; ++iMEU) { - std::cout << " MEU"< smallest = ~emptys; @@ -1458,9 +1458,10 @@ void MatchProcessor(BXType bx, if (hasMatch_save) { isMatch = newtracklet_save ? ap_uint<1>(0) : isMatch; + MatchCalculator (bx, newtracklet_save, isMatch, savedMatch, best_delta_z, best_delta_phi, best_delta_rphi, best_delta_r, allstub, allproj_save, stubindex_save, - fullmatch); + fullmatch, istep); } diff --git a/TrackletAlgorithm/MemoryTemplateBinnedCM.h b/TrackletAlgorithm/MemoryTemplateBinnedCM.h index 7f3c294291a..cf1a28d1a4d 100644 --- a/TrackletAlgorithm/MemoryTemplateBinnedCM.h +++ b/TrackletAlgorithm/MemoryTemplateBinnedCM.h @@ -229,14 +229,12 @@ class MemoryTemplateBinnedCM{ ap_uint ibin; ap_uint ireg; - (ireg,ibin)=slot; + (ibin, ireg)=slot; ap_uint<4> nentry_ibx = nentries_[ibx*kNBinsRZ+ibin].range(ireg*4+3,ireg*4); DataType data(datastr.c_str(), base); - int slot2 = (ibin,ireg); //swap order, should be changed in the input files - - bool success = write_mem(ibx, slot2, data, nentry_ibx); + bool success = write_mem(ibx, slot, data, nentry_ibx); return success; } diff --git a/emData/download.sh b/emData/download.sh index 865d9e55027..24a243ee3e4 100755 --- a/emData/download.sh +++ b/emData/download.sh @@ -1,14 +1,13 @@ #!/usr/bin/env bash set -e - #### generated with branch VMSMERouterCMSSW13, commit a2c799d #### # Combined modules memprints_url_cm="https://cernbox.cern.ch/remote.php/dav/public-files/P2URd03nlGDfpDt/MemPrints.tar.gz" luts_url_cm="https://ahart.web.cern.ch/ahart/tf/test_vectors/LUTs_Combined_231208.tgz" # Split modules - i.e. with PC and VMSMER -memprints_url_split="https://ahart.web.cern.ch/ahart/tf/test_vectors/MemPrints_Split_240607.tgz" -luts_url_split="https://ahart.web.cern.ch/ahart/tf/test_vectors/LUTs_Split_240607.tgz" +memprints_url_split="https://cernbox.cern.ch/remote.php/dav/public-files/MUMRM6yWEBSDWiQ/MemPrints_Split_241116.tgz" +luts_url_split="https://cernbox.cern.ch/remote.php/dav/public-files/lKAs7GNBTXKfR9d/LUTs_Split_241116.tgz" # Reduced Combined modules memprints_url_reducedcm="https://cernbox.cern.ch/remote.php/dav/public-files/kv2U49bw93chvZG/MemPrints_CMReduced_040424.tar.gz" luts_url_reducedcm="https://ahart.web.cern.ch/ahart/tf/test_vectors/LUTs_CMReduced_240121.tgz" @@ -19,6 +18,7 @@ luts_url_cm2="https://ahart.web.cern.ch/ahart/tf/test_vectors/LUTs_CMReduced2_24 memprints_url_cmbarrel="https://cernbox.cern.ch/remote.php/dav/public-files/lVII5Ho0VX7nwFA/MemPrints_Barrel_040424.tar.gz" luts_url_cmbarrel="https://ahart.web.cern.ch/ahart/tf/test_vectors/LUTs_Barrel_240121.tgz" + # Function that prints information regarding the usage of this command function usage() { echo "$(basename $0) [-h|--help] [-t|--tables]" @@ -67,10 +67,14 @@ fi # Download and unpack LUTs.tar.gz, # unless LUTS directory already exists (due to previous "download.sh -t" run). + if [ ! -d "LUTs" ] then + echo "Here10" wget --no-check-certificate -O LUTs.tgz --quiet ${luts_url_split} + echo "Here11" tar -xzmf LUTs.tgz + echo "Here12" mv LUTs LUTsSplit rm -f LUTs.tgz wget --no-check-certificate -O LUTs.tgz --quiet ${luts_url_reducedcm} @@ -91,6 +95,9 @@ then rm -f LUTs.tgz fi +echo "Here2" + + # Run scripts to generate top functions in TopFunctions/ ### combined config mkdir -p ../TopFunctions/CombinedConfig diff --git a/project/script_MP.tcl b/project/script_MP.tcl index e241e101f30..fb13619f7d5 100644 --- a/project/script_MP.tcl +++ b/project/script_MP.tcl @@ -9,23 +9,17 @@ source env_hls.tcl set modules_to_test { {MP_L1PHIC} {MP_L2PHIC} + {MP_L3PHIC} {MP_L4PHIC} + {MP_L5PHIC} {MP_L6PHIC} {MP_D1PHIC} + {MP_D2PHIC} + {MP_D3PHIC} {MP_D4PHIC} {MP_D5PHIC} } -# Skipping L3 because of inconsistency in L3 -# {MP_L3PHIC} -# Skipping these because of diagreement due to truncation with the extra -# pipelining step before the match calculator. Will undo once the emulation -# is upddated -# {MP_L5PHIC} -# {MP_D2PHIC} -# {MP_D3PHIC} - - # module_to_export must correspond to the default macros set at the top of the # test bench; otherwise, the C/RTL cosimulation will fail set module_to_export MP_D1PHIC From c16bca20a07c3f58a4b85c76620e3af99450fe15 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Fri, 22 Nov 2024 21:16:59 -0500 Subject: [PATCH 06/14] Fix comments from A. Hart on PR --- IntegrationTests/common/script/impl.tcl | 3 ++- IntegrationTests/common/script/synth.tcl | 3 ++- TrackletAlgorithm/MatchEngineUnit.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/IntegrationTests/common/script/impl.tcl b/IntegrationTests/common/script/impl.tcl index a985a27464d..58aced01019 100644 --- a/IntegrationTests/common/script/impl.tcl +++ b/IntegrationTests/common/script/impl.tcl @@ -20,7 +20,8 @@ reset_run impl_1 # Implementation update_compile_order -fileset sources_1 -launch_runs impl_1 -jobs 64 +set ncpus [exec nproc] +launch_runs impl_1 -jobs $ncpus wait_on_run impl_1 # Make reports diff --git a/IntegrationTests/common/script/synth.tcl b/IntegrationTests/common/script/synth.tcl index 6f4ac6ea3ba..1aeb599b508 100644 --- a/IntegrationTests/common/script/synth.tcl +++ b/IntegrationTests/common/script/synth.tcl @@ -23,7 +23,8 @@ set_property -name {STEPS.SYNTH_DESIGN.ARGS.MORE OPTIONS} -value {-mode out_of_c # Synthesis update_compile_order -fileset sources_1 -launch_runs synth_1 -jobs 64 +set ncpus [exec nproc] +launch_runs synth_1 -jobs $ncpus wait_on_run synth_1 # Make reports diff --git a/TrackletAlgorithm/MatchEngineUnit.h b/TrackletAlgorithm/MatchEngineUnit.h index 0726eccd490..ab33fc2f407 100644 --- a/TrackletAlgorithm/MatchEngineUnit.h +++ b/TrackletAlgorithm/MatchEngineUnit.h @@ -158,7 +158,7 @@ inline void step(const VMStub stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin //ap_uint::kPRBufferZBinSize -1 + kNBits_MemAddrBinned> slot = iphi_ + use_[iusetmp].range(0,0) + (zbin_ + use_[iusetmp].range(1,1)) * (1 << nbits_vmmeall[LAYER]); zbin__ = zbin_ + use_[iusetmp].range(1,1); - zbin__ = zbin_ + use_[iusetmp].range(1,1); + //Read stub memory and extract data fields auto stubadd=(slot,istubtmp); stubdata__ = stubmem[bx_&1][stubadd]; From 8cff521ba6318e07d0dd2fef06f2d40469b5262d Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Sat, 23 Nov 2024 09:33:01 -0500 Subject: [PATCH 07/14] Remove some print statements --- emData/download.sh | 5 ----- project/script_MP.tcl | 1 - 2 files changed, 6 deletions(-) diff --git a/emData/download.sh b/emData/download.sh index 24a243ee3e4..fa91268ddd4 100755 --- a/emData/download.sh +++ b/emData/download.sh @@ -70,11 +70,8 @@ fi if [ ! -d "LUTs" ] then - echo "Here10" wget --no-check-certificate -O LUTs.tgz --quiet ${luts_url_split} - echo "Here11" tar -xzmf LUTs.tgz - echo "Here12" mv LUTs LUTsSplit rm -f LUTs.tgz wget --no-check-certificate -O LUTs.tgz --quiet ${luts_url_reducedcm} @@ -95,8 +92,6 @@ then rm -f LUTs.tgz fi -echo "Here2" - # Run scripts to generate top functions in TopFunctions/ ### combined config diff --git a/project/script_MP.tcl b/project/script_MP.tcl index fb13619f7d5..0ab3ad46756 100644 --- a/project/script_MP.tcl +++ b/project/script_MP.tcl @@ -15,7 +15,6 @@ set modules_to_test { {MP_L6PHIC} {MP_D1PHIC} {MP_D2PHIC} - {MP_D3PHIC} {MP_D4PHIC} {MP_D5PHIC} } From 70aea7d043fb37b9b0e972dd0fe670cd49bb3530 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Mon, 25 Nov 2024 15:55:11 -0500 Subject: [PATCH 08/14] Add back D3PHI3 as it now agrees with emulation --- project/script_MP.tcl | 1 + 1 file changed, 1 insertion(+) diff --git a/project/script_MP.tcl b/project/script_MP.tcl index 0ab3ad46756..fb13619f7d5 100644 --- a/project/script_MP.tcl +++ b/project/script_MP.tcl @@ -15,6 +15,7 @@ set modules_to_test { {MP_L6PHIC} {MP_D1PHIC} {MP_D2PHIC} + {MP_D3PHIC} {MP_D4PHIC} {MP_D5PHIC} } From 85692000ded59dd9c52efc0b9d75f6a9c17e83b1 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Thu, 28 Nov 2024 00:27:50 -0500 Subject: [PATCH 09/14] Add more MP tests --- project/script_MP.tcl | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/project/script_MP.tcl b/project/script_MP.tcl index fb13619f7d5..8536b95bf81 100644 --- a/project/script_MP.tcl +++ b/project/script_MP.tcl @@ -7,6 +7,17 @@ source env_hls.tcl set modules_to_test { + {MP_L1PHIB} + {MP_L2PHIB} + {MP_L3PHIB} + {MP_L4PHIB} + {MP_L5PHIB} + {MP_L6PHIB} + {MP_D1PHIB} + {MP_D2PHIB} + {MP_D3PHIB} + {MP_D4PHIB} + {MP_D5PHIB} {MP_L1PHIC} {MP_L2PHIC} {MP_L3PHIC} From ba08a21d8a295f63a0ee47a0303b76b41f75f4a5 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Thu, 28 Nov 2024 09:31:50 -0500 Subject: [PATCH 10/14] Clean up some debug statement --- TrackletAlgorithm/MatchEngineUnit.h | 3 ++- TrackletAlgorithm/MatchProcessor.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/TrackletAlgorithm/MatchEngineUnit.h b/TrackletAlgorithm/MatchEngineUnit.h index ab33fc2f407..38ab7c5e1dc 100644 --- a/TrackletAlgorithm/MatchEngineUnit.h +++ b/TrackletAlgorithm/MatchEngineUnit.h @@ -258,7 +258,8 @@ inline void step(const VMStub stubmem[4][1<<(kNbitsrzbinMP+kNbitsphibin //if (good___) { // std::cout << "CAndidateMatc: " << unit_ << " " << index << " " - // << table[index] << " " << pass << " " << passphi << std::endl; + // << table[index] << " " << pass << " " << passphi << " " + // << stubfinephi << " " << projfinephi___ << std::endl; //} good___ = good__; diff --git a/TrackletAlgorithm/MatchProcessor.h b/TrackletAlgorithm/MatchProcessor.h index 27f72ad6a19..5cf5b57eb8c 100644 --- a/TrackletAlgorithm/MatchProcessor.h +++ b/TrackletAlgorithm/MatchProcessor.h @@ -1337,6 +1337,7 @@ void MatchProcessor(BXType bx, // constants used in reading VMS memories constexpr int NUM_PHI_BINS = 1 << kNbitsphibin; constexpr int BIN_ADDR_WIDTH = 4; + PROC_LOOP: for (ap_uint istep = 0; istep < kMaxProc - kMaxProcOffset(module::MP); istep++) { #pragma HLS PIPELINE II=1 rewind @@ -1352,6 +1353,7 @@ void MatchProcessor(BXType bx, auto readptr = projbufferarray.getReadPtr(); auto writeptr = projbufferarray.getWritePtr(); bool empty = emptyUnit()[(readptr,writeptr)]; + bool projBuffNearFull = nearFull4Unit()[(readptr,writeptr)]; ap_uint<3> iphi = 0; @@ -1380,6 +1382,7 @@ void MatchProcessor(BXType bx, //This printout exactly matches printout in emulation for tracking code differences /* std::cout << "istep = " << istep << " projBuff: " << readptr << " " << writeptr << " " << projBuffNearFull; + std::cout << " " << validin << " " << validin_ << " " << validmem; for(unsigned int iMEU = 0; iMEU < kNMatchEngines; ++iMEU) { std::cout << " MEU"< Date: Tue, 3 Dec 2024 14:32:58 -0500 Subject: [PATCH 11/14] Remove unused istep variable in MatchCalculator and zero nentry_mask_tmp in tf_mem_bin.vhd --- IntegrationTests/common/hdl/tf_mem_bin.vhd | 7 ++++--- TrackletAlgorithm/MatchProcessor.h | 5 ++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/IntegrationTests/common/hdl/tf_mem_bin.vhd b/IntegrationTests/common/hdl/tf_mem_bin.vhd index 3516edd57c4..63ac17c67b8 100644 --- a/IntegrationTests/common/hdl/tf_mem_bin.vhd +++ b/IntegrationTests/common/hdl/tf_mem_bin.vhd @@ -244,13 +244,14 @@ begin init := '0'; slv_clk_cnt := (others => '0'); slv_page_cnt := (0 => '1', others => '0'); - --report "tf_mem_bin "&time'image(now)&" "&NAME&" setting nentry_mask_tmp to zero"; + nentry_mask_tmp <= (others => '0'); -- Do we need this??? FIXME + --report "tf_mem_bin "&time'image(now)&" "&NAME&" sync_nent set"; end if; if (init = '0' and to_integer(unsigned(slv_clk_cnt)) < MAX_ENTRIES-1) then -- ####### Counter nent slv_clk_cnt := std_logic_vector(unsigned(slv_clk_cnt)+1); elsif (to_integer(unsigned(slv_clk_cnt)) >= MAX_ENTRIES-1) then -- -1 not included slv_clk_cnt := (others => '0'); - nentry_mask_tmp <= (others => '0'); -- Why do we need this??? FIXME + nentry_mask_tmp <= (others => '0'); -- Do we need this??? FIXME --report "tf_mem_bin "&time'image(now)&" "&NAME&" setting nentry_mask_tmp to zero"; if (to_integer(unsigned(slv_page_cnt)) < NUM_PAGES-1) then slv_page_cnt := std_logic_vector(unsigned(slv_page_cnt)+1); @@ -279,7 +280,7 @@ begin nentry_mask_tmp(to_integer(unsigned(vi_nent_idx))) <= '1'; writeaddr := slv_page_cnt_save & vi_nent_idx & std_logic_vector(binaddr); - --report "tf_mem_bin addra: " & NAME & " " & to_bstring(std_logic_vector(addra)); + --report "tf_mem_bin writeaddr data: " & NAME & " " & to_bstring(writeaddr) & " " & to_bstring(dina); for icopy in 0 to NUM_COPY-1 loop sa_RAM_data(icopy)(to_integer(unsigned(writeaddr))) <= dina; end loop; diff --git a/TrackletAlgorithm/MatchProcessor.h b/TrackletAlgorithm/MatchProcessor.h index 5cf5b57eb8c..4eefa42b5f1 100644 --- a/TrackletAlgorithm/MatchProcessor.h +++ b/TrackletAlgorithm/MatchProcessor.h @@ -913,8 +913,7 @@ void MatchCalculator(BXType bx, const AllStubMemory* allstub, const AllProjection& proj, ap_uint::kVMSIDSize> stubid, - FullMatchMemory fullmatch[maxFullMatchVariants], - int istep + FullMatchMemory fullmatch[maxFullMatchVariants] ){ #pragma HLS inline @@ -1464,7 +1463,7 @@ void MatchProcessor(BXType bx, MatchCalculator (bx, newtracklet_save, isMatch, savedMatch, best_delta_z, best_delta_phi, best_delta_rphi, best_delta_r, allstub, allproj_save, stubindex_save, - fullmatch, istep); + fullmatch); } From 7d9e55def273a1fad6aa31c1187fec28b9dcc8b2 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Tue, 3 Dec 2024 14:37:49 -0500 Subject: [PATCH 12/14] Change to using head of project_generation_scripts --- emData/project_generation_scripts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emData/project_generation_scripts b/emData/project_generation_scripts index f59293a412e..91256ad3c11 160000 --- a/emData/project_generation_scripts +++ b/emData/project_generation_scripts @@ -1 +1 @@ -Subproject commit f59293a412eb98f752b0fac0f9f1c47a2d8beaef +Subproject commit 91256ad3c11e5322fa019a484a4f7781756db9fe From 74d88ddb35bb32b2a2e7742fdc9211b0afa22268 Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Thu, 5 Dec 2024 08:15:58 -0500 Subject: [PATCH 13/14] Add protection against writing too many projections to memory --- TrackletAlgorithm/MemoryTemplateTPROJ.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/TrackletAlgorithm/MemoryTemplateTPROJ.h b/TrackletAlgorithm/MemoryTemplateTPROJ.h index e388be88a03..c355ab55b73 100644 --- a/TrackletAlgorithm/MemoryTemplateTPROJ.h +++ b/TrackletAlgorithm/MemoryTemplateTPROJ.h @@ -57,6 +57,9 @@ class MemoryTemplateTPROJ static constexpr unsigned int DEPTH_BX = 1< BunchXingT; typedef ap_uint NEntryT; @@ -120,8 +123,13 @@ class MemoryTemplateTPROJ //The vhd memory implementation will write to the correct address!! dataarray_[ibx][DEPTH_ADDR*page+addr_index] = data; #else + //NBIT_BX==1 is to identify the projection memories + if (NBIT_BX==1 && nentries_[ibx*NPAGE+page]>=MAX_TPROJ_PAGE_SIZE) { + return false; + } dataarray_[ibx][DEPTH_ADDR*page+nentries_[ibx*NPAGE+page]++] = data; mask_[ibx].set(page); + #endif return true; From 3604a80aa4be512c02fd728e80e0c9b2625f761f Mon Sep 17 00:00:00 2001 From: Anders Ryd Date: Thu, 5 Dec 2024 16:44:10 -0500 Subject: [PATCH 14/14] Fixed is so that TB_D1D2 agrees with emulation --- TrackletAlgorithm/TrackBuilder.h | 20 +++++++++++++++++--- project/script_TB.tcl | 1 + 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/TrackletAlgorithm/TrackBuilder.h b/TrackletAlgorithm/TrackBuilder.h index 7bccf6fd2c0..7af4c27d237 100644 --- a/TrackletAlgorithm/TrackBuilder.h +++ b/TrackletAlgorithm/TrackBuilder.h @@ -264,17 +264,25 @@ void TrackBuilder( // object. ap_uint<3> nMatches = 0; // there can be up to eight matches (3 bits) + //This is a hack to match the emulation where for D1D2 seeds + //We don't use both L2 and D3 matches + bool barrelD1D2Match1 = false; + barrel_stub_association : for (short j = 0; j < NBarrelStubs; j++) { const auto &barrel_stub = merger_L_top[j].peek(); const bool barrel_stub_valid = merger_L_top[j].valid() && smallest[j]; - if (barrel_stub_valid) nMatches++; + if (barrel_stub_valid) { + nMatches++; + barrelD1D2Match1 = Seed == TF::D1D2 && j == 1; + } const auto &barrel_stub_index = (barrel_stub_valid ? barrel_stub.getStubIndex() : FullMatch::FMSTUBINDEX(0)); const auto &barrel_stub_r = (barrel_stub_valid ? barrel_stub.getStubR() : FullMatch::FMSTUBR(0)); const auto &barrel_phi_res = (barrel_stub_valid ? barrel_stub.getPhiRes() : FullMatch::FMPHIRES(0)); const auto &barrel_z_res = (barrel_stub_valid ? barrel_stub.getZRes() : FullMatch::FMZRES(0)); + switch (j) { case 0: track.template setBarrelStub<0>(barrel_stub_valid, barrel_stub_index, barrel_stub_r, barrel_phi_res, barrel_z_res); @@ -313,8 +321,14 @@ void TrackBuilder( disk_stub_association : for (short j = 0; j < NDiskStubs; j++) { const auto &disk_stub = merger_D_top[j].peek(); - const bool disk_stub_valid = merger_D_top[j].valid() && smallest[j+NBarrelStubs]; - if (disk_stub_valid) nMatches++; + bool disk_stub_valid = merger_D_top[j].valid() && smallest[j+NBarrelStubs]; + if (disk_stub_valid) { + nMatches++; + if (Seed == TF::D1D2 and j==0 && barrelD1D2Match1) { + //Hack to not allow D1D2 seed with L2 and D3 match - skip disk match + nMatches--; + } + } const auto &disk_stub_index = (disk_stub_valid ? disk_stub.getStubIndex() : FullMatch::FMSTUBINDEX(0)); const auto &disk_stub_r = (disk_stub_valid ? disk_stub.getStubR() : FullMatch::FMSTUBR(0)); diff --git a/project/script_TB.tcl b/project/script_TB.tcl index eca29515868..ff7064ea036 100644 --- a/project/script_TB.tcl +++ b/project/script_TB.tcl @@ -13,6 +13,7 @@ set modules_to_test { {FT_L2L3} {FT_L3L4} {FT_L5L6} + {FT_D1D2} {FT_D3D4} {FT_L1D1} {FT_L2D1}