CXXFLAGS from CMSSW #304
Merged
CXXFLAGS from CMSSW #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks a very welcome tidy up, but CI seems confused. The "Check" tab on this page reports it failed, but https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/pipelines/6610121 report it succeeded. I suggest making a dummy commit to retrigger another CI run ... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CXXFLAGS from CMSSW_12_6_0_pre5, the current release used for the future SW emulation, to the default flags used for C-simulation. The flags were modified in the following ways:
-Wextrais triggered by header files from Xilinx, so this was removed.-Wno-unused-labelwas added.