Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAL is deprecated #30

Open
benvdh opened this issue Jan 11, 2021 · 0 comments
Open

ADAL is deprecated #30

benvdh opened this issue Jan 11, 2021 · 0 comments

Comments

@benvdh
Copy link

benvdh commented Jan 11, 2021

Hi Chris,

While working on my project based on pypowerbi, I noticed ADAL has been deprecated for a while now. So I'm using the new MSAL library instead. One of the main tricky parts I noticed is that when passing the authentication token, that ADAL apparently used snake_case while MSAL uses CamelCase for its dictionary keys, this caused some exceptions being thrown by pypowerbi not finding the expected key (i.e. auth_token v.s. authToken)...

I'm just adding the issue here, to not forget about it. I can create a pull request for initial MSAL support.

One question, though, @cmberryau : should we maintain support in pypowerbi for ADAL, or can we drop support for it completely?

Announcement:
https://github.com/AzureAD/azure-activedirectory-library-for-python

Migration guide:
https://docs.microsoft.com/en-us/azure/active-directory/develop/migrate-python-adal-msal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant