From b7886070de8d74f3404e632e1f6b06e2a6c54ed5 Mon Sep 17 00:00:00 2001 From: killerwife Date: Sat, 6 Apr 2024 13:05:56 +0200 Subject: [PATCH] [s2477] Creature: Add CharmedSpellList shorthand during charm Common and confirmed on reference --- sql/base/mangos.sql | 3 ++- .../s2477_01_mangos_charmed_spell_list.sql | 5 +++++ src/game/Entities/Creature.cpp | 10 ++++++++++ src/game/Entities/Creature.h | 1 + src/game/Entities/Unit.cpp | 19 +++++++++++++++---- src/game/Server/SQLStorages.cpp | 4 ++-- src/shared/revision_sql.h | 2 +- 7 files changed, 36 insertions(+), 8 deletions(-) create mode 100644 sql/updates/mangos/s2477_01_mangos_charmed_spell_list.sql diff --git a/sql/base/mangos.sql b/sql/base/mangos.sql index 3ed052d594..9f80ad8fea 100644 --- a/sql/base/mangos.sql +++ b/sql/base/mangos.sql @@ -23,7 +23,7 @@ DROP TABLE IF EXISTS `db_version`; CREATE TABLE `db_version` ( `version` varchar(120) DEFAULT NULL, `creature_ai_version` varchar(120) DEFAULT NULL, - `required_s2476_01_mangos_spell_template_ap` bit(1) DEFAULT NULL + `required_s2477_01_mangos_charmed_spell_list` bit(1) DEFAULT NULL ) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC COMMENT='Used DB version notes'; -- @@ -1394,6 +1394,7 @@ CREATE TABLE `creature_template` ( `InteractionPauseTimer` INT(10) NOT NULL DEFAULT -1, `CorpseDecay` INT UNSIGNED NOT NULL DEFAULT '0' COMMENT 'Time before corpse despawns', `SpellList` INT NOT NULL DEFAULT '0' COMMENT 'creature_spell_list_entry', + `CharmedSpellList` INT NOT NULL DEFAULT '0' COMMENT 'creature_spell_list_entry during charm', `StringId1` INT(11) UNSIGNED NOT NULL DEFAULT '0', `StringId2` INT(11) UNSIGNED NOT NULL DEFAULT '0', `AIName` char(64) NOT NULL DEFAULT '', diff --git a/sql/updates/mangos/s2477_01_mangos_charmed_spell_list.sql b/sql/updates/mangos/s2477_01_mangos_charmed_spell_list.sql new file mode 100644 index 0000000000..5fe4f054f2 --- /dev/null +++ b/sql/updates/mangos/s2477_01_mangos_charmed_spell_list.sql @@ -0,0 +1,5 @@ +ALTER TABLE db_version CHANGE COLUMN required_s2476_01_mangos_spell_template_ap required_s2477_01_mangos_charmed_spell_list bit; + +ALTER TABLE `creature_template` ADD COLUMN `CharmedSpellList` INT NOT NULL DEFAULT '0' COMMENT 'creature_spell_list_entry during charm' AFTER `SpellList`; + + diff --git a/src/game/Entities/Creature.cpp b/src/game/Entities/Creature.cpp index 87d5113354..f92948cdc1 100644 --- a/src/game/Entities/Creature.cpp +++ b/src/game/Entities/Creature.cpp @@ -2346,6 +2346,16 @@ void Creature::UpdateSpell(int32 index, int32 newSpellId) void Creature::SetSpellList(uint32 spellSet) { + if (spellSet == 0) + { + m_spellList.Disabled = true; + m_spellList.Spells.clear(); + + if (AI()) + AI()->SpellListChanged(); + return; + } + // Try difficulty dependent version before falling back to base entry auto spellList = GetMap()->GetMapDataContainer().GetCreatureSpellList(spellSet); if (!spellList) diff --git a/src/game/Entities/Creature.h b/src/game/Entities/Creature.h index 48169d1cc1..5b36ee026a 100644 --- a/src/game/Entities/Creature.h +++ b/src/game/Entities/Creature.h @@ -167,6 +167,7 @@ struct CreatureInfo uint32 InteractionPauseTimer; uint32 CorpseDelay; uint32 SpellList; + uint32 CharmedSpellList; uint32 StringID1; uint32 StringID2; char const* AIName; diff --git a/src/game/Entities/Unit.cpp b/src/game/Entities/Unit.cpp index 2f89c9fe82..575d1a4634 100644 --- a/src/game/Entities/Unit.cpp +++ b/src/game/Entities/Unit.cpp @@ -11625,6 +11625,8 @@ Unit* Unit::TakePossessOf(SpellEntry const* spellEntry, SummonPropertiesEntry co if (player) { // Initialize pet bar + if (uint32 charmedSpellList = possessed->GetCreatureInfo()->CharmedSpellList) + possessed->SetSpellList(charmedSpellList); charmInfo->InitPossessCreateSpells(); player->PossessSpellInitialize(); @@ -11692,6 +11694,9 @@ bool Unit::TakePossessOf(Unit* possessed) charmInfo->SetCharmState("PossessedAI"); possessedCreature->SetWalk(IsWalking(), true); getHostileRefManager().deleteReference(possessedCreature); + + if (uint32 charmedSpellList = possessedCreature->GetCreatureInfo()->CharmedSpellList) + possessedCreature->SetSpellList(charmedSpellList); } else if (possessed->GetTypeId() == TYPEID_PLAYER) { @@ -11797,7 +11802,7 @@ bool Unit::TakeCharmOf(Unit* charmed, uint32 spellId, bool advertised /*= true*/ Position combatStartPosition; - if (charmed->GetTypeId() == TYPEID_PLAYER) + if (charmed->IsPlayer()) { Player* charmedPlayer = static_cast(charmed); if (charmerPlayer && charmerPlayer->IsInDuelWith(charmedPlayer)) @@ -11821,7 +11826,7 @@ bool Unit::TakeCharmOf(Unit* charmed, uint32 spellId, bool advertised /*= true*/ charmedPlayer->SendForcedObjectUpdate(); } - else if (charmed->GetTypeId() == TYPEID_UNIT) + else if (charmed->IsCreature()) { Creature* charmedCreature = static_cast(charmed); @@ -11838,6 +11843,9 @@ bool Unit::TakeCharmOf(Unit* charmed, uint32 spellId, bool advertised /*= true*/ charmedCreature->SetFactionTemporary(GetFaction(), TEMPFACTION_NONE); + if (uint32 charmedSpellList = charmedCreature->GetCreatureInfo()->CharmedSpellList) + charmedCreature->SetSpellList(charmedSpellList); + if (isPossessCharm) charmInfo->InitPossessCreateSpells(); else @@ -12020,7 +12028,7 @@ void Unit::Uncharm(Unit* charmed, uint32 spellId) // TODO: maybe should be done on HomeMovementGenerator::MovementExpires charmed->GetCombatManager().SetEvadeState(EVADE_NONE); - if (charmed->GetTypeId() == TYPEID_UNIT) + if (charmed->IsCreature()) { // now we have to clean threat list to be able to restore normal creature behavior Creature* charmedCreature = static_cast(charmed); @@ -12052,9 +12060,12 @@ void Unit::Uncharm(Unit* charmed, uint32 spellId) charmed->DeleteCharmInfo(); } + if (charmedCreature->GetCreatureInfo()->CharmedSpellList) + charmedCreature->SetSpellList(charmedCreature->GetCreatureInfo()->SpellList); + charmed->SetTarget(charmed->GetVictim()); } - else if (charmed->GetTypeId() == TYPEID_PLAYER) + else if (charmed->IsPlayer()) { charmed->AttackStop(true, true); diff --git a/src/game/Server/SQLStorages.cpp b/src/game/Server/SQLStorages.cpp index 0af44e48c1..81a1c0d565 100644 --- a/src/game/Server/SQLStorages.cpp +++ b/src/game/Server/SQLStorages.cpp @@ -18,8 +18,8 @@ #include "Server/SQLStorages.h" -const char CreatureInfosrcfmt[] = "isssiiiiiiiifiiiiliiiiiiiiiffiiiiiiiiffffffiiiiffffiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiss"; -const char CreatureInfodstfmt[] = "isssiiiiiiiifiiiiliiiiiiiiiffiiiiiiiiffffffiiiiffffiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiisi"; +const char CreatureInfosrcfmt[] = "isssiiiiiiiifiiiiliiiiiiiiiffiiiiiiiiffffffiiiiffffiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiss"; +const char CreatureInfodstfmt[] = "isssiiiiiiiifiiiiliiiiiiiiiffiiiiiiiiffffffiiiiffffiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiisi"; const char CreatureDataAddonInfofmt[] = "iibbiis"; const char CreatureConditionalSpawnSrcFmt[] = "iiix"; const char CreatureConditionalSpawnDstFmt[] = "iii"; diff --git a/src/shared/revision_sql.h b/src/shared/revision_sql.h index e9f61b6653..fccea0ca7a 100644 --- a/src/shared/revision_sql.h +++ b/src/shared/revision_sql.h @@ -3,5 +3,5 @@ #define REVISION_DB_REALMD "required_s2474_01_realmd_joindate_datetime" #define REVISION_DB_LOGS "required_s2433_01_logs_anticheat" #define REVISION_DB_CHARACTERS "required_s2473_01_characters_item_instance_text_id_fix" - #define REVISION_DB_MANGOS "required_s2476_01_mangos_spell_template_ap" + #define REVISION_DB_MANGOS "required_s2477_01_mangos_charmed_spell_list" #endif // __REVISION_SQL_H__