Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App installs #76

Open
hirbod opened this issue Mar 15, 2017 · 5 comments
Open

App installs #76

hirbod opened this issue Mar 15, 2017 · 5 comments

Comments

@hirbod
Copy link

hirbod commented Mar 15, 2017

Hi,

are app installs supported?

https://support.google.com/analytics/answer/3389142?hl=en

@cmackay
Copy link
Owner

cmackay commented Mar 15, 2017

Hi @hirbod,

Currently install tracking is not supported. I would consider adding it to the plugin if I didn't feel that it might impact other users. It requires manifest changes in Android which would have to be applied for all users of the plugin. I am not sure if there is a way to conditionally enable parts of the manifest within a cordova plugin. If we enable it for all users, I don't know if there is any issues in doing so. There might not be. But a bigger problem is on the iOS side. This feature requires libAdIdAccess which has been known to cause app store submissions to fail in the past when this was enabled. There is additional info in the issues related to this: https://github.com/cmackay/google-analytics-plugin/search?q=libAdIdAccess&type=Issues&utf8=%E2%9C%93

If there are ways to address these concerns, I would consider enabling this feature but I am not sure that there is a solution for this. Thanks for your message.

-Craig

@hirbod
Copy link
Author

hirbod commented Mar 15, 2017

Hi @cmackay thanks for your response. It should prob. be possible with something like a variable or hook? --variable INSTALLTRACKING="true". I'm not really a plugin-api-pro, but I guess it should be possible this way.

I am already using AdID, and it's not a big deal at all, as long you toggle the correct checkboxes at submit-progress.

@cmackay
Copy link
Owner

cmackay commented Mar 15, 2017

I would recommend forking the project if you want to add this. I am not adding libAdIdAccess due to issues it has caused in the past.

@hirbod
Copy link
Author

hirbod commented Mar 15, 2017

Managing and keeping a fork is pretty time intensive. I would like to figure out if there is any way to include a condition which doesn't interfere with other users setup. (your point is totally clear to me)

@cmackay
Copy link
Owner

cmackay commented Mar 15, 2017

If you find a good solution that will not impact other users and you are willing to help in supporting users as a result of your changes, I welcome a pull request. I just don't want to get caught up in supporting app store rejection issues again. :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants