Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates should be stored as TLS secrets #509

Open
elevran opened this issue Apr 10, 2024 · 1 comment
Open

Certificates should be stored as TLS secrets #509

elevran opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@elevran
Copy link
Collaborator

elevran commented Apr 10, 2024

Currently all ClusterLink secrets are created as type Opaque:

$ kubectl get secret --namespace clusterlink-system
NAME              TYPE     DATA   AGE
cl-controlplane   Opaque   2      19h
cl-dataplane      Opaque   2      19h
cl-fabric         Opaque   1      19h
cl-peer           Opaque   1      19h

Typically, certificates (such as cl-peer) should be using Spec.SecretType: SecretTypeTLS. These have predefined fields for certificate and key.

Search for SecretTypeTLS in corev1 and the kubectl documentation.

The change should affect the clusterlink CLI and any manual deployment documentation (if present).

@elevran elevran added the enhancement New feature or request label Apr 10, 2024
@elevran elevran added this to the May 15 milestone May 2, 2024
@orozery orozery assigned kfirtoledo and unassigned orozery May 2, 2024
@michalmalka michalmalka assigned elevran and unassigned kfirtoledo May 6, 2024
@elevran
Copy link
Collaborator Author

elevran commented May 6, 2024

the ROI on this is low: some risk, low reward (having predefined data fields in secrets and clearer secret type).
Pushing out on fixing this to later with lower priority.
Changes are needed in documentation and YAML templates (mostly adding type: kubernetes.io/tls and changing cert and key to tls.cert and tls.key in secrets. Mount paths need to change accordingly)

@elevran elevran removed this from the May 15 milestone May 6, 2024
@elevran elevran changed the title Certificates should be stored as TLS Certificates should be stored as TLS secrets Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants