Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用thrift用cwgo生成http的代码后hertz_gen下代码不支持最新thrift #231

Open
Lu-Lucifer opened this issue Jan 13, 2025 · 1 comment
Open

使用thrift用cwgo生成http的代码后hertz_gen下代码不支持最新thrift #231

Lu-Lucifer opened this issue Jan 13, 2025 · 1 comment
Assignees
@HeyJavaBean

Comments

@Lu-Lucifer
Copy link

使用thrift用cwgo生成http的代码后hertz_gen下代码不支持最新thrift，cwgo使用的是0.13.0，最新版本thrift为0.21.0，里边protocol.go方法都新增了参数ctx context.Context，可以对这部分进行升级下代码兼容嘛
@xiaost xiaost assigned xiaost and HeyJavaBean and unassigned xiaost Jan 21, 2025
@HeyJavaBean
Copy link
Member

短期内没办法，因为 apache thrift v0.14.0 引入了不兼容变更，对整体代码的改动影响比较大。
但我们在规划长期的解决方案中，例如 kitex，可以参考：https://www.cloudwego.io/zh/docs/kitex/best-practice/remove_apache_codec/
还需要几个版本作为过渡才能平稳兼容

@HeyJavaBean HeyJavaBean reopened this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeyJavaBean HeyJavaBean

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiaost @Lu-Lucifer @HeyJavaBean