Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "rport" in via to support NAT. #99

Open
finntenzor opened this issue Oct 14, 2023 · 1 comment
Open

Add "rport" in via to support NAT. #99

finntenzor opened this issue Oct 14, 2023 · 1 comment

Comments

@finntenzor
Copy link
Contributor

Problem:
Can not connenct to SIP server when client behind a NAT network.

Request Log:

REGISTER sip:[email protected]:7060 SIP/2.0

Via: SIP/2.0/UDP 192.168.1.187:50066;branch=z9hG4bK.iJM9FQ5m5ZRW0ZJZTAvNGlTyN9JPA6Nl
......

What's expected:

REGISTER sip:[email protected]:7060 SIP/2.0

Via: SIP/2.0/UDP 192.168.1.187:50066;rport;branch=z9hG4bK.iJM9FQ5m5ZRW0ZJZTAvNGlTyN9JPA6Nl
......

Solution:
Add an additional "rport" parameter in "Via" when request is prepared. (RFC3581)
I submitted a PR draft at PR 98. This PR only checks the functionality, not the configuration, which may need to be added.
@FireTiger23
Copy link

I also need this feature. Hope to support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FireTiger23 @finntenzor