Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Kube Labels -> Consul Tags sync #4

Open
BarthV opened this issue Aug 31, 2017 · 1 comment
Open

Feature request : Kube Labels -> Consul Tags sync #4

BarthV opened this issue Aug 31, 2017 · 1 comment

Comments

@BarthV
Copy link
Contributor

BarthV commented Aug 31, 2017

Hi !

Since Annotations are not available in Endpoints metadata, I suggest using only label for this case.
This is 2 kinds of possible consul tags :

  • single tags : mytag secondtag ...
  • map tags : foo=bar cluster=acme ...

kube2consul should support both :)

I made a very quick-and-dirty working proof of concept here : https://github.com/BarthV/kube2consul/tree/using-labels

This is what I'm thinking about :

apiVersion: v1
kind: Service
metadata:
  name: my-service-01
  namespace: myservices
  labels:
    k2c-singletags: mytag_secondtag
    foo: bar
    cluster: acme
spec:
[...]

It's also possible to add a "flag" label that would enable/disable this feature to optimize perfs

Thanks !

@BarthV BarthV changed the title Feature request : Kube Labels -> Consul sync Feature request : Kube Labels -> Consul Tags sync Aug 31, 2017
@aevox
Copy link

aevox commented Sep 5, 2017

Hello,

This is a good idea, we were actually thinking about doing this! I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants