Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schedule_rotation] Allow "none" as rotation participant #61

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

diraol
Copy link
Contributor

@diraol diraol commented Jun 14, 2024

what

Allow "none" as a participant on a rotation.

why

This is a valid (and useful) value.

references

schedule_rotation opsgenie module

@diraol diraol requested review from a team as code owners June 14, 2024 21:01
@diraol diraol requested review from hans-d and joe-niland June 14, 2024 21:01
@mergify mergify bot added the triage Needs triage label Jun 14, 2024
@diraol diraol force-pushed the dro/update_schedule_rotations branch 2 times, most recently from 8b1b5ba to ccb4d4d Compare July 23, 2024 17:44
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since "none" is a valid opsgenie schedule rotation type. we probably also need to add this to schedule_rotations module, not just the config module

@diraol
Copy link
Contributor Author

diraol commented Jul 23, 2024

Since "none" is a valid opsgenie schedule rotation type. we probably also need to add this to schedule_rotations module, not just the config module

I belive there isn't a schedule_rotation module in this repo....

@diraol diraol force-pushed the dro/update_schedule_rotations branch from ccb4d4d to 5210218 Compare July 23, 2024 19:13
@Benbentwo
Copy link
Member

/terratest

@mergify mergify bot removed the triage Needs triage label Jul 25, 2024
@diraol
Copy link
Contributor Author

diraol commented Jul 25, 2024

@Benbentwo was this a concurrency issue between PRs?

@Benbentwo
Copy link
Member

Yeah looks like it

Error: Error occurred with Status code: 409, Message: Escalation with [name] [escalation] already exists., Took: 0.047000, RequestId: b3972143-23bf-4085-8936-053989b8045f

@Benbentwo
Copy link
Member

Going to squash and merge this, test looks like failure from conflicting names on tofu/terraform runs

@Benbentwo Benbentwo merged commit f85a0f4 into cloudposse:main Jul 25, 2024
70 of 71 checks passed
@diraol diraol deleted the dro/update_schedule_rotations branch July 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants