-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Existing Resources] Add Team and Schedule #60
Conversation
01b604f
to
d062fda
Compare
This one should be "fixed" as soon as the other PRs are merged. |
49b8de5
to
dcd536b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/terratest
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the data source looked up we need a resource to import it to.
if these are for imports then these should be resources. they can include the import
block.
though is there a reason the code in main
branch cannot be used with a terraform import
for the opsgenie schedule?
Over here we are using a CI to run all opentofu procedures (plan/apply). Users do not have permission to run it locally, so I just don't get why:
|
If we add the datasource for the
The reason the Regarding your problem:
I think you have 2 options.
|
The other option - is if we want to support lookups of teams and schedules, then |
💥 This pull request now has conflicts. Could you fix it @diraol? 🙏 |
5028880
to
eb7251e
Compare
Conflicts fixed and I've also added some changes that were missing (again, forgot while splitting the PR) related to data objects. See if it make sense @Benbentwo - If it doesn't, no hard feelings! :) |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, tests are failing from conflicts (which isn't caused by this PR), config module is unfortunately one that we have tests disabled. we can roll this back if there's any issues or roll forward
what
Add the ability to "import" (data) existing scheduling and team.
why
This is utterly useful especially for migrations with resources managed manually or to integrate multiple teams that handle opsgenie differently (some automated, some manually).
references