Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated argument overwrite on aws_ssm_parameter #64

Open
psy-q opened this issue Jul 5, 2023 · 3 comments
Open

Use of deprecated argument overwrite on aws_ssm_parameter #64

psy-q opened this issue Jul 5, 2023 · 3 comments
Labels
bug 🐛 An issue with the system

Comments

@psy-q
Copy link

psy-q commented Jul 5, 2023

Describe the Bug

The overwrite argument on aws_ssm_parameter has been deprecated:

│ Warning: Argument is deprecated
│ 
│   with module.mq.module.mq_broker.aws_ssm_parameter.mq_application_username[0],
│   on .terraform/modules/mq.mq_broker/main.tf line 74, in resource "aws_ssm_parameter" "mq_application_username":
│   74:   overwrite   = var.overwrite_ssm_parameter
│ 
│ this attribute has been deprecated

See docs for reference: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ssm_parameter#overwrite

Expected Behavior

No deprecation warnings are printed.

Steps to Reproduce

Use terraform-aws-mq-broker 3.1.0 with the aws provider 5.x.

Screenshots

No response

Environment

No response

Additional Context

No response

@psy-q psy-q added the bug 🐛 An issue with the system label Jul 5, 2023
@bateller
Copy link

bateller commented Jul 5, 2023

See: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ssm_parameter#overwrite

Removing the argument will likely cause warnings. However, ignoring the warning and continuing the apply appears to suppress further warnings on subsequent runs, at least in my limited testing with v5.4.0

Until this issue is fixed on the upstream provider: hashicorp/terraform-provider-aws#31655

@psy-q
Copy link
Author

psy-q commented Jul 5, 2023

Thanks, I wasn't aware this was an upstream issue. Nothing left to do but wait, in that case.

@vutny
Copy link

vutny commented Sep 25, 2023

The upstream provider bug seems to be fixed in v5.7.0: hashicorp/terraform-provider-aws@b2d32c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

3 participants