Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mission action to iam policy all #53

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

mfuhrmeisterDM
Copy link
Contributor

what

add

  • ec2:GetTransitGatewayPrefixListReferences
  • ec2:SearchTransitGatewayRoutes actions to iam policy all.

why

We see error messages in datadog that this is not allowed for datadog-integration.

what:
add
* ec2:GetTransitGatewayPrefixListReferences
* ec2:SearchTransitGatewayRoutes
actions to iam policy all.

why:
We see error messages in datadog that this is not allowed for datadog-integration.
@mfuhrmeisterDM mfuhrmeisterDM requested review from a team as code owners November 7, 2023 15:32
@aknysh
Copy link
Member

aknysh commented Nov 7, 2023

@mfuhrmeisterDM thanks for the PR

please run the following commands and commit the changes

make init
make github/init
make readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@mfuhrmeisterDM
Copy link
Contributor Author

@mfuhrmeisterDM thanks for the PR

please run the following commands and commit the changes

make init
make github/init
make readme

There are a lot of changes to the readme, is this really intended?

Also these command change also other files like

  • .github/renovate.json
  • .github/workflows/release-branch.yml
  • .github/workflows/release-published.yml
    Should I commit them also?

@aknysh
Copy link
Member

aknysh commented Nov 7, 2023

@mfuhrmeisterDM thanks for the PR
please run the following commands and commit the changes

make init
make github/init
make readme

There are a lot of changes to the readme, is this really intended?

Also these command change also other files like

  • .github/renovate.json
  • .github/workflows/release-branch.yml
  • .github/workflows/release-published.yml
    Should I commit them also?

yes, please commit

@aknysh
Copy link
Member

aknysh commented Nov 7, 2023

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aknysh aknysh merged commit 65bbd7a into cloudposse:main Nov 7, 2023
9 checks passed
@mfuhrmeisterDM mfuhrmeisterDM deleted the turtle/UPDATE-ACTIONS branch November 7, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants