Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews Broken for PRs originating in Forks #74

Closed
1 task
wildintellect opened this issue Oct 2, 2023 · 3 comments · Fixed by #87
Closed
1 task

Previews Broken for PRs originating in Forks #74

wildintellect opened this issue Oct 2, 2023 · 3 comments · Fixed by #87
Assignees
Labels
bug Something isn't working

Comments

@wildintellect
Copy link
Contributor

This is probably a permissions/security problem related to not previewing content generated outside of the main fork.
https://github.com/cloudnativegeo/cloud-optimized-geospatial-formats-guide/actions/runs/6354887466/job/17262077823?pr=73

TODO: research the github recommended solution for how to deal with this. I know I've seen it written about before.

Acceptance Criteria

  • PRs regardless of fork origin can be previewed before accepting a PR.
@wildintellect wildintellect added the bug Something isn't working label Oct 2, 2023
@wildintellect wildintellect self-assigned this Oct 2, 2023
@wildintellect
Copy link
Contributor Author

The github action we're using does not support forks yet.

This Action does not currently support deploying previews for PRs from forks, but will do so in rossjrw/pr-preview-action#6.

@zacdezgeo
Copy link
Collaborator

I propose the following workaround to integrate external forks in the meantime that we decide on another solution:

  • We create a staging branch
  • We only run the preview action on PRs to main
  • We create some branch restrictions to only accept PRs from staging to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants