Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building image failure #2355

Merged
merged 4 commits into from
Jun 30, 2024
Merged

fix: building image failure #2355

merged 4 commits into from
Jun 30, 2024

Conversation

takaishi
Copy link
Contributor

@takaishi takaishi commented Jun 19, 2024

  • Fix conflicting ruby version between Dockerfile and Gemfile. The ruby version is specified in .ruby-version, so it's unnecessary.
  • Revert dockerfile syntax version. When using 1.8, assets:precompile fails (why !?!?!?)
  • Add .ruby-version to target of renovate

The ruby version is specified in .ruby-version, so it's unnecessary.
@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Jun 19, 2024
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 19, 2024
Copy link

gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 19, 2024
@takaishi takaishi removed the reviewapps Build ReviewApp environment automatically if this label is granted label Jun 19, 2024
Copy link

Simplecov Report

Covered Threshold
61.36% 60%

@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Jun 19, 2024
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 19, 2024
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 19, 2024
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
 > [asset-compile 16/16] RUN --mount=type=cache,uid=1000,target=/app/tmp/cache SECRET_KEY_BASE=hoge RAILS_ENV=production DB_ADAPTER=nulldb bin/rails assets:precompile:
45.61     ERROR in ./app/javascript/stylesheets/cndt2023.scss (./node_modules/css-loader/dist/cjs.js??ref--6-1!./node_modules/postcss-loader/src??ref--6-2!./node_modules/sass-loader/dist/cjs.js??ref--6-3!./app/javascript/stylesheets/cndt2023.scss)
45.61     Module build failed (from ./node_modules/postcss-loader/src/index.js):
45.61     Error: No PostCSS Config found in: /app
45.61         at /app/node_modules/postcss-load-config/src/index.js:91:15
45.61
@takaishi takaishi force-pushed the adjust-ruby-version branch from b27c286 to 99322b6 Compare June 22, 2024 01:10
gitops-for-cloudnativedays bot pushed a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Jun 22, 2024
@takaishi takaishi changed the title remove ruby version from Gemfile fix: building image failure Jun 22, 2024
@takaishi takaishi self-assigned this Jun 22, 2024
@takaishi takaishi marked this pull request as ready for review June 22, 2024 01:17
@takaishi takaishi requested a review from a team June 22, 2024 01:17
@jacopen jacopen merged commit 767621f into main Jun 30, 2024
6 checks passed
@jacopen jacopen deleted the adjust-ruby-version branch June 30, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewapps Build ReviewApp environment automatically if this label is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants