workflowにBuildjetを追加 #2008
Merged
workflowにBuildjetを追加 #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| id: meta | ||
| uses: docker/metadata-action@v4 | ||
| with: | ||
| images: ${{ steps.login-ecr.outputs.registry }}/dreamkast-ecs |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
property "login-ecr" is not defined in object type {} [expression]
There was a problem hiding this comment.
id: login-ecr がここより下に存在するため、上記メッセージの通りDocker meta でコケるように見えます
There was a problem hiding this comment.
Docker metaの実行結果より ${{ steps.login-ecr.outputs.registry }}が空欄となっており機能していませんでしたので修正しました。
Open
|
通知に関しては、statusページで使われているBetterStackがFeedを提供しているので、これをSlackなりなんなりで通知させることで受け取れそう |
merge-images内のcheckoutが不要であるため削除 merge-images内のlogin-ecrの実行箇所を変更
fix: image_tag_refを修正
ShotaKitazawa
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graviton対応に向けて、ARM対応イメージをビルドするBuildjetを追加する。
懸念事項