Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Use default partitioning function with checkkey enabled #642

Open
georgi-lozev opened this issue May 18, 2017 · 3 comments
Open

Use default partitioning function with checkkey enabled #642

georgi-lozev opened this issue May 18, 2017 · 3 comments

Comments

@georgi-lozev
Copy link
Contributor

Does it make sense to set the checkkey property to the default partitioning function to true?

Currently it's undefined which results in balancing to a certain partition even if we don't have a key specified. This in turn leads to partial results in certain search queries.

Do you see any obstacles in changing the default behaviour?

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/145692657

The labels on this github issue will be updated when the story is started.

@hsiliev
Copy link
Contributor

hsiliev commented May 18, 2017

Do we need to adapt the dataflow (and perhaps reduce/map functions) code or we can simply change the default?

@georgi-lozev
Copy link
Contributor Author

As far as I can see in the dataflow we're not using the default and I don't think we need to change that, except we find really strong arguments to do so.

To me it looks like just changing the default, but ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants