-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML-DSA new NIST KAT #506
Comments
What's the difference? I intend to match the standard branch of the crystal's team until NIST releases the final version of FIPS 204. |
I don't know, see more details in the OQS issue. |
Right, the new test vectors include changes that are expected to be included in the final standard, but aren't published in the ipd (initial public draft) yet. We'll wait for the final standard or a new draft before changing this. |
Fix: sign/mldsa/mldsa{ver}/internal/dilithium.go |
I updated the ML-DSA PR to FIPS 204. There are no test vectors yet (the ACVP test vectors only test the internal functions), so we'll wait merging until we have crosschecked this implementation with another. |
Observed that bas/ml-dsa branch has implementation which OK against NIST KAT from Apr 15, 2024.
However there is fresh NIST KAT from May 23, 2024 (KAT history). So need to fix ML-DSA implementation.
The text was updated successfully, but these errors were encountered: