Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-DSA new NIST KAT #506

Closed
UladzimirTrehubenka opened this issue Aug 2, 2024 · 5 comments
Closed

ML-DSA new NIST KAT #506

UladzimirTrehubenka opened this issue Aug 2, 2024 · 5 comments

Comments

@UladzimirTrehubenka
Copy link

Observed that bas/ml-dsa branch has implementation which OK against NIST KAT from Apr 15, 2024.
However there is fresh NIST KAT from May 23, 2024 (KAT history). So need to fix ML-DSA implementation.

@bwesterb
Copy link
Member

bwesterb commented Aug 2, 2024

What's the difference? I intend to match the standard branch of the crystal's team until NIST releases the final version of FIPS 204.

@UladzimirTrehubenka
Copy link
Author

UladzimirTrehubenka commented Aug 2, 2024

What's the difference?

I don't know, see more details in the OQS issue.

@bwesterb
Copy link
Member

bwesterb commented Aug 2, 2024

Right, the new test vectors include changes that are expected to be included in the final standard, but aren't published in the ipd (initial public draft) yet. We'll wait for the final standard or a new draft before changing this.

@bwesterb bwesterb closed this as completed Aug 2, 2024
@UladzimirTrehubenka
Copy link
Author

Fix: sign/mldsa/mldsa{ver}/internal/dilithium.go
replace
PolyDeriveUniformBall(&ch, sig.c[:32]) // SeedSize
with
PolyDeriveUniformBall(&ch, sig.c[:64]) // CTildeSize

@bwesterb
Copy link
Member

bwesterb commented Aug 20, 2024

I updated the ML-DSA PR to FIPS 204. There are no test vectors yet (the ACVP test vectors only test the internal functions), so we'll wait merging until we have crosschecked this implementation with another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants