feat!: Allow custom ECR, rename var.use_ecr_image, and cleanup #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💰 Infracost reportMonthly estimate generatedThis comment will be updated when code changes. |
baolsen
force-pushed
the
2024-12-10-housekeeping
branch
2 times, most recently
from
cddef81 to
d85ec1e
Compare
baolsen
changed the title
baolsen
force-pushed
the
2024-12-10-housekeeping
branch
from
d85ec1e to
ce86705
Compare
baolsen
changed the title
baolsen
commented
Dec 10, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
I moved some sections around to make it easier to read
baolsen
commented
Dec 10, 2024
| @@ -57,59 +58,22 @@ For example: | |||
|
|
|||
| # How to use it | |||
|
|
|||
There was a problem hiding this comment.
Moved the auth steps into their own file
baolsen
commented
Dec 10, 2024
|
|
||
| There are several ways to set up authentication to GitHub. | ||
| Follow the guide [here](/docs/GITHUB-AUTH-SETUP.md). |
There was a problem hiding this comment.
Before merging I probably need to make this a URI like the others. Or it wont work from the TF registry.
baolsen
commented
Dec 10, 2024
| @@ -13,12 +13,6 @@ locals { | |||
|
|
|||
| subnet_arns = [for subnet_id in var.subnet_ids : "arn:aws:ec2:${local.aws_region}:${local.aws_account_id}:subnet/${subnet_id}"] | |||
|
|
|||
There was a problem hiding this comment.
Moved this closer to where the action happens
baolsen
commented
Dec 10, 2024
| local.create_iam_role | ||
| ? aws_iam_role.this[0].arn | ||
| : "arn:aws:iam::${local.aws_account_id}:role/${var.iam_role_name}" | ||
| ) | ||
|
|
||
| artifacts { | ||
| type = "NO_ARTIFACTS" | ||
| } | ||
|
|
There was a problem hiding this comment.
Tweaked the logic a bit
|
I'll also add a precommit hook for codespell for completeness |
baolsen
force-pushed
the
2024-12-10-housekeeping
branch
from
a871c12 to
8113e44
Compare
andrewchees
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
Breaking change, as I decided to change one of the variables a bit to support more use cases.
The plan is to test this branch at the customer before merging it in.