We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice to flag additional user agents using an environment variable
terraform-aws-clickops-notifier/clickopsnotifier/clickops.py
Lines 84 to 91 in be9694c
One example is the aws-cli
"[aws-cli/2.22.28 md/awscrt#0.23.4 ua/2.0 os/macos#24.2.0 md/arch#arm64 lang/python#3.12.8 md/pyimpl#CPython cfg/retry-mode#standard md/installer#source md/prompt#off md/command#s3api.put-bucket-policy]",
This useragent can be caught using ^\[aws-cli\/ regex
^\[aws-cli\/
It would be nice to pass this in as a var to the module
additional_user_agents_re = [ "^\[aws-cli\/", ]
or be allowed to override them completely
user_agents_re = [ "signin.amazonaws.com(.*)", "^S3Console", "^\[S3Console", # noqa: W605 "^Mozilla/", "^console(.*)amazonaws.com(.*)", "^aws-internal(.*)AWSLambdaConsole(.*)", "^\[aws-cli\/", ]
or both
user_agents_re = [ "signin.amazonaws.com(.*)", "^S3Console", "^\[S3Console", # noqa: W605 "^Mozilla/", "^console(.*)amazonaws.com(.*)", "^aws-internal(.*)AWSLambdaConsole(.*)", ] additional_user_agents_re = [ "^\[aws-cli\/", ]
Maybe even customizing the non regex user agents would be nice too
Line 93 in be9694c
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
It would be nice to flag additional user agents using an environment variable
terraform-aws-clickops-notifier/clickopsnotifier/clickops.py
Lines 84 to 91 in be9694c
One example is the aws-cli
This useragent can be caught using
^\[aws-cli\/
regexIt would be nice to pass this in as a var to the module
or be allowed to override them completely
or both
Maybe even customizing the non regex user agents would be nice too
terraform-aws-clickops-notifier/clickopsnotifier/clickops.py
Line 93 in be9694c
The text was updated successfully, but these errors were encountered: