Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of Elastic Shield #226

Open
devth opened this issue Jul 8, 2016 · 9 comments
Open

Enable the use of Elastic Shield #226

devth opened this issue Jul 8, 2016 · 9 comments

Comments

@devth
Copy link

devth commented Jul 8, 2016

https://www.elastic.co/guide/en/shield/current/_using_elasticsearch_java_clients_with_shield.html

@timgluz
Copy link
Contributor

timgluz commented Oct 29, 2016

i'll digg into that;

@timgluz
Copy link
Contributor

timgluz commented Dec 18, 2016

Hi,

I'm almost done with this task, but I have a few question before i start preparing PR.
Is it fine to add the additional dependency for the Shield plugin?
If not, should I publish it as a separate package?

@michaelklishin
Copy link
Member

@timgluz most likely it is, can you elaborate? Is it an open source client library from Elastic? under what license?

@michaelklishin
Copy link
Member

Looks like it has a library part but is not open source. I cannot find any license or usage information.
If so, it should be an optional dependency (e.g. something that applications list as dependencies if they want to use Shield). We can also consider making it a separate ClojureWerkz project.

@timgluz
Copy link
Contributor

timgluz commented Dec 18, 2016

Yes, it's a proprietary extension, managed and owned by Elastic and first install includes only 30days trial; source

That's why I am thinking of creating a new project clojurewerkz.elastisch.shield, which could be added as the additional dependency if people want to work with the shield. And another reason is testing - it requires own separate Docker image with custom configuration for users and roles;

@michaelklishin
Copy link
Member

@timgluz alright. Should I set up a new ClojureWerkz repo for you then?

@timgluz
Copy link
Contributor

timgluz commented Dec 18, 2016

Yes, please;

@michaelklishin
Copy link
Member

@timgluz done: https://github.com/clojurewerkz/elastisch.shield. I'm making sure you have push permissions now.

One question I have w.r.t. Shield support is how we are going to do integration testing if it's a commercial plugin. Not having tests really sucks.

@timgluz
Copy link
Contributor

timgluz commented Dec 18, 2016

Thanks!

I'm adding tests for all the new functionalities and i'm also going to re-use tests from elastisch to test that the Shield clients work as rest-client and native-client.

I'm also going to set up travis for the new project;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants