Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cljr-add-project-dependency document support for deps.edn #547

Open
bo-tato opened this issue Aug 31, 2023 · 1 comment
Open

cljr-add-project-dependency document support for deps.edn #547

bo-tato opened this issue Aug 31, 2023 · 1 comment

Comments

@bo-tato
Copy link

bo-tato commented Aug 31, 2023

The docstring says Add a dependency to the project.clj file. so I thought it will only support lein, but I tried it on my deps.edn project and was pleasantly surprised it worked great 😄
Maybe change the docstring to Add a dependency to project.clj or deps.edn?

Also could maybe improve the error message a little in the case where it doesn't find the project file, maybe in cljr--add-project-dependency change it to something like:

(if-let ((project-file (cljr--project-file))
         (deps (cljr--project-with-deps-p project-file)))
    (cljr--update-file project-file
     ...)
  (error "no project file found"))

so it gives a clear error message with the reason rather than just nil isn't stringp in cljr--project-with-deps-p

@velios
Copy link

velios commented Jan 28, 2024

Also found this description confusing. I published the PR with a correction, I hope it will be accepted into the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants