Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dia.Paper)!: change sorting default to APPROX #2427

Merged
merged 3 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/decorators/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const paper = new dia.Paper({
frozen: true,
async: true,
defaultLink: () => new shapes.standard.Link(),
sorting: dia.Paper.sorting.APPROX,
magnetThreshold: 'onleave',
linkPinning: false,
snapLinks: true,
Expand Down
1 change: 0 additions & 1 deletion examples/dwdm/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const paper = new dia.Paper({
el: document.getElementById('paper'),
model: graph,
async: true,
sorting: dia.Paper.sorting.APPROX,
interactive: false,
cellViewNamespace: cellNamespace,
background: { color: 'transparent' },
Expand Down
1 change: 0 additions & 1 deletion examples/isometric/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ const paper = new dia.Paper({
gridSize: GRID_SIZE,
async: true,
autoFreeze: true,
sorting: dia.Paper.sorting.APPROX,
defaultConnectionPoint: {
name: 'boundary',
args: {
Expand Down
1 change: 0 additions & 1 deletion examples/list/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ const paper = new dia.Paper({
frozen: true,
async: true,
defaultLink: () => new ListLink(),
sorting: dia.Paper.sorting.APPROX,
magnetThreshold: 'onleave',
linkPinning: false,
snapLinks: true,
Expand Down
1 change: 0 additions & 1 deletion examples/shapes-general/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ const paper = new dia.Paper({
model: graph,
frozen: true,
async: true,
sorting: dia.Paper.sorting.APPROX,
interactive: false,
guard: (evt) =>
paper.getLayerNode(dia.Paper.Layers.TOOLS).contains(evt.target)
Expand Down
1 change: 0 additions & 1 deletion examples/tree-of-life/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@ const paper = new dia.Paper({
frozen: true,
async: true,
overflow: true,
sorting: dia.Paper.sorting.APPROX,
cellViewNamespace: shapeNamespace,
clickThreshold: 5,
interactive: {
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/bandwidth/src/bandwidth.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const paper = new dia.Paper({
height: 300,
model: graph,
async: true,
sorting: dia.Paper.sorting.APPROX,
background: { color: '#F3F7F6' },
defaultConnectionPoint: {
name: 'boundary',
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/bus/src/bus.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ var paper = new joint.dia.Paper({
model: graph,
async: true,
frozen: true,
sorting: joint.dia.Paper.sorting.APPROX,
restrictTranslate: true,
defaultConnectionPoint: {
name: 'boundary',
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/container/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
defaultConnectionPoint: {
name: 'boundary'
},
sorting: joint.dia.Paper.sorting.APPROX,
viewport: function(view) {
var element = view.model;
// Hide any element or link which is embedded inside a collapsed parent (or parent of the parent).
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/curves/src/curves.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ const paper = new dia.Paper({
height: 600,
gridSize: 1,
async: true,
sorting: dia.Paper.sorting.APPROX,
background: { color: '#F3F7F6' },
snapLinks: true,
highlighting: {
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/dgl/src/directed-graph.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ var controls = new LayoutControls({
el: document.getElementById('layout-controls'),
paper: new joint.dia.Paper({
el: document.getElementById('paper'),
sorting: joint.dia.Paper.sorting.APPROX,
interactive: function(cellView) {
return cellView.model.isElement();
}
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/dynamic-font-size/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const paper = new joint.dia.Paper({
gridSize: 20,
drawGrid: { name: 'mesh' },
async: true,
sorting: joint.dia.Paper.sorting.APPROX,
background: { color: '#F3F7F6' }
});

Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/elk/src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export const init = () => {
interactive: false,
async: true,
frozen: true,
sorting: joint.dia.Paper.sorting.APPROX,
background: { color: '#F3F7F6' },
viewport: (view) => {
const { sx } = paper.scale();
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/flowchart/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const paper = new dia.Paper({
width: '100%',
height: '100%',
async: true,
sorting: dia.Paper.sorting.APPROX,
background: { color: 'transparent' },
snapLabels: true,
clickThreshold: 10,
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/fta/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ const paper = new dia.Paper({
async: true,
interactive: false,
frozen: true,
sorting: dia.Paper.sorting.APPROX,
cellViewNamespace: shapes,
background: { color: '#131e29' },
viewport: function(view) {
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/icons/src/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const paper = new dia.Paper({
height: '100%',
gridSize: 20,
async: true,
sorting: dia.Paper.sorting.APPROX,
background: { color: '#F3F7F6' },
});

Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/marey/src/marey.js
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ const paper = new dia.Paper({
async: true,
width: 'calc(100% - 20px)',
height: 'calc(100% - 70px)',
sorting: dia.Paper.sorting.APPROX,
interactive: { linkMove: false, vertexMove: true },
background: {
color: BG_COLOR
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/performance/async.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ var paper = new Paper({
model: graph,
async: true,
frozen: true,
sorting: Paper.sorting.APPROX,
defaultAnchor: { name: 'modelCenter' },
defaultConnectionPoint: { name: 'boundary' },
viewport: function(view, isInViewport) {
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/performance/conveyor.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ var paper = new joint.dia.Paper({
height: canvasHeight,
model: graph,
async: true,
sorting: joint.dia.Paper.sorting.APPROX,
background: {
color: '#000000'
}
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/puzzle/src/puzzle.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ var Jigsaw = {
model: graph,
clickThreshold: 5,
async: true,
sorting: joint.dia.Paper.sorting.APPROX
}).on({
'cell:pointerdown': function(pieceView) {
pieceView.model.toFront();
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/roi/src/roi.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ const paper = new dia.Paper({
model: graph,
async: true,
cellViewNamespace: shapes,
sorting: dia.Paper.sorting.APPROX,
defaultConnector: {
name: 'curve'
},
Expand Down
3 changes: 1 addition & 2 deletions packages/joint-core/demo/rough/src/rough.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
model: graph,
clickThreshold: 5,
async: true,
sorting: joint.dia.Paper.sorting.APPROX,
connectionStrategy: joint.connectionStrategies.pinAbsolute,
w connectionStrategy: joint.connectionStrategies.pinAbsolute,
defaultConnectionPoint: { name: 'boundary', args: { selector: 'border' }},
defaultLink: function() {
return new RoughLink();
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/sequence/src/sequence.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
model: graph,
frozen: true,
async: true,
sorting: dia.Paper.sorting.APPROX,
defaultConnectionPoint: { name: 'rectangle' },
background: { color: '#F3F7F6' },
moveThreshold: 5,
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/shapes/src/fills.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const paper = new dia.Paper({
},
gridSize: 1,
async: true,
sorting: dia.Paper.sorting.APPROX,
frozen: true,
model: graph,
defaultConnector: (sourcePoint, targetPoint, vertices) => {
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/demo/ts-demo/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const paper = new joint.dia.Paper({
async: true,
defaultLink: new joint.shapes.app.Link(),
connectionStrategy: joint.connectionStrategies.pinAbsolute,
sorting: joint.dia.Paper.sorting.APPROX,
cellViewNamespace: joint.shapes
});

Expand Down
31 changes: 15 additions & 16 deletions packages/joint-core/docs/demo/dia/Element/js/portZIndex.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ document.addEventListener('DOMContentLoaded', function() {
height: 250,
gridSize: 1,
model: graph,
sorting: joint.dia.Paper.sorting.APPROX,
interactive: false,
cellViewNamespace: joint.shapes
});
Expand All @@ -18,19 +17,19 @@ document.addEventListener('DOMContentLoaded', function() {
size: { width: 80, height: 150 },
attrs: {
bodyMain: {
width: 80,
width: 80,
height: 150,
stroke: '#000000',
strokeWidth: 2,
stroke: '#000000',
strokeWidth: 2,
fill: '#FFFFFF'
},
bodyInner: {
width: 60,
height: 130,
x: 10,
width: 60,
height: 130,
x: 10,
y: 10,
stroke: '#000000',
strokeWidth: 2,
stroke: '#000000',
strokeWidth: 2,
fill: '#8ECAE6'
},
label: {
Expand All @@ -43,7 +42,7 @@ document.addEventListener('DOMContentLoaded', function() {
tagName: 'rect',
selector: 'bodyMain',
className: 'bodyMain'

}, {
tagName: 'rect',
selector: 'bodyInner',
Expand All @@ -60,16 +59,16 @@ document.addEventListener('DOMContentLoaded', function() {
size: { width: 80, height: 150 },
attrs: {
bodyMain: {
width: 80,
width: 80,
height: 150,
stroke: '#000000',
strokeWidth: 2,
stroke: '#000000',
strokeWidth: 2,
fill: '#FFFFFF'
},
bodyInner: {
width: 60,
height: 130,
x: 10,
width: 60,
height: 130,
x: 10,
y: 10,
stroke: '#000000',
strokeWidth: 2,
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/docs/demo/elementTools/js/control.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ document.addEventListener('DOMContentLoaded', function() {
width: 400,
height: 300,
model: graph,
sorting: joint.dia.Paper.sorting.APPROX,
interactive: false,
background: {
color: '#F3F7F6'
Expand Down
1 change: 0 additions & 1 deletion packages/joint-core/docs/demo/highlighters/js/mask.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ document.addEventListener('DOMContentLoaded', function() {
clickThreshold: 5,
highlighting: false,
async: true,
sorting: joint.dia.Paper.sorting.APPROX,
background: {
color: '#F3F7F6'
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<p>The Paper object exposes a <code>sorting</code> object with three values that may be used as values of this option:</p>

<ul>
<li><code>joint.dia.Paper.sorting.EXACT</code> - (default) render views in exactly the same order as reported by <a href="#dia.Graph.prototype.getCells"><code>graph.getCells()</code></a> (views with different z-values are rendered in order, and views with the same z-value are rendered in the order in which they were added). This is by far the slowest option, present mainly for backwards compatibility.</li>
<li><code>joint.dia.Paper.sorting.APPROX</code> - render views according to their z-values. Views with different z-value are rendered in order, but the ordering of views with the same z-value is indeterminate. Similar in functionality to the <code>EXACT</code> option, but much faster.</li>
<li><code>joint.dia.Paper.sorting.APPROX</code> - (default) render views according to their z-values. Views with different z-value are rendered in order, but the ordering of views with the same z-value is indeterminate. Similar in functionality to the <code>EXACT</code> option, but much faster.</li>
<li><code>joint.dia.Paper.sorting.EXACT</code> - render views in exactly the same order as reported by <a href="#dia.Graph.prototype.getCells"><code>graph.getCells()</code></a> (views with different z-values are rendered in order, and views with the same z-value are rendered in the order in which they were added). This is by far the slowest option, present mainly for backwards compatibility.</li>
<li><code>joint.dia.Paper.sorting.NONE</code> - render views in an indeterminate order. (Note that this setting disables all <code>toFront</code>/<code>toBack</code> functions mentioned above.)</li>
</ul>
2 changes: 1 addition & 1 deletion packages/joint-core/src/dia/Paper.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export const Paper = View.extend({

// Rendering Options

sorting: sortingTypes.EXACT,
sorting: sortingTypes.APPROX,

frozen: false,

Expand Down
4 changes: 4 additions & 0 deletions packages/joint-core/test/jointjs/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,8 @@ QUnit.module('basic', function(hooks) {

QUnit.test('toBack(), toFront()', function(assert) {

this.paper.options.sorting = joint.dia.Paper.sorting.EXACT;

var r1 = new joint.shapes.standard.Rectangle;
var r2 = new joint.shapes.standard.Rectangle;

Expand Down Expand Up @@ -796,6 +798,8 @@ QUnit.module('basic', function(hooks) {

QUnit.test('toBack(), toFront() with active batch', function(assert) {

this.paper.options.sorting = joint.dia.Paper.sorting.EXACT;

var r1 = new joint.shapes.standard.Rectangle;
var r2 = new joint.shapes.standard.Rectangle;

Expand Down
2 changes: 2 additions & 0 deletions packages/joint-core/test/jointjs/paper.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ QUnit.module('paper', function(hooks) {

QUnit.test('graph.fromJSON(), graph.toJSON()', function(assert) {

this.paper.options.sorting = joint.dia.Paper.sorting.EXACT;

var json = JSON.parse('{"cells":[{"type":"standard.Ellipse","size":{"width":100,"height":60},"position":{"x":110,"y":480},"id":"bbb9e641-9756-4f42-997a-f4818b89f374","embeds":"","z":0},{"type":"link","source":{"id":"bbb9e641-9756-4f42-997a-f4818b89f374"},"target":{"id":"cbd1109e-4d34-4023-91b0-f31bce1318e6"},"id":"b4289c08-07ea-49d2-8dde-e67eb2f2a06a","z":1},{"type":"standard.Rectangle","position":{"x":420,"y":410},"size":{"width":100,"height":60},"id":"cbd1109e-4d34-4023-91b0-f31bce1318e6","embeds":"","z":2}]}');

this.graph.fromJSON(json);
Expand Down
Loading