New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InstanceName to RedisUserSessionStore #130

Merged

MrSmoke merged 1 commit into master from RedisUserSessionStore-InstanceName

Jan 19, 2024

Member

MrSmoke commented Jan 12, 2024

Added InstanceName to RedisUserSessionCacheOptions
- This adds a key prefix to avoid collisions when multiple applications share the same redis


          Add InstanceName to RedisUserSessionStore

2f9c596

MrSmoke requested a review from kevinwell

January 12, 2024 01:21

MrSmoke assigned kevinwell

kevinwell approved these changes

View reviewed changes

src/AspNetCore/Authentication/StackExchangeRedis/test/RedisUserSessionStoreTests.cs

@@ @@ -52,30 +39,43 @@ public async Task Can_Add_UserSession_To_Redis() @@
                       [SkippableFact]
                       [SkipOnCI(SkipCiReason)]
-                      public async Task Can_Update_UserSession_To_Same_key()
+                      public async Task AddAsync_InstanceName()

Contributor

kevinwell Jan 19, 2024

Did you mean to change this? It's inconsistent with the other test names now.

MrSmoke merged commit d800eca into master

4 checks passed

MrSmoke deleted the RedisUserSessionStore-InstanceName branch

January 19, 2024 02:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet