Add test case for empty path #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djfhe
force-pushed
the
add-test-case-for-empty-path
branch
from
4d7e45d
to
576572e
Compare
saibotk
requested changes
May 26, 2024
| foo: 'bar', | ||
| } as const | ||
|
|
||
| // @ts-expect-error - '' is not define on the property, so it is correct that typescript throws an error here |
There was a problem hiding this comment.
Suggested change
| // @ts-expect-error - '' is not define on the property, so it is correct that typescript throws an error here | |
| // @ts-expect-error - '' is not defined on the object, so it is correct that typescript throws an error here |
| // but as mentioned above, we still will set the value at runtime | ||
| setByPath(test, '', 'bar') | ||
|
|
||
| // @ts-expect-error - '' is not set on the property, so typescript should throw an error here |
There was a problem hiding this comment.
Suggested change
| // @ts-expect-error - '' is not set on the property, so typescript should throw an error here | |
| // @ts-expect-error - '' is not set on the object, so typescript should throw an error here |
Comment on lines
+122
to
+124
| // @ts-expect-error - 'foo' is not set on the property, so typescript should throw an error here | ||
| // but as mentioned above, we still will set the value at runtime | ||
| setByPath(test, '', 'bar') |
There was a problem hiding this comment.
this and the one line afterwards should rather get their own test case. The test name only implies that the access to an unset path is tested
| @@ -110,6 +110,24 @@ it('returns undefined on non objects', () => { | |||
| expect(getByPath(test, 'undef.baz')).toBe(undefined) | |||
| }) | |||
|
|
|||
| it('it returns undefined when accessing an unset path', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('it returns undefined when accessing an unset path', () => { | |
| it('returns undefined when accessing an unset path', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some test cases to ensure correct handling of an empty path.