Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Optimize @clerk/vue #4820

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Dec 20, 2024

Description

This PR ensures that @clerk/vue is properly pre-bundled by Vite to prevent duplicate versions (registered and unregistered) from being created. This addresses an error that occurs when running an app with the @clerk/nuxt module installed on first load:

Screenshot 2024-12-19 at 7 18 36 PM

To reproduce this error:

  1. Clone and run the quickstart in dev mode, or
  2. In the quickstart project, remove node_modules/.cache and run npm run dev

A similar fix was implemented here.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:32am

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 29f041a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano wobsoriano merged commit 389133b into main Dec 20, 2024
29 checks passed
@wobsoriano wobsoriano deleted the rob/fix-nuxt-sdk-losing-vue-context branch December 20, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants