Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): Improve error message when Publishable Key is missing #4785

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

anagstef
Copy link
Member

Description

The shared function parsePublishableKey should throw a different error when the key is missing.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 6:23pm

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 1a2b5ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef changed the title fix(shared): Improve error message when Publishable Key is missing fix(shared): Improve error message when Publishable Key is missing Dec 16, 2024
packages/shared/src/keys.ts Outdated Show resolved Hide resolved
@BRKalow BRKalow dismissed their stale review December 17, 2024 02:56

Dismissing so you can merge tomorrow

@anagstef anagstef merged commit 84ccb00 into main Dec 17, 2024
29 checks passed
@anagstef anagstef deleted the stefanos/separate-pk-missing-from-invalid branch December 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants