-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Force devBrowser to create suffixed cookies #4776
fix(clerk-js): Force devBrowser to create suffixed cookies #4776
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const get = () => suffixedDevBrowserCookie.get() || devBrowserCookie.get(); | ||
const get = (mode?: 'only-suffixed') => { | ||
if (mode === 'only-suffixed') { | ||
suffixedDevBrowserCookie.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panteliselef Maybe a typo? 😬
suffixedDevBrowserCookie.get(); | |
return suffixedDevBrowserCookie.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, i must removed it by mistake, i verified that without return
it would break. So the change is verified that works.
🦋 Changeset detectedLatest commit: 0154d0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…_db_jwt-between-handshake-and
!snapshot |
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
Description
Previously, if Clerk JS was loaded in an environment where:
the mismatch between the loaded publishable key and the existing database JWT caused the application to break. We would attempt to load the Client and Environment even though the existing cookie (JWT) did not match our active environment.
This issue affects only CSR application or application that do not run below a clerk middleware with handshake support. (nextjs apps are not affected).
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change