Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-react): Infer React.JSX.Element instead of explicit JSX.Element #4740

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Dec 9, 2024

Description

This PR removes explicit JSX.Element return type annotations in favor of inferred return types, which will be React.JSX.Element. This should improve compatibility with React 19's types, which removed the global JSX namespace.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@dstaley dstaley requested a review from a team December 9, 2024 20:44
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: aea7348

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/elements Patch
@clerk/clerk-expo Patch
@clerk/nextjs Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:44pm

@dstaley
Copy link
Member Author

dstaley commented Dec 9, 2024

!snapshot

Copy link
Member

@jacekradko jacekradko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@clerk-cookie
Copy link
Collaborator

Hey @dstaley - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.0.1-snapshot.v20241209205801
@clerk/backend 1.20.3-snapshot.v20241209205801
@clerk/chrome-extension 2.0.9-snapshot.v20241209205801
@clerk/clerk-js 5.40.3-snapshot.v20241209205801
@clerk/elements 0.21.4-snapshot.v20241209205801
@clerk/clerk-expo 2.4.5-snapshot.v20241209205801
@clerk/expo-passkeys 0.0.17-snapshot.v20241209205801
@clerk/express 1.3.26-snapshot.v20241209205801
@clerk/fastify 2.0.28-snapshot.v20241209205801
@clerk/localizations 3.8.2-snapshot.v20241209205801
@clerk/nextjs 6.8.3-snapshot.v20241209205801
@clerk/nuxt 0.0.13-snapshot.v20241209205801
@clerk/clerk-react 5.19.3-snapshot.v20241209205801
@clerk/react-router 0.0.2-snapshot.v20241209205801
@clerk/remix 4.3.6-snapshot.v20241209205801
@clerk/clerk-sdk-node 5.0.77-snapshot.v20241209205801
@clerk/shared 2.19.4-snapshot.v20241209205801
@clerk/tanstack-start 0.6.6-snapshot.v20241209205801
@clerk/testing 1.3.38-snapshot.v20241209205801
@clerk/themes 2.1.55-snapshot.v20241209205801
@clerk/types 4.39.2-snapshot.v20241209205801
@clerk/ui 0.2.4-snapshot.v20241209205801
@clerk/vue 0.0.17-snapshot.v20241209205801

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

@dstaley dstaley merged commit 9d656c1 into main Dec 10, 2024
29 checks passed
@dstaley dstaley deleted the ds.fix/rm-jsx-element branch December 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants