Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Next.js@15 compatibility #4366

Merged
merged 12 commits into from
Oct 22, 2024
Merged

feat(nextjs): Next.js@15 compatibility #4366

merged 12 commits into from
Oct 22, 2024

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Oct 18, 2024

Description

Next.js@15 compatibility integration branch

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 9b8cccd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@clerk/nextjs Major
@clerk/upgrade Minor
@clerk/clerk-react Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/remix Patch
@clerk/tanstack-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@drosi94
Copy link

drosi94 commented Oct 22, 2024

Is there anything to be done? We could help to push it on main as the Next.JS just released v15

@drosi94 drosi94 mentioned this pull request Oct 22, 2024
4 tasks
@jacekradko jacekradko changed the title feat(nextjs): next.js@15 compatibility feat(nextjs): Next.js@15 compatibility Oct 22, 2024
@jacekradko jacekradko marked this pull request as ready for review October 22, 2024 05:44
@jacekradko
Copy link
Member Author

!allow-major

Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@BRKalow BRKalow merged commit a0204a8 into main Oct 22, 2024
21 checks passed
@BRKalow BRKalow deleted the feat/nextjs-15-compat branch October 22, 2024 07:07
@ChristianIvicevic
Copy link

ChristianIvicevic commented Oct 22, 2024

I have tested the canary for this with 6.0.0-canary.va0204a8 and noticed that the types for the clerkMiddleware aren't correct yet.

export default clerkMiddleware(async (auth, request) => {
  const { sessionClaims } = await auth() // auth() is not a Promise over here and causes TS and eslint to complain
  // ...
  if (!isPublicRoute(request)) {
    try { await auth.protect() } // works as expected
    catch (e) { unstable_rethrow(e) }
  }
})

Do you want me to open a separate issue to track this?

@dstaley
Copy link
Member

dstaley commented Oct 22, 2024

@ChristianIvicevic Thanks for reporting this! It was fixed in 6.0.0-canary.vee453d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants