Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nextjs)!: Require CLERK_ENCRYPTION_KEY for secretKey as dynamic key #4360

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Oct 18, 2024

Description

Resolves SDKI-485

Prepares for the major release, replacing the previous warning for missing CLERK_ENCRYPTION_KEY with an actual error.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Oct 18, 2024
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: bc713c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris changed the title chore(nextjs)!: Throw error for missing CLERK_ENCRYPTION_KEY chore(nextjs)!: Throw error for missing CLERK_ENCRYPTION_KEY for clerkMiddleware dynamic keys Oct 18, 2024
@LauraBeatris LauraBeatris changed the title chore(nextjs)!: Throw error for missing CLERK_ENCRYPTION_KEY for clerkMiddleware dynamic keys chore(nextjs)!: Throw error when missing CLERK_ENCRYPTION_KEY for clerkMiddleware dynamic keys Oct 18, 2024
@LauraBeatris LauraBeatris changed the title chore(nextjs)!: Throw error when missing CLERK_ENCRYPTION_KEY for clerkMiddleware dynamic keys chore(nextjs)!: Require CLERK_ENCRYPTION_KEY for secretKey dynamic key Oct 18, 2024
@LauraBeatris LauraBeatris changed the title chore(nextjs)!: Require CLERK_ENCRYPTION_KEY for secretKey dynamic key chore(nextjs)!: Require CLERK_ENCRYPTION_KEY for secretKey as dynamic key Oct 18, 2024
@LauraBeatris
Copy link
Member Author

We forgot to include this PR on the V6 major version, therefore I'll close this in order to not become stale. Let's come back to it on V7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants